Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
Summary: | [From Symphony]it's slow to open the simple xslx file | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Calc | Reporter: | bjcheny <companycy> | ||||||||
Component: | open-import | Assignee: | AOO issues mailing list <issues> | ||||||||
Status: | CONFIRMED --- | QA Contact: | |||||||||
Severity: | Normal | ||||||||||
Priority: | P3 | CC: | polo8495, tldyzem | ||||||||
Version: | 4.0.0-dev | ||||||||||
Target Milestone: | --- | ||||||||||
Hardware: | All | ||||||||||
OS: | Windows XP | ||||||||||
Issue Type: | DEFECT | Latest Confirmation in: | --- | ||||||||
Developer Difficulty: | --- | ||||||||||
Attachments: |
|
It takes almost 300 sec to open sample file on my pc. I am working on patch for this problem. Created attachment 79126 [details]
patch for performance of importing cell style in xslx
The cause is StyleSheetChanged/PageStyleModified action much too frequently.
Thus the patch disables it, and will only do StyleSheetChanged/PageStyleModified once after all properties are set.The changes are:
1. Split the SetOnePropertyValue into SetOnePropertyValueWithoutUpdate and StyleSheetChanged,
2. Only invoke StyleSheetChanged once after all properties are set by SetOnePropertyValueWithoutUpdate .
It can improve the performance of importing cell style significantly.
Created attachment 79163 [details]
patch for performance of importing cell style in xslx - part 2
Another patch for performance improvement for importing cell styles in xslx.
In this sample, there are up to 28380 records of user-defined Xf to import. It consumes a lot of time. In fact, only 4050 Xf records can be supported in sc module.
Thus the patch modifies total count of Xf to import to 4050 in oox module,if exceeding.
Confirm this bug at my side, change bug to confirm status Some review comments: For part1: I think it's ok to do so to reduce import time by limit the useless operation. For part2: I think it does not make sense to do so, how could we get the 4050 for max support No.? I don't think for OOXML file import, it has such limit for AOO to support more than 4050 styles. Pls help confirm this limitation, thx! Comment on attachment 79126 [details] patch for performance of importing cell style in xslx Mark this patch duplicated with bug 120824 |
Created attachment 79003 [details] Sample xslx takes long time to open It takes long time to open simple xslx file.