Issue 120656

Summary:	the bold,with / and with X strike through change to single when save to doc
Product:	Writer	Reporter:	Du Jing <bjdujing>
Component:	save-export	Assignee:	AOO issues mailing list <issues>
Status:	RESOLVED FIXED	QA Contact:
Severity:	Normal
Priority:	P3	CC:	damjan, petko
Version:	3.4.0	Keywords:	ms_interoperability
Target Milestone:	---
Hardware:	All
OS:	All
Issue Type:	DEFECT	Latest Confirmation in:	---
Developer Difficulty:	---

Description Du Jing 2012-08-22 08:21:33 UTC

build info:AOO3.4_r1372282

steps:
1.launch OO and new a text document
2.insert some text
3.set strike through with bold,"/","X"
4.save to doc and reopen

defect:
the three style strike through become to single

Comment 1 damjan 2020-07-31 05:14:01 UTC

Microsoft Office (at least as late as) 2007, only supports single and double strikethrough style, there is no X or /. A more recent versions (possibly 2016) is the same. Even the online version, at the time of writing, is the same. 

Even loading ODF file into Microsoft Office with style X and /, shows them as single strikethrough instead.

Since Microsoft Office has apparently never supported X and / strikethrough styles, it is highly unlikely that its file formats have either. Apache POI also only sees single and double strikethrough for the DOC file format.

I would it's not a bug in our DOC loading/saving, but a bug in the unit test in that it expects too much, and it should be testing for a conversion to single strikethrough instead.

Comment 2 Peter 2020-07-31 05:19:34 UTC

+1
How about adding a double strike testcase to the unit test?

Comment 3 damjan 2020-07-31 05:37:28 UTC

I changed our unit test to be more realistic about .doc's limitations. This isn't technically a bug in AOO at all, but since it's a bug in a unit test, I'll close it as RESOLVED FIXED.

commit 4e588b9e25e0ea797c0e7d78b564a1b48a56819e (HEAD -> trunk, origin/trunk, origin/HEAD)
Date:   Fri Jul 31 07:30:41 2020 +0200

    Deal with a test that expects strikeout style (X, /, bold, etc.)
    to be preserved when saving to .doc, even though neither
    the fileformat, nor apparently MS Office itself, support that.
    
    Closes i120656 - the bold,with / and with X strike through change to single when save to doc
    
    Patch by: me

Comment 4 damjan 2020-07-31 05:38:10 UTC

(In reply to Peter from comment #2)
> +1
> How about adding a double strike testcase to the unit test?

The unit test already had a double strikeout testcase, and still does. It passes.

Comment 5 Peter 2020-07-31 05:38:51 UTC

Ahh Awesome! Thanks Damjan!

Comment 6 damjan 2020-07-31 05:41:20 UTC

(In reply to Peter from comment #5)
> Ahh Awesome! Thanks Damjan!

Pleasure :)