Issue 101255 - Font selection - tab does not go to next control
Summary: Font selection - tab does not go to next control
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: code (show other issues)
Version: OOO300m5
Hardware: All All
: P3 Trivial (vote)
Target Milestone: 3.4.0
Assignee: eric.savary
QA Contact: issues@sw
URL:
Keywords: accessibility
Depends on:
Blocks:
 
Reported: 2009-04-21 23:05 UTC by cno
Modified: 2017-05-20 10:22 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description cno 2009-04-21 23:05:18 UTC
- writer document
- open style or character dlg, tab font
- type Shift-End to selct the whole name of the font
- type A (to select Arial)
- type TAB, to move cursor to next control (font size)
 > cursor cycles between Arial, Arial Black and Arial Narrow

(Is BTW the same in style dlg for Calc, so probably all other modules)
Comment 1 cno 2009-04-21 23:07:54 UTC
was OK in ?? (not in 3.0, I see now)
Comment 2 eric.savary 2009-04-21 23:18:03 UTC
So it's not a regression (reproducible in 2.4.2)
Not even sure it's not a feature... (Some kind of Autocomplete)

@PL: what do you think?
Comment 3 cno 2009-04-22 06:38:35 UTC
I really thought it worked directly in previous versions.
I use it quite often. But somewhere in the last year(s) I probably got used to a
different way of working.
After
 - type A (to select Arial)
I do
 - arrow up - arrow down
and then
 - tab to next control
Comment 4 vseredkine 2009-04-26 23:57:43 UTC
Not comfirmed on Windows XP  in OOO310m9 (Build:9396.)May be it fixed in this 
release.
Comment 5 cno 2009-04-27 08:27:53 UTC
Hi vseredkine_hitekschool,
It is this version that I see the problem in.

Have you tried it with a font, that starts with a character that has more than
one entry? (Arial, Arial Black, Arial Narrow)

I think this behaviour is not desired. 
Even more since it is not consequent when you compare to for example the dialog
for fields: When I open that
 - select the Tab Document make sure list Type has the focus
 - type an S to select Sender (English version) 
 > now Tab does bring the focus to the list Select, 
   and not to the entry Statistics in the list Type...
Comment 6 philipp.lohmann 2010-08-09 13:52:36 UTC
Indeed, this is the autocompletion of Edit fields (or in this case its
derivative the ComboBox). Indeed using tab here is a bit awkward, on the other
hand tab is one of the more commonly used keys for autocompletion.

So to what (if any) should I change the key for autocompletion ? Setting clu
from UX on CC.
Comment 7 cno 2010-08-16 11:27:56 UTC
@pl thanks for the explanantion.
Indeed I think that any possible change should be guided by ux.
Comment 8 christoph.lukasiak 2010-08-16 13:26:11 UTC
not sure .. more consequent behavior vs. autocompletion for all

.. if you 'only' select the combobox (for further tabbing/travelling) you must
find an additional way to autocomplete (if you want it .. as pl told me,
autocompletion is the supported behavior now) that would be more consequent, but
would force an other maybe exotic keyboard shortcut? also it should be possible
than to leave the autocomplete mode with esc.

any suggestion es & mt?
Comment 9 christoph.lukasiak 2010-08-16 13:30:59 UTC
set the a11y keyword
Comment 10 malte_timmermann 2010-08-16 13:57:00 UTC
The current behavior breaks keyboard accessibility.

In the GUI, people are used to use TAB to get to the next control.

Beside that, it is very difficult with the current behavior to leave auto
completion mode. ESC will escape the dialog, not the auto completion. Return
will select the font. The only way to escape is to first use key-up/down.

IMHO the current tab auto complete feature can simply be removed.
While typing, the best match is selected in the list box, and you can use
key-up/down. I don't see any advantage in a key for only cycling in entries
starting with the matched sub string.

In case this feature really is/was meaningful in some dialog, the desired
behavior should be discussed for the specific case. So I suggest to comment out
that feature, note a date when the code can be removed if really not needed. And
if needed, we make this feature optional, off per default.
Comment 11 malte_timmermann 2010-08-16 14:02:38 UTC
It's also surprising for the user that _nothing_ will happen on TAB, if auto
complete only contains one match.

Keyboard accessibility broken, so I set the target to 3.4.

And of course it's a defect, not an enhancement.
Comment 12 philipp.lohmann 2010-08-16 14:14:10 UTC
And that from the man who implemented the autocompletion in the first place ... ;-)

However changing an old feature just because people don't like it anymore is
certainly not fixing a defect. Anyway is everyone really happy with simply
removing this ? Also do we remove the autocompletion in only this dialog or for
every Edit field ? Simply setting a target not a specifcation does make.
Comment 13 malte_timmermann 2010-08-16 14:27:53 UTC
Just for clarification: I just want to remove the auto completion via TAB, not
the complete auto completion feature.
The other stuff:Find matching entry when typing text, highlight entry in list
box, add remaining text as selected text at the end, should stay as it is.
Comment 14 philipp.lohmann 2010-08-16 14:33:17 UTC
which again brings us to the question: how does the user cycle through the
autocompletions if not with TAB ?
Comment 15 malte_timmermann 2010-08-16 14:52:44 UTC
From my point of view: Not at all!

IMHO it's good enough to select the matching entry in the list box, and use
arrow keys than.

Of course this is different then auto completion, but...

UX's opinion?
Comment 16 cno 2010-08-16 15:24:18 UTC
@mt, pl, ..
Thanks for the discussion ;-)
for me; tab to next control and when necessary arrow down for next item in the
list is more logical.
Comment 17 christoph.lukasiak 2010-08-17 09:53:25 UTC
in my opinion it is too expensive to put a good working feature/functionality
into 'trash' (i am sure a lot of people still benefit from it). as i see it now,
the bigger problem is not to run into an assumed trap, but to came out easily if
you feel trapped; so if the esc key would work properly, it would disarm the
trap situation and simultaneously keep the advanced functionality of autocompletion.

=> after inserting into a combo box the esc key must select the combo box and
not close the dialog etc. .. than you can travel further with tab.
Comment 18 cno 2010-08-17 11:06:26 UTC
@clu: when you say  "a good working feature/functionality"  do you mean
autocompletion or tab to cycle through the various entries?

Do many people use tab to cycle through the entries, or do they just continue
typing?

Yesterday I worked with bookmarks and then realised it is the same kind of list
box. But I never had a problem there: always I just naturally used the arrow key
to go to a next entry - if necessary. End never tried the Tab, because there is
no need in that dialog.

But OK: if there is data that supports the idea that (many) people do use the
cycle-with-tab methode, it would be better not to change it.

But then Escape to leave the autocomplete mode... what happens if there is just
one entry? Do you need to type escape then too? At the moment, with on entry,
tab directly goes to the next control.
Comment 19 malte_timmermann 2010-08-17 11:37:52 UTC
mt->clu: I doubt that the TAB feature for auto completion is very useful here.
But if you want to keep it, you should define an other key combination instead
of TAB.

The way we handle the TAB key now breaks standard key binding / TAB handling in
GUI, which means it breaks accessibility.

Users expect to get to the next control with TAB. Especially screen readers
users can't understand what's going on when trapped in the auto completion
cycle. And everybody would fear/expect that ESC would cancel the dialog (which
also is a standard key binding).

Also I don't agree that features shouldn't be removed.

I have implemented it in the way it works now almost 15 years ago. That means it
probably was handled this way in some native Win95 GUI. I am not aware of any
system/GUI which handles it this way nowadays.
Comment 20 philipp.lohmann 2010-10-11 15:43:38 UTC
Since there seems to be no further input to this issue and the votes for
removing the "autocompletion cycle with tab" feature are 2:1, I'll remove it.

Done so in CWS vcl116
Comment 21 christoph.lukasiak 2010-10-13 12:17:26 UTC
thx pl,

but to make the decision more understandable: you have not fixed the issue
because of 2:1 votes :) at least i hope so .. but the long ago discussion out of
this issue with mt's 'killer' argument which stopped further discussions: 

'The standard key binding for dialog navigation is broken, so it's an
accessibility issue, which needs to be fixed.'


bye chris
Comment 22 philipp.lohmann 2010-10-26 17:19:27 UTC
please verify in CWS vcl116
Comment 23 eric.savary 2010-11-02 12:34:45 UTC
Verified in CWS vcl116.