Issue 102556 - Selctions work incorrectly in Impress if document contains many tables
Summary: Selctions work incorrectly in Impress if document contains many tables
Status: CLOSED FIXED
Alias: None
Product: Impress
Classification: Application
Component: editing (show other issues)
Version: DEV300m50
Hardware: Unknown Linux, all
: P3 Trivial with 5 votes (vote)
Target Milestone: OOo 3.2
Assignee: wolframgarten
QA Contact: issues@graphics
URL:
Keywords: regression
: 103447 103810 (view as issue list)
Depends on:
Blocks:
 
Reported: 2009-06-06 09:29 UTC by annulen
Modified: 2009-09-07 07:48 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
Example of file with such strange behaviour of Impress (odp also affected). Please don't republish in other places (1.67 MB, application/vnd.ms-powerpoint)
2009-06-06 09:40 UTC, annulen
no flags Details
much simpler file showing the error with text (18.73 KB, application/vnd.oasis.opendocument.presentation)
2009-07-22 10:39 UTC, clippka
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description annulen 2009-06-06 09:29:05 UTC
When trying to select some object (by clicking on it) in document containing
many tables, one of tables is selected. When it is deleted, another one is
selected instead of object which was clicked. When trying to force selection of
right thing by double clicking it, OOo crashes
When one or two tables are deleted, Impress behaves normally.
Comment 1 annulen 2009-06-06 09:40:39 UTC
Created attachment 62816 [details]
Example of file with such strange behaviour of Impress (odp also affected). Please don't republish in other places
Comment 2 wolframgarten 2009-06-08 09:09:07 UTC
Please give a step by step description of what you try to delete. Please have a
look at the status bar what is being selected. Thanks.
Comment 3 datazephyr 2009-06-09 06:17:01 UTC
•Platform: PC 
•OS: Windows Server 2008 x86/x64 
•Version: Dev300m48 

I used the following step by step instructions:

•Save attachment to hard drive 
•Start OOo and select File/Open 
•Navigate to file saved (Poster.ppt) and double-click to open 
•Selected an object that was not a table and deleted it to observe bug. 
•Bug not reproducible.
•Selected another object that was not a table and deleted it to observe bug. 
•Bug not reproducible.
•Selected a table object and deleted it. 
•Bug not reproducible.
•Close and discard modifed file.
•Exit OOo.
•Delete saved file on hard drive. (To prevent publication) 

Please attempt a similar step by step description to allow others to observe 
the bug on the hardware/OA found.

Thank you.
Comment 4 datazephyr 2009-06-09 06:20:12 UTC
•Platform: PC 
•OS: Windows Server 2008 x86/x64 
•Version: Dev300m48 

I used the following step by step instructions:

•Save attachment to hard drive 
•Start OOo and select File/Open 
•Navigate to file saved (Poster.ppt) and double-click to open 
•Selected an object that was not a table and deleted it to observe bug. 
•Bug not reproducible.
•Selected another object that was not a table and deleted it to observe bug. 
•Bug not reproducible.
•Selected a table object and deleted it. 
•Bug not reproducible.
•Close and discard modifed file.
•Exit OOo.
•Delete saved file on hard drive. (To prevent publication) 

Please attempt a similar step by step description to allow others to observe 
the bug on the hardware/OS found.

Thank you.
Comment 5 annulen 2009-06-12 13:46:04 UTC
I've used unofficial build of 3.1 for Ubuntu. Now I've installed official stable
release of 3.1 , but it behaves the same way. I don't use Windows so I don't
know if Windows version is affected or not.

To reproduce bug:
1. Open attached filen
2. Change zoom to see whole document on the scree
3. Click image in upper-left corner, or small text in the header (when it looks
like arrow and does't change to text-editing mode), or some other graphic object
(not a table)
4. See that one of table is selected instead of that you've clicked. Status bar
indicates that "Table selected"
5. Nevertheless, some graphic objects in the document can be selected normally.
6. When trying to use Select tool from toolbar to select area with desired
object (which can't be selected directly) OOo crashes
Comment 6 annulen 2009-06-12 17:12:54 UTC
Dev300m50 deb build also has this bug
Comment 7 wolframgarten 2009-07-10 10:29:43 UTC
Reproducible now with the last description under linux, works under windows and
under linux in 3.0.1.
Comment 8 clippka 2009-07-22 10:39:58 UTC
Created attachment 63684 [details]
much simpler file showing the error with text
Comment 9 clippka 2009-07-22 10:42:50 UTC
cl->all: it helps fixing your issues if you try to simplify the problem. Why
must scare developer resources do the qa work?

Anyway, it has nothing to do with tables. I attached a much simpler document
that shows the error with a single image and a text shape. I took the text from
the bugdoc so looks like it only happens with special characters. If the image
is above or left of the text shape the text shape is selected if the image is
clicked.

cl->aw: looks to me like the hit test creates something that always extends to
0,0 in case of error
Comment 10 Armin Le Grand 2009-07-22 12:10:37 UTC
AW->CL: Cannot reproduce in DEV300 m52 (where CWS aw065 is integrated which
changes HitTest to primitive usage completely). I am not sure if i understood
what has to go wrong. When i click on the text, the text gets selected (+ in
edit mode). When i klick in the bitmap, the bitmap gets selected. I cannot get a
case where i click on the one and the other is selected.
Please take a look in DEV300 m52. If it does not happen there, it's another
proof of concept that the primitives make geometry handling more safe :-)
Comment 11 Armin Le Grand 2009-07-22 12:33:50 UTC
AW: When it is reproducible on Linux with a DEV300 m52 this could be a hint that
the text sizes with this string which i get from VCL maybe wrong. I will need a
linux version to check this...
Comment 12 Armin Le Grand 2009-07-28 10:30:27 UTC
AW: Task does not happen in OOO310 line (OOo 3.1.1) as written in Version field,
so 3.1.1 as target makes no sense. Setting back to 3.2.
Comment 13 annulen 2009-07-28 11:00:04 UTC
Bug remains in latest developer build
Comment 14 Armin Le Grand 2009-07-28 11:18:56 UTC
AW->annulen: Task is about DEV300 m50 where the task is reproducible. It's not
reproducible on OOO310 line. You Yourself wrote about DEV300 m50. WG checked
that in 3.1.1 all is okay.
Remember: This task is not about the crash anymore but the HitTest error. Thus,
also prio2 is not justified.
Adding WG to cc, setting back fields to last affirmed states until someone else
affirms.

AW->WG: Cannot reproduce under 3.1.1, also never was reproduced. annulen now
claims error to happen in OOO310 m14. Can You affirm that? Don not forget: Linux
only.
Comment 15 Armin Le Grand 2009-07-28 11:20:36 UTC
AW->WG: Oops, of course better check on newest (OOO310 m16)...
Comment 16 Armin Le Grand 2009-07-28 12:36:37 UTC
AW: Debugged so far (using printf's under linux, argh) that the problems are
caused by the last of 16 portions in that text. Indeed. activating text edit
shows there is a last character at the end of the text which seems to be a
space. When removing it, all works well.
Looking what extraordinary character that last char is...
Comment 17 Armin Le Grand 2009-07-28 13:55:17 UTC
AW: Think i got it; had to go down to TextLayouterDevice::getTextBoundRect.
There, it is possible (like in this case) to get an empty rectangle as result
from VCL what is correct. This has to be handled as empty B2DRange, too, what is
not yet the case. Checking and looking for usages...
Comment 18 Armin Le Grand 2009-07-28 14:53:44 UTC
AW: Secured implementation and usages. Tested on linux and win, works as
expected. The linux only must have to do with a different font; the char which
made problems was '50', so possibly this char gave some size in systems other
than linux.
Commited changes, done.
Comment 19 Joe Smith 2009-07-29 14:41:15 UTC
This problem affects textboxes in Writer and Calc as well (see Issue 103810 for
sample docs.

I don't know what it means, but if I open "simple.odp" in DEV300_m53, and edit
the textbox to remove the trailing space, leave the text editing mode, then
re-edit and type a space again at the end, the selection problem disappears
after that.

OTOH, a space at the _start_ of the text consistently causes the excess
selection area problem. A space at the start of any paragraph, or line after a
line break, is sufficient to cause the problem.

A similar (same?) problem can affect object labels: Issue 102802
Comment 20 Armin Le Grand 2009-07-29 15:18:05 UTC
AW->jes: The single char needs to have no graphical size in the font (e.g.
space; is empty) and needs to be in an own text portion -> needs to have a
different formatting than the text near it. Thus, to re-create, add a space,
select it and change style (e.g. make bold). That should do it. HTH!
Comment 21 Armin Le Grand 2009-07-29 16:09:03 UTC
*** Issue 103447 has been marked as a duplicate of this issue. ***
Comment 22 Armin Le Grand 2009-07-31 09:53:29 UTC
*** Issue 103810 has been marked as a duplicate of this issue. ***
Comment 23 annulen 2009-07-31 10:42:32 UTC
bug still exists in 310m17
Comment 24 wolframgarten 2009-07-31 10:57:12 UTC
Of course it does. This issue is part of CWS aw075, which is not integrated into
master yet or tested itself.
Comment 25 Armin Le Grand 2009-08-04 17:00:35 UTC
AW: Checked in test version (unxlngi6.pro and win32), okay.
Comment 26 Armin Le Grand 2009-08-06 13:46:36 UTC
AW->WG: Please review, best with CL's simple.odp.
Comment 27 wolframgarten 2009-08-10 11:20:40 UTC
Verified in CWS.
Comment 28 annulen 2009-08-15 20:25:06 UTC
why it is not fixed in 3.1.1? This bug definitely makes impossible to work with
many of my documents. Still using 3.0.1
Comment 29 wolframgarten 2009-08-17 07:28:43 UTC
Because there are bugs that are more important or affecting more users than this
one. Every issue is the most important one for somebody - but we cannot fix them
all in one build.
Comment 30 Joe Smith 2009-09-04 23:55:20 UTC
Testing DEV300_m57 on Linux (Fedora 11)

Problem is fixed: Test document works correctly; I can easily select either
object by rubber band. Also ok with document attached to my Issue 102802.

Thank you!
Comment 31 wolframgarten 2009-09-07 07:48:56 UTC
Closed.