Issue 103543 - Help Viewer, Contents page: Links don't show Help pages
Summary: Help Viewer, Contents page: Links don't show Help pages
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: viewing (show other issues)
Version: DEV300m52
Hardware: All All
: P2 Trivial (vote)
Target Milestone: ---
Assignee: ivo.hinkelmann
QA Contact: issues@sw
URL:
Keywords: oooqa, regression
: 104696 (view as issue list)
Depends on:
Blocks: 104695
  Show dependency tree
 
Reported: 2009-07-14 15:26 UTC by Uwe Fischer
Modified: 2013-08-07 14:44 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description Uwe Fischer 2009-07-14 15:26:27 UTC
Double-click on any link of the Contents tab page of Help Viewer do not show any
change of the Help page at the right side.
Tested on Solaris StarOffice 9.2 and Linux DEB OOo 3.2
Comment 1 Uwe Fischer 2009-07-15 09:11:15 UTC
Tested on Windows Xp DEV300m51: broken
On Windows Vista DEV300m47: works as supposed.
Comment 2 ab 2009-07-15 09:57:29 UTC
The Help Viewer does not belong to my area.

ab->mav: mba told me to send this issue to you
(pb used to care about the Help Viewer before)
Comment 3 Uwe Fischer 2009-07-21 13:02:42 UTC
A build of SO 9.2 CWS hcshared22 DEV300m52 on Linux does not show this issue.
All links on Contents tab page work as expected.
Comment 4 Uwe Fischer 2009-09-01 11:16:45 UTC
In a master DEV300m57 of OOo 3.2 on Ubuntu Linux, the Content tab page links of
the Help Viewer do not work.
Comment 5 kla 2009-09-04 08:55:32 UTC
*** Issue 104696 has been marked as a duplicate of this issue. ***
Comment 6 Mechtilde 2009-09-07 14:36:22 UTC
changing priority
Comment 7 Uwe Fischer 2009-09-16 09:50:40 UTC
In DEV300m59 on Win XP, still no working links on the Contents tab page of Help
Viewer
Comment 8 mikhail.voytenko 2009-09-18 11:23:23 UTC
.
Comment 9 mikhail.voytenko 2009-09-21 13:21:27 UTC
The problem is that there are no links at all. The help "Folders" in Content
page are just empty.
Comment 10 Uwe Fischer 2009-09-21 13:39:04 UTC
In cws hcshared23, I had to break the link from
hcshared23/DEV300/src.m57/helpcontent2.link 
that leads to 
hcshared23/DEV300/ooo/helpcontent2

I did that with cd to src.m57 folder, then entering the command:

mv helpcontent2.link helpcontent2

According to available information, this should break the link. But effectively,
it removed also the whole folder ooo/helpcontent2.
This was the first time I observed this funny behaviour. May be because it also
was the first time the linked folder had an extension of .link instead of .lnk,
as before?
Comment 11 mikhail.voytenko 2009-09-21 14:08:10 UTC
I do not think that the module link handle in cws can affect the master build (
sorry if I have misunderstood the last comment ).

The problem seems to be that the "*.tree" files do not contain any links,
everything is commented out. If I copy the "*.tree" file from the helpcontent2
cws, everything seems to work well. Interestingly, there was a big change
regarding translation handling, that has also affected the build of the "*.tree"
files.

mav->ihi: You have commited the change related to the translation. Could it
affect the files build in the way that they now contain no link? The special
thing about help is that it still uses "en" instead of "en-US" sometimes.
Comment 12 mikhail.voytenko 2009-09-21 14:22:17 UTC
By the way, by "link in Content page" I mean the leafs in the content tab-page
hierarchy ( shown on the left side ) in the Help Viewer.
Comment 13 Uwe Fischer 2009-09-21 14:28:33 UTC
The swriter.tree file, for example, is obviously not the source for all the
strings that show up in the Contents page of Help Viewer. See
http://www.openoffice.org/issues/show_bug.cgi?id=94512 where we changed a string
several versions ago, but still the old string is shown in Help Viewer.
Comment 14 mikhail.voytenko 2009-09-21 14:41:02 UTC
The swriter.tree is definitely the source for the links in the Content tab-page
( the links related to the writer of course ). Please just try to copy the file from
/so/ws/DEV300/src.m58/helpcontent2/source/auxiliary/swriter.tree
to
<DEV300_m58 installation>/opt/openoffice.org/basis3.2/help/en/swriter.tree

and the links related to the writer will appear and will work well. Just the
same is correct for other "*.tree" files.
Comment 15 Uwe Fischer 2009-09-21 14:56:26 UTC
The installed swriter.tree file has only comments, like in this sample:
		<node id="0208" title="Tables of Content and Indexes">
<!-- removed swriter/text/swriter/guide/chapter_numbering.xhp -->
<!-- removed swriter/text/swriter/guide/indices_userdef.xhp -->
<!-- removed swriter/text/swriter/guide/indices_toc.xhp -->
<!-- removed swriter/text/swriter/guide/indices_index.xhp -->
<!-- removed swriter/text/swriter/guide/indices_multidoc.xhp -->
<!-- removed swriter/text/swriter/guide/indices_literature.xhp -->
<!-- removed swriter/text/swriter/guide/indices_delete.xhp -->
<!-- removed swriter/text/swriter/guide/indices_edit.xhp -->
<!-- removed swriter/text/swriter/guide/indices_enter.xhp -->
<!-- removed swriter/text/swriter/guide/indices_form.xhp -->
		</node>

Here we see that at the time of building the contents database, the linked files
were not available. Therefore a mechanism removed the links and replaced them by
comments. This is desired behaviour, in case we delete a source xhp file, that
the Contents tab page doesn't try to link to that removed file.

So the non working links may well be a result of having moved the whole
ooo/helpcontent2 away from ooo and over to src.m57 folder, just before building?

And second, regarding the issue 94512 we see that wrong text "Tables of Content"
instead of "Tables of Contents" in the heading line. Where does that wrong line
come from?
Comment 16 frank.thomas.peters 2009-09-21 15:47:26 UTC
> So the non working links may well be a result of having moved the 
> whole ooo/helpcontent2 away from ooo and over to src.m57 folder, 
> just before building?

The *.tree files are updated by the helpcontent2/helpers/update_tree.pl script
that verifies that all files listed in the *.tree files exist, and removes the
non-existing entries. The source tree files are not touched.

I suspect that this is due to the fact that the ooo/helpcontent2 was moved to
src.m57/helpcontent2 instead of just renaming the symlink in src.m57.
The makefile in helpcontent2/source/auxiliary calls the script with 

$(COMMONMISC)$/treefiles.done : $(LOCTREEFILES)
	+$(PERL) $(PRJ)$/helpers$/update_tree.pl && $(TOUCH) $@

I don't know what $PRJ is set to at the time of the call.

Solution: Rerun the script on the existing tree files and make sure that the
path is correct this time, i.e. make sure that there is an ooo/helpcontent2 folder


Comment 17 ivo.hinkelmann 2009-09-21 16:01:39 UTC
I guess the problem is a broken update_tree.pl script and not if you are in a
hc.link or in a hc directory. If you are inside of the hc module everything is
locally ...

on the m57 master the german treefiles are ok, the en-US one is "striped" so it
seems something is broken with the script
Comment 18 mikhail.voytenko 2009-09-21 16:36:39 UTC
Interesting, it looks to be enough just to rebuild the helpcontent2 project. It
is indeed not important whether it is in src.m58 or ooo. I have rebuilt it from
scratch locally after using copyprj.

mav->ihi: It looks even not to be important whether WITH_LANG is set or not. I
have set it with
setenv WITH_LANG de
as you have suggested and the result swriter_en-US.zip contains the correct
swriter.tree file. May be somebody has already fixed the problem but the project
was not rebuilt from scratch after cws integration? Or the master build does
something additionally, so that the cws build looks good.
Comment 19 ivo.hinkelmann 2009-09-21 16:36:48 UTC
my issue!
Comment 20 ivo.hinkelmann 2009-09-21 17:51:57 UTC
fixed on m60 master. Can anymore verify?
Comment 21 Uwe Fischer 2009-09-22 08:51:12 UTC
Verified in DEV300m60 unxlngi6.pro version.
Comment 22 Mechtilde 2009-09-25 19:25:56 UTC
verified in DEV300_m60 -< closed