Issue 106214 - text alignment in tables
Summary: text alignment in tables
Status: CLOSED FIXED
Alias: None
Product: Draw
Classification: Application
Component: formatting (show other issues)
Version: DEV300m62
Hardware: PC (x86_64) Windows XP
: P3 Trivial (vote)
Target Milestone: OOo 3.2
Assignee: h.ilter
QA Contact: issues@graphics
URL:
Keywords: oooqa, regression
Depends on:
Blocks: 99999
  Show dependency tree
 
Reported: 2009-10-23 05:49 UTC by erni35
Modified: 2017-05-20 10:29 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
sample for incorrect alignment (10.71 KB, application/vnd.oasis.opendocument.graphics)
2009-10-23 05:50 UTC, erni35
no flags Details
Proposed fix (1.50 KB, text/plain)
2009-10-27 16:35 UTC, Armin Le Grand
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description erni35 2009-10-23 05:49:27 UTC
I create a drawing and inserted a table.
After inserting text I changed the alignment of them to center.
Jumping into the cell for editing, the text is centered. Leaving the cell the
text switches to left alingment.
I remember, this came first in after changing from DEV300m61 to DEV400m62.

Dietmar
Comment 1 erni35 2009-10-23 05:50:43 UTC
Created attachment 65552 [details]
sample for incorrect alignment
Comment 2 erni35 2009-10-23 05:51:26 UTC
Also exproting the document to pdf shows a incorrect text alignment in the table.
Comment 3 Rainer Bielefeld 2009-10-23 06:38:23 UTC
Reproducible with "Ooo-Dev 3.2.0 multilingual version German UI WIN XP:
[OOO320m2 (Build 9432)]"!
Works fine with "Ooo 3.1.0 WIN XP DE-multilingual version German UI activated
[OOO310m11 (Build 9399)]"

Related to Issue 105508?
Comment 4 Rainer Bielefeld 2009-10-23 06:41:39 UTC
.
Comment 5 wolframgarten 2009-10-23 08:01:19 UTC
Reproducible. Reassigned.
Comment 6 clippka 2009-10-26 13:35:48 UTC
cl->aw: another regression between text edit mode and display mode from m61 to
m62. In this case the text edit mode is correct. Text alignment in table cells
should honor the column width and not the text width like in text shapes.

I'm nominating this as a OOo 3.2 showstopper
Comment 7 Armin Le Grand 2009-10-27 16:18:33 UTC
AW: Taking a look. Central point for CellText layouting is
SdrTextObj::impDecomposeBlockTextPrimitive. Added to ooo32gsl03, prepared for
work, looking...
Comment 8 Armin Le Grand 2009-10-27 16:35:13 UTC
Created attachment 65685 [details]
Proposed fix
Comment 9 Armin Le Grand 2009-10-27 16:38:03 UTC
AW: Found. Need to set Min, Max and PaperSize at the Outliner to get the corrcet
layout. The MinPaperSize was missing.
Added, committed, added patch as attachment. Done.
Comment 10 erni35 2009-10-29 08:55:51 UTC
Great, many thanks.

Dietmar
Comment 11 Armin Le Grand 2009-11-05 14:41:03 UTC
AW: Checked in ooo32gsl03 build, works as expected.
AW->WG: Please verify.
Comment 12 wolframgarten 2009-11-09 14:00:23 UTC
Verified in CWS.
Comment 13 clippka 2009-11-19 16:09:53 UTC
cl->aw: this fix breaks the vertical alignment in tables

create a new table (2x2 f.e.), resize it larger, enter a short word in the first
cell, from context menu choose Cell/Center. In text edit mode the text is
correctly vertically centered. Leaving text edit mode the text swaps to the top.
Comment 14 clippka 2009-11-19 16:11:18 UTC
reassigned
Comment 15 Armin Le Grand 2009-11-19 16:56:21 UTC
AW: Took a look, indeed, it kills the vertical align. I have to admit that i was
not aware of vertical alignment in tables yet...
Already experimented and the prev fix to set SetMinAutoPaperSize to
aAnchorTextSize is too strong for Cell formatting. MinAutoPaperSize needs to be
set to zero (grow) in vertical (Y) for horizontal text (!bVerticalWritintg) and
vice versa (Yes, it's irritating, but this may be due to old EditEngine/Outliner).
Waiting for CWS ooo32gsl07 where i will handle this task...
Comment 16 Armin Le Grand 2009-11-20 10:39:06 UTC
AW: Adapted SdrTextObj::impDecomposeBlockTextPrimitive accordingly; the
MinAutoPaperSize is now set only for the relevant parts. Checked, works as expected.
Commited, done.
Comment 17 Armin Le Grand 2009-11-23 15:34:46 UTC
AW: Checked unxlngi6.pro version, works as expected.
AW->HI: Please verify in CWS. Simplest way: Impress, instert table (2x2), make
big (nearly as the page), klick in top-left area, type a word. Klick on
'centered' in the text toolbar, click on 'Cebter (vertical)' in the table
toolbar -> word is now centered in X and Y. Klick out of table -> it stays
centered. Without the fix, it loses vertical center when TextEdit is deactivated.
Comment 18 h.ilter 2009-11-30 10:48:48 UTC
Verified with cws ooo32gsl07 = ok