Issue 11000 - OOO_STABLE_1_PORTS/X11+Aqua: improved link stage patch for dylib discovery
Summary: OOO_STABLE_1_PORTS/X11+Aqua: improved link stage patch for dylib discovery
Status: CLOSED FIXED
Alias: None
Product: porting
Classification: Code
Component: code (show other issues)
Version: OOo 1.0.1
Hardware: Mac Mac OS X, all
: P3 Trivial (vote)
Target Milestone: OOo 1.0.4
Assignee: fa
QA Contact: issues@porting
URL:
Keywords: merge_pending
Depends on:
Blocks:
 
Reported: 2003-01-28 01:44 UTC by fa
Modified: 2007-02-05 03:32 UTC (History)
3 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
cd SRC_ROOT/solenv, patch -p0 /path/to/patchfile Adds support for selective library addition to link line (40.66 KB, patch)
2003-01-29 01:52 UTC, fa 		no flags Details | Diff
put in solenv/unxmacxp/bin (5.44 KB, patch)
2003-01-29 01:54 UTC, fa 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description fa 2003-01-28 01:44:53 UTC 
Currently, to satisfy ld's requirement of locating libraries with both @executable_path:/lib and -llib, we simply add every dylib that exists in solver/641/unxmacxp.pro/lib to the link line of every dylib and every app.  This makes for _very_ long link commands and can sometimes overrun the argument length limit of the system (because g++ is actually a script that passes arguments through to libtool which passes them on to ld).

This patch find every dylib specified with the -l<libname> and every library that those -l<libname> libraries depend on, and add ONLY those libraries to the link line if they exist in solver/641/unxmacxp.pro/lib.

It also supresses warnings about multiply defined symbols, which caused huge amounts of output during the link stage of the static data member libraries.

Dan
Comment 1 fa 2003-01-29 01:52:43 UTC 
Created attachment 4474 [details]
cd SRC_ROOT/solenv, patch -p0 /path/to/patchfile   Adds support for selective library addition to link line
Comment 2 fa 2003-01-29 01:54:01 UTC 
Created attachment 4475 [details]
put in solenv/unxmacxp/bin
Comment 3 fa 2003-01-29 04:20:41 UTC 
Building with these two patches builds and links correctly.  Please approve for commit
to OOO_STABLE_1_PORTS.

Dan
Comment 4 sander_traveling 2003-01-30 16:07:56 UTC 
approved, as MacOSX specific
Comment 5 fa 2003-01-31 01:45:29 UTC 
Committed to OOO_STABLE_1_PORTS.  Marked merge_pending.  Please merge to OOO_STABLE_1 and also to HEAD and 644 and whatever else.

Can someone also take solenv/unxmacxp/bin/dylib-link-list out of the Attic?

Thanks,
Dan
Comment 6 fa 2003-08-04 05:44:03 UTC 
Fixed in 103 GM and 1.1
Comment 7 jjmckenzie 2007-02-05 03:32:35 UTC 
Closing issue.  Branch closed to further updates.

James McKenzie