Issue 110655 - Display of block selection mode is broken
Summary: Display of block selection mode is broken
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: editing (show other issues)
Version: DEV300m75
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: eric.savary
QA Contact: issues@sw
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2010-04-06 20:28 UTC by Joe Smith
Modified: 2017-05-20 11:41 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Joe Smith 2010-04-06 20:28:00 UTC 
I just happened to note that block selection is not working properly in the
latest snapshot.

1) File > New > Text Document
2) dt,F3 (insert dummy text autotext)
3) Edit > Selection Mode > Block Area: YES (checked)
4) Click in the top line and drag toward the lower right: the visible selection
does not follow the mouse cursor position; it seems to be offset.

The visible selection does accurately show what is selected, it just doesn't
follow the mouse cursor as I drag it.

The block selection does seem to work if I start at the right and drag toward
the left.

Block area selection works properly for me in OOo 3.2.0 on the same system.
Comment 1 Joe Smith 2010-04-06 20:33:22 UTC 
Oops: I'm running DEV300_m75 on Fedora Linux 11.

OS set to Linux--I'm guessing this is system-specific.
Comment 2 eric.savary 2010-04-06 21:14:28 UTC 
@jes: Good catch! Thank you! :)
Reproducible on Vista too. Reset OS to All.

@MBA: Regression in DEV300 (tested m75) only.

The displayed selection in block selection mode doesn't follow the mouse pointer
when dragging from left to right.

It's hard to explain but let's say that if you drag the mouse in the dummy text
following a north-west to south-east direction, the selection will expand
correctly to the right but will stay in the first 2-3 lines of text collapsing
and expanding as if the Y coordinate of the selection was following a sinusoidal
function...

Sometimes dragging doesn't create any selection.

But the selection NEVER follows the pointer.

OD/OS: one of your playgrounds?
Comment 3 Oliver-Rainer Wittmann 2010-04-07 12:42:42 UTC 
Functionality seems to be broken in DEV300m66 - DEV300m65 works fine.

od->mst: It seems that the changes from cws sw33bf01 causes this defect. Thus,
please take over.
Comment 4 mst.ooo 2010-04-07 13:09:50 UTC 
found the root cause: a change to SwRect::Justify() from the patch in i106401
(X was changed into Y)
Comment 5 mst.ooo 2010-04-19 17:46:38 UTC 
fixed in cws sw33bf03
http://hg.services.openoffice.org/hg/cws/sw33bf03/rev/1674dc534d3d
Comment 6 eric.savary 2010-04-29 16:27:38 UTC 
Reassigned to ES
Comment 7 eric.savary 2010-04-29 16:29:10 UTC 
Verified in CWS sw33bf03
Comment 8 Joe Smith 2010-05-29 20:13:07 UTC 
The hg pages seem to say that the fix was merged in DEV300_m77, but I don't see
the fix in the latest OOo-Dev snapshot (DEV300_m78).

Hopefully I'm just reading it wrong and the fix is on track to be integrated
with the new branch.
Comment 9 Oliver-Rainer Wittmann 2010-06-04 16:45:37 UTC 
od->jes: cws sw33bf03 which contains the fix for this issue has been integrated
into DEV300m79. Thus, please check again in DEV300m79 or even DEV300m80
Comment 10 Joe Smith 2010-06-04 16:57:03 UTC 
Testing OOo-dev 3.3  300m80(Build:9507) in Fedora Linux 13:

Looks good: block selection works correctly.

Thanks!