Issue 110691 - text:id and xml:id at <text:changed-region> and <draw:text-box>
Summary: text:id and xml:id at <text:changed-region> and <draw:text-box>
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: save-export (show other issues)
Version: OOo 3.2
Hardware: All All
: P2 Trivial (vote)
Target Milestone: ---
Assignee: Oliver-Rainer Wittmann
QA Contact: issues@sw
URL:
Keywords: odf_validation
Depends on:
Blocks:
 
Reported: 2010-04-08 10:13 UTC by Oliver-Rainer Wittmann
Modified: 2017-05-20 11:41 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
text document with text:id, form:id (8.83 KB, application/vnd.oasis.opendocument.text)
2010-04-19 15:50 UTC, mst.ooo
no flags Details
presentation document with anim:id, draw:id, form:id, text:id (12.73 KB, application/vnd.oasis.opendocument.presentation)
2010-04-19 15:51 UTC, mst.ooo
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description Oliver-Rainer Wittmann 2010-04-08 10:13:39 UTC
Adjust handling of text:id and xml:id for <text:changed-region> and
<draw:text-box> according ODF 1.2 part 1 cd04 in ODF import and export.
Comment 1 Oliver-Rainer Wittmann 2010-04-08 10:29:51 UTC
setting keyword
Comment 2 mst.ooo 2010-04-14 14:25:49 UTC
seems there are even more problems:  text:id/xml:id on text:p/text:h
Comment 3 mst.ooo 2010-04-14 15:14:45 UTC
it's even worse than that; the interaction with xml:id affects these attributes,
on various elements (but not on all where they may occur):
text:id draw:id anim:id form:id

only table:id seems to be unaffected.
Comment 4 mst.ooo 2010-04-19 15:48:50 UTC
anim:id

<anim:audio> <anim:command> <anim:iterate> <anim:par> <anim:seq>
anim:id(ID) => anim:id(NCName), xml:id(ID)
xmloff/source/draw/animationexport.cxx


draw:id

<draw:glue-point>
draw:id(nonNegativeInteger) => draw:id(nonNegativeInteger), xml:id(ID)
THIS IS INCONSISTENT:
the lexical spaces of nonNegativeInteger and ID are mutually exclusive!
it seems this is an error in the specification.
filed issue OFFICE-2637 at OASIS.

<dr3d:cube> <dr3d:extrude> <dr3d:rotate> <dr3d:scene> <dr3d:sphere>
<draw:caption> <draw:circle> <draw:connector> <draw:control> <draw:custom-shape>
<draw:ellipse> <draw:frame> <draw:g> <draw:line> <draw:measure> <draw:page>
<draw:page-thumbnail> <draw:path> <draw:polygon> <draw:polyline> <draw:rect>
<draw:regular-polygon> <office:annotation>
draw:id(ID) => draw:id(NCName), xml:id(ID)
mloff/source/draw/sdxmlexp.cxx      <draw:page>
xmloff/source/draw/shapeexport.cxx  all the rest
    except for <draw:regular-polygon> which we apparently do not implement


form:id

<form:button> <form:checkbox> <form:combobox> <form:date> <form:file>
<form:fixed-text> <form:formatted-text> <form:frame> <form:generic-control>
<form:grid> <form:hidden> <form:image> <form:image-frame> <form:listbox>
<form:number> <form:password> <form:radio> <form:text> <form:textarea>
<form:time> <form:value-range>
form:id(ID) => form:id(NCName), xml:id(ID)
xmloff/source/forms/elementexport.cxx


text:id

<draw:text-box>
text:id(string) => text:id(NCName), xml:id(ID)
we don't seem to support id here at all

<text:changed-region>
text:id(ID) => text:id(NCName), xml:id(ID)
xmloff/source/text/XMLRedlineExport.cxx

<text:h> <text:p>
text:id(string) => text:id(NCName), xml:id(ID)
xmloff/source/chart/SchXMLExport.cxx
xmloff/source/text/txtparae.cxx

<text:alphabetical-index-mark-end> <text:alphabetical-index-mark-start>
<text:note> <text:toc-mark-end> <text:toc-mark-start> <text:user-index-mark-end>
<text:user-index-mark-start>
unchanged (string)


table:id

unchanged (string)
Comment 5 mst.ooo 2010-04-19 15:50:18 UTC
Created attachment 68990 [details]
text document with text:id, form:id
Comment 6 mst.ooo 2010-04-19 15:51:23 UTC
Created attachment 68991 [details]
presentation document with anim:id, draw:id, form:id, text:id
Comment 7 mst.ooo 2010-04-19 17:49:39 UTC
fixed in cws sw33bf03
http://hg.services.openoffice.org/hg/cws/sw33bf03/rev/915b9e7905b2
Comment 8 eric.savary 2010-04-29 14:29:01 UTC
@OD: please verify.
Comment 9 Oliver-Rainer Wittmann 2010-05-03 12:23:18 UTC
verified in CWS sw33bf03