Issue 11327 - OOO_STABLE_1_PORTS: Problem in bridges with updated solenv
Summary: OOO_STABLE_1_PORTS: Problem in bridges with updated solenv
Status: CLOSED FIXED
Alias: None
Product: porting
Classification: Code
Component: code (show other issues)
Version: OOo 1.0.1
Hardware: Mac Mac OS X, all
: P3 Trivial (vote)
Target Milestone: OOo 1.0.4
Assignee: fa
QA Contact: issues@porting
URL:
Keywords: merge_pending
Depends on:
Blocks:
 
Reported: 2003-02-09 14:58 UTC by sdietrich
Modified: 2007-02-05 03:41 UTC (History)
3 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
cd SRC_ROOT/solenv/unxmacxp/bin; patch -p0 dylib-link-list solenv.linklist.OOO_STABLE_1_PORTS.020903.patch (1.96 KB, patch)
2003-02-09 14:59 UTC, sdietrich
no flags Details | Diff
cd SRC_ROOT/config_office; patch -p0 < config_office.soenv.OOO_STABLE_1_PORTS.020903.patch (1.70 KB, patch)
2003-02-09 15:01 UTC, sdietrich
no flags Details | Diff
cd SRC_ROOT/solenv; patch -p0 < solenv.unxmacxp.mk.OOO_STABLE_1_PORTS.020903.patch (635 bytes, patch)
2003-02-09 15:02 UTC, sdietrich
no flags Details | Diff
cd SRC_ROOT/config_office; patch -p0 < config_office.soenv.OOO_STABLE_1_PORTS.021303.patch (1.95 KB, patch)
2003-02-14 01:56 UTC, sdietrich
no flags Details | Diff
Apply the pathch by executing the following commands: cd $SRC_ROOT/solenv ; patch -p0 < /path/to/patch/file (1.15 KB, patch)
2003-04-14 15:48 UTC, pluby
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description sdietrich 2003-02-09 14:58:44 UTC
Building fails in bridges (undefined symbols) when using the dylib-link-list script. The attached patches fix this problem, remove non-existent directory from link commands, and suppresses long-double warnings when building.
Comment 1 sdietrich 2003-02-09 14:59:42 UTC
Created attachment 4620 [details]
cd SRC_ROOT/solenv/unxmacxp/bin; patch -p0 dylib-link-list solenv.linklist.OOO_STABLE_1_PORTS.020903.patch
Comment 2 sdietrich 2003-02-09 15:01:22 UTC
Created attachment 4621 [details]
cd SRC_ROOT/config_office; patch -p0 < config_office.soenv.OOO_STABLE_1_PORTS.020903.patch
Comment 3 sdietrich 2003-02-09 15:02:39 UTC
Created attachment 4622 [details]
cd SRC_ROOT/solenv; patch -p0 < solenv.unxmacxp.mk.OOO_STABLE_1_PORTS.020903.patch
Comment 4 fa 2003-02-10 05:26:08 UTC
solenv.unxmacxp.mk patch has been approved by me and committed.

I'd like to get someone else to look over the config_office patch just to make sure, and I believe the linklist patch will be fine too, but we should probably do a full build with it just to make sure.

dAn
Comment 5 foskey 2003-02-10 07:27:58 UTC
set_sonev.1 is no longer in use on PORTING so this patch will not have
any effect.  PLease review whether this is required for set_soenv.in
and resubmit.
Comment 6 sdietrich 2003-02-14 01:46:16 UTC
Yes, set_soenv.in also needs patch. This patch supercedes config_office.soenv.OOO_STABLE_1_PORTS.020903.patch.
Comment 7 sdietrich 2003-02-14 01:56:45 UTC
Created attachment 4721 [details]
cd SRC_ROOT/config_office; patch -p0 < config_office.soenv.OOO_STABLE_1_PORTS.021303.patch
Comment 8 foskey 2003-02-14 12:57:35 UTC
Committed to porting and to baseline 644 config_office.
Comment 9 fa 2003-02-17 01:57:38 UTC
The following patches were committed to _PORTS:

solenv.linklist.OOO_STABLE_1_PORTS.020903.patch
config_office.soenv.OOO_STABLE_1_PORTS.021303.patch

Dan
Comment 10 foskey 2003-02-17 04:44:39 UTC
set_soenv.in merged with 644 already.  solenv patches require merging. 
Comment 11 pluby 2003-04-13 01:21:02 UTC
The committed patch to solenv/inc/unxmacp.mk and config_office does
not work on Mac OS X 10.1. The patch replaced all references to "cc"
with "gcc" and "g++". Since "gcc" and "g++" do not exist on Mac OS X
10.1, this patch should either be reversed or simple "gcc" and "g++"
wrapper scripts that exec "cc" should be added to the
solenv/unxmacxp/bin directory like the following:

#!/bin/sh

exec /usr/bin/cc "${@}"

If you use the wrapper approach, be sure to chmod them 755 before you
cvs add and commit them.
 
Comment 12 foskey 2003-04-13 03:57:46 UTC
You should be able to work around this limitation by this:

CC=/path/to/cc CXX=/path/to/c++ ./configure

This will create two variables in the .set file with CC=??? and CXX=???

In your settigns file you then use CC*=gcc & CXX*=g++.  This is a
default and the environment variables will override it.

Let me know what happens and I can start working on this.
Comment 13 pluby 2003-04-13 15:42:39 UTC
Ken,

Your suggestion will work for the configure script. However, Scott's
patch to the solenv/inc/unxmacxp.mk file hardcoded the following macros:

CC=g++
LINK=g++

Apparently, there is some need to set CC to a specific executable. So,
even if you properly override CC, any CC set by the configure script
will always get overridden by the above hardcoding.

One possible solution to this would be to change the above hardcoded
macros to the following:

CC=c++
LINK=c++

Since c++ is a softlink to the same executable as g++ on Mac OS X
10.2, this should have the same effect that the original patch had
without breaking Mac OS X 10.1.
Comment 14 pluby 2003-04-14 15:35:30 UTC
Reassigning reopened issue to Dan since he committed the last patch.
Comment 15 pluby 2003-04-14 15:48:22 UTC
Created attachment 5655 [details]
Apply the pathch by executing the following commands: cd $SRC_ROOT/solenv ; patch -p0 < /path/to/patch/file
Comment 16 fa 2003-04-15 22:52:58 UTC
solenv.patch approved and committed to PORTS by me.

dan
Comment 17 Martin Hollmichel 2003-04-29 14:54:17 UTC
retarget
Comment 18 fa 2003-08-04 05:45:03 UTC
Fixed in 103 GM.
Comment 19 jjmckenzie 2007-02-05 03:41:39 UTC
Closing.  Branch cannot be updated and is no longer maintained.

James McKenzie