Issue 113563 - build for system-graphite breaks in graphite_layout.cxx
Summary: build for system-graphite breaks in graphite_layout.cxx
Status: CLOSED FIXED
Alias: None
Product: gsl
Classification: Code
Component: code (show other issues)
Version: OOO330m1
Hardware: All Linux, all
: P3 Trivial (vote)
Target Milestone: OOo 3.3
Assignee: hdu@apache.org
QA Contact: issues@gsl
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2010-07-31 19:41 UTC by andyrtr
Modified: 2010-09-07 11:57 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
like so (517 bytes, patch)
2010-07-31 20:08 UTC, caolanm 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description andyrtr 2010-07-31 19:41:19 UTC 
While x86_64 compiled fine it fails since OOO330_m2 for my i686 builds with
EXTRAOPTS="--with-stlport --without-system-cppunit":

/tmp/openoffice-base-beta/trunk/src/OOO330_m2/vcl/source/glyphs/graphite_layout.cxx:
In member function 'sal_Int32 GrFontHasher::hashCode(const
grutils::GrFeatureParser*)':
/tmp/openoffice-base-beta/trunk/src/OOO330_m2/vcl/source/glyphs/graphite_layout.cxx:640:46:
error: no matching function for call to
'GrFontHasher::UniqueCacheInfo(std::wstring&, bool&, bool&)'
/tmp/openoffice-base-beta/trunk/src/OOO330_m2/vcl/source/glyphs/graphite_layout.cxx:662:18:
note: candidate is: virtual void GrFontHasher::UniqueCacheInfo(_STL::wstring&,
bool&, bool&)
/tmp/openoffice-base-beta/trunk/src/OOO330_m2/vcl/source/glyphs/graphite_layout.cxx:
In member function 'virtual void GrFontHasher::UniqueCacheInfo(_STL::wstring&,
bool&, bool&)':
/tmp/openoffice-base-beta/trunk/src/OOO330_m2/vcl/source/glyphs/graphite_layout.cxx:668:95:
error: no matching function for call to
'GraphiteFontAdaptor::UniqueCacheInfo(_STL::wstring&, bool&, bool&)'
../../inc/vcl/graphite_adaptors.hxx:122:18: note: candidate is: virtual void
GraphiteFontAdaptor::UniqueCacheInfo(std::wstring&, bool&, bool&)

gcc 4.5, ArchLinux. Probably introduced by graphite03_OOO330.
Comment 1 rene 2010-07-31 20:01:52 UTC 
I think the fixes which were done to make system-graphite work on STLport archs
were not adapted in this cws?
Comment 2 caolanm 2010-07-31 20:08:12 UTC 
Created attachment 70906 [details]
like so
Comment 3 caolanm 2010-07-31 20:09:13 UTC 
If we're ok with a 3.4 target for this feel free to assign it to me and I'll
take care of it.
Comment 4 rene 2010-07-31 20:19:16 UTC 
my personal feeling is that it should be fixed for 3.3, as it was broken in the
3.3 release branch...
Comment 5 andyrtr 2010-07-31 20:44:17 UTC 
The patch seems to fix it. My build is still running but has already passed that
point. It should be safe for 3.3 branch I think.
Comment 6 hdu@apache.org 2010-08-02 08:01:29 UTC 
Thanks for the patch! Applied in CWS graphite04.
Comment 7 hdu@apache.org 2010-08-02 08:09:07 UTC 
@cmc: please verify in CWS graphite04
http://hg.services.openoffice.org/cws/graphite04/rev/d529e58baeb8
Comment 8 philipp.lohmann 2010-08-04 12:21:56 UTC 
verified in CWS graphite04
Comment 9 hdu@apache.org 2010-09-07 11:57:43 UTC 
Got into OOO330_m5 => closing