Issue 113914 - Get rid of duplicate library containers in sfx2
Summary: Get rid of duplicate library containers in sfx2
Status: CONFIRMED
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: DEV300m84
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-16 14:41 UTC by mikhail.voytenko
Modified: 2017-05-20 10:55 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description mikhail.voytenko 2010-08-16 14:41:04 UTC 
For any reason a duplicate library container was introduced in sfx2 code.

Actually the SfxBasicManagerHolder class contains already such containers and
the sfx2 implementation is aware of them and handles them correctly. The
duplicate implementation is partially not known to sfx2 and actually makes no
sense at all, and thus should be removed. The only difference is that the
duplication implementation can be created without basic manager, if it is
necessary, the SfxBasicManagerHolder can be easily adjusted to do it as well.

mav->fs: Please correct me if I have misunderstood something and the duplicate
library containers are really necessary.
Comment 1 Oliver Brinzing 2010-08-16 15:38:27 UTC 
.
Comment 2 Frank Schönheit 2010-08-16 21:13:32 UTC 
@mav: if you provide me more details on which "duplicate library containers"
exactly you refer to, I would probably have an opinion on the matter :)
Comment 3 mikhail.voytenko 2010-08-17 08:53:01 UTC 
mav->fs: Sorry, I thought that it is enough to mention SfxBasicManagerHolder.
SfxObjectShell_Impl::xBasicLibraries and SfxObjectShell_Impl::xDialogLibraries
duplicate the entries in SfxObjectShell_Impl::pBasicManager ( pointer to
SfxBasicManagerHolder ).
Comment 4 Frank Schönheit 2010-08-17 11:40:03 UTC 
fs->mav: ahh ... no, I don't really see a reason why those extra x*Libraries are
needed.
Comment 5 Martin Hollmichel 2011-03-15 21:03:00 UTC 
set target to 3.x since not release relevant for 3.4 release.
Comment 6 Marcus 2017-05-20 10:55:19 UTC 
Reset assigne to the default "issues@openoffice.apache.org".