Apache OpenOffice (AOO) Bugzilla – Issue 114162
ODF : attribute "config:type" has a bad value.
Last modified: 2017-05-20 10:22:46 UTC
The attached odt file does not contains text but styles. It is a file which has been saved by several versions of OOo and from which I removed all the text. ODF validator find this file not valid ODF with errors in settings.xml Kind regards. JBF
Created attachment 71440 [details] not valid ODF file
MRU->OS / OD: the config-items "PreviewPrintNumRows"and "PreviewPrintNumColumns" in the settings.xml have wrong config-type "byte". I do not where these config-items are geerated - maybe a relict from older times?
At looks as if the preview print options are not in use anymore. ->tl: With printerpullpages there is no special setting of page preview print settings available anymore. Was that intended?
Removing the 'Print Options' from the print preview was done voluntarily by printerpullpages. Thus for getting rid of the still existing old code I have created issue 114267 now. tl->mst: About the 'byte' thing can you have a look at this? Thanks! Setting target to 3.4 since we like to know early if everything is right here.
the ODF schema indeed allows "short", "int", and "long", but not "byte". (i'd guess the omission was an accident, maybe at the time there weren't any "byte" items, so nobody noticed.) because "byte" is already not allowed in ODF 1.1 i guess we'll have to do something about it. easiest thing would be to store these as "short" instead. looking at the import code (xmloff/source/core/DocumentSettingsContext.cxx) this would mean that on import an any with sal_Int16 instead of sal_Int8 would be produced for such items. would this cause any problems for the configuration? would the configuration manager convert these back to sal_Int8? or does the type not really matter?
->mst: As the values PreviewPrintNumRows and PreviewPrintNumColumns are going to be removed there is no 'byte' value anymore at the API. If at any time byte values are re-introduced then the xmloff code should assert and not write them to the file.
i agree with os' suggestion to disable the storing of "byte" config items altogether. @nn, cl: i'm assuming that Calc/Impress also don't store config-items of type "byte" in settings.xml currently. unless one of you objects i'm going to disable storing them.
replaced the code that writes "byte" config-items with an assertion. fixed in cws sw34bf01 http://hg.services.openoffice.org/hg/cws/sw34bf01/rev/b051d2edc3de
adding keyword
please verify
verified