Issue 117013 - Firststartwizard cannot be disabled by shared extension with configuration settings
Summary: Firststartwizard cannot be disabled by shared extension with configuration se...
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: OOo 3.3
Hardware: All All
: P3 Trivial (vote)
Target Milestone: 3.4.0
Assignee: Olaf Felka
QA Contact: issues@framework
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2011-02-18 13:12 UTC by carsten.driesner
Modified: 2017-05-20 10:30 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Test extension to verify the fix. Works only with the current CWS fwk167 build! (1.75 KB, application/zip)
2011-03-23 13:51 UTC, carsten.driesner 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description carsten.driesner 2011-02-18 13:12:01 UTC 
Due to a side-effect in the startup and deployment code an extension installed
in the shared layer is not able to disable the first start wizard for the first
startup.
Comment 1 carsten.driesner 2011-02-18 13:13:57 UTC 
cd: Set kso on CC. Accepted issue.
Comment 2 carsten.driesner 2011-02-25 11:13:14 UTC 
cd: Fixed. The fix moves the code which evaluates the restart flag up. We can now check it before calling the first start wizard. If we want to restart it makes no sense to show the first start wizard.

cd->mav: We already did a code review. Please approve my changes.
Comment 3 mikhail.voytenko 2011-02-28 09:41:45 UTC 
The fix is reviewed and looks good.
Comment 4 carsten.driesner 2011-03-23 13:51:46 UTC 
Created attachment 76174 [details]
Test extension to verify the fix. Works only with the current CWS fwk167 build!
Comment 5 carsten.driesner 2011-03-23 14:37:29 UTC 
cd->of: Please verify or send it to a QA engineer. You have to install the extension via
unopkg add --shared <path to the extension>
The unopkg executable is located besides the soffice application.
Comment 6 Olaf Felka 2011-03-24 14:25:20 UTC 
of: Looks good for me in cws fwk167.