Issue 117189 - All Math objects in Writer document are loaded when reformatting
Summary: All Math objects in Writer document are loaded when reformatting
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: formatting (show other issues)
Version: DEV300m101
Hardware: All All
: P3 Normal (vote)
Target Milestone: ---
Assignee: Oliver Specht
QA Contact: issues@sw
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2011-03-03 12:10 UTC by niklas.nebel
Modified: 2013-08-07 14:44 UTC (History)
6 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description niklas.nebel 2011-03-03 12:10:52 UTC 
Load the OpenFormula specification (http://docs.oasis-open.org/office/v1.2/csprd03/OpenDocument-v1.2-csprd03-part2.odt) and select "Tools/Update/Page Formatting". This takes about 2 seconds in 3.3, more than a minute in DEV300m101 (on Windows 7 64 bit), because all Math objects are loaded.

Apparently this was changed in CWS tlmath01, where in SwWrtShell::CalcAndSetScale the objects are loaded if the flag embed::EmbedMisc::EMBED_NEVERRESIZE is set.
Comment 1 Oliver Specht 2011-03-03 12:19:17 UTC 
->mav: This seems to be a good reason to store size and printer settings at the container ;-)
Comment 2 Mathias_Bauer 2011-03-25 10:04:40 UTC 
The concept for Math baseline alignment (CWS tlmath01) did not require this; the alignment at the baseline is calculated once and then stored as offset in a "from top" alignment. This offset is valid until either the baseline of the formula or the baseline of the text that embeds the formula changes. In this case the object needs to be loaded.

SwWrtShell::CalcAndSetScale is the wrong place for this. We have to do the recalcuation exactly when base line changes appear.
Comment 3 Oliver-Rainer Wittmann 2011-03-31 11:47:58 UTC 
fixed in cws sw34bf06 - changed files:
/sw/source/core/layout/frmtool.cxx,
/sw/source/ui/wrtsh/wrtsh1.cxx,
/sw/source/ui/inc/wrtsh.hxx,
/sw/inc/fesh.hxx,
change set http://hg.services.openoffice.org/cws/sw34bf06/rev/9b8527da302b
Comment 4 Oliver-Rainer Wittmann 2011-03-31 11:51:34 UTC 
od->os: Please review the fix and take over further issue handling.
Comment 5 Oliver-Rainer Wittmann 2012-06-13 12:26:08 UTC 
getting rid of value "enhancement" for field "severity".
For enhancement the field "issue type" shall be used.
Comment 6 binguo 2012-06-19 08:54:39 UTC 
Verified it on Aoo_Trunk_20120616.1800.1350879 and it does not reproduce, so close it as fixed.