Issue 117735 - Automatic detection of HTML/CSV files with extension XLS is broken
Summary: Automatic detection of HTML/CSV files with extension XLS is broken
Status: CLOSED FIXED
Alias: None
Product: Calc
Classification: Application
Component: open-import (show other issues)
Version: DEV300m106
Hardware: All All
: P3 Normal (vote)
Target Milestone: 3.4.0
Assignee: oc
QA Contact: issues@sc
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2011-04-06 12:51 UTC by niklas.nebel
Modified: 2017-05-20 10:31 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description niklas.nebel 2011-04-06 12:51:24 UTC 
In 3.3, a file that has the extension ".XLS" and contains HTML or plain text is loaded with the WebQuery or CSV filter if no filter is selected manually (issue 89332).

This is broken since DEV300m97, where the XLS filter configuration was changed to use oox.xls.BiffDetector instead of calc.FormatDetector.
Comment 1 daniel.rentz 2011-04-07 10:50:40 UTC 
patch reviewed.
Comment 2 niklas.nebel 2011-04-07 10:57:08 UTC 
Fixed in CWS calc67.

With the change to BiffDetector (and thus, in 3.4 alpha and probably beta), Excel 2003 XML files with extension XLS were loaded automatically, because the XML filter was the first where filter detection accepts the file (similar to the old behavior with CSV files).

Even if this just happened to work, I don't want to break it between 3.4 beta and final, so the Calc FormatDetector service for XLS now handles Excel 2003 XML along with HTML and CSV, and this should always work.
Comment 3 niklas.nebel 2011-04-07 12:08:03 UTC 
reassigning to QA for verification
Comment 4 oc 2011-04-12 13:11:51 UTC 
verified in internal build cws_calc67
Comment 5 Oliver-Rainer Wittmann 2012-06-13 12:28:21 UTC 
getting rid of value "enhancement" for field "severity".
For enhancement the field "issue type" shall be used.