Issue 11794 - OOO_STABLE_1_PORTS/X11+Aqua: tools needs to get system language from sal
Summary: OOO_STABLE_1_PORTS/X11+Aqua: tools needs to get system language from sal
Status: CLOSED FIXED
Alias: None
Product: porting
Classification: Code
Component: code (show other issues)
Version: OOo 1.0.1
Hardware: Mac Mac OS X, all
: P3 Trivial (vote)
Target Milestone: OOo 1.0.4
Assignee: fa
QA Contact: issues@porting
URL:
Keywords: merge_pending
Depends on:
Blocks:
 
Reported: 2003-02-24 18:41 UTC by fa
Modified: 2007-02-05 03:57 UTC (History)
3 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
cd SRC_ROOT/tools, patch -p0 < /path/to/patchfile Makes tools use osl_getProcessLocale() to return system langauge rather than LANG (1.59 KB, patch)
2003-02-24 18:44 UTC, fa 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description fa 2003-02-24 18:41:35 UTC 
Currently, tools' GetSystemLanguage() function (tools/source/intntl/intnunx.cxx) gets the
language from LANG, however on Mac OS X, this is incorrect behavior.  The attached patch allows
tools to call osl_getProcessLocale() for Mac OS X which should allow the correct language to be
returned.

Dan
Comment 1 fa 2003-02-24 18:44:48 UTC 
Created attachment 4879 [details]
cd SRC_ROOT/tools, patch -p0 < /path/to/patchfile  Makes tools use osl_getProcessLocale() to return system langauge rather than LANG
Comment 2 fa 2003-02-24 18:45:12 UTC 
Please approve for commit to PORTS.
Comment 3 khendricks 2003-02-24 18:51:44 UTC 
Hi, 
 
Patch is completely MacOSX specific and thus approved. 
 
Kevin
Comment 4 chris 2003-02-26 10:45:51 UTC 
I'm wondering why this needs to be conditional for Mac and can't be
used for all arches?  Does osl_getProcessLocale ever do a worse job
than GetLangFromEnvironment?

I would only go for an #ifdefed version if an unconditional patch is
not possible, because the #ifdef'd code path is never tested by
developers working on other architectures and places an additional
burden on the port maintainers.

Would it be possible to replace the existing function
GetLangFromEnvironment with the osl_getProcessLocale implementation by
Dan?
Comment 5 fa 2003-03-25 02:22:49 UTC 
Martin,

Can you comment on making this change for all platforms?

Dan
Comment 6 Martin Hollmichel 2003-03-25 10:16:22 UTC 
approved.
Comment 7 fa 2003-08-04 05:45:37 UTC 
Fixed in 103 GM and 1.1
Comment 8 jjmckenzie 2007-02-05 03:57:08 UTC 
Closing issue.

James McKenzie