Issue 122288 - Automatic mnemonic generation in the menu bar is not optimal
Summary: Automatic mnemonic generation in the menu bar is not optimal
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: ui (show other issues)
Version: 4.0.0-dev
Hardware: All All
: P3 Normal (vote)
Target Milestone: 4.0.0
Assignee: Ariel Constenla-Haile
QA Contact:
URL:
Keywords: accessibility, regression
Depends on:
Blocks:
 
Reported: 2013-05-11 09:51 UTC by Andrea Pescetti
Modified: 2017-05-20 10:35 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
Accelerators comparison: 3.4.1 vs 400m1 (41.38 KB, image/png)
2013-05-11 09:51 UTC, Andrea Pescetti
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description Andrea Pescetti 2013-05-11 09:51:38 UTC
Created attachment 80670 [details]
Accelerators comparison: 3.4.1 vs 400m1

We have an accelerators-related bug in 400m1.

In Calc, Alt+O opens F~ormat but, within "Format", there is no accelerator for the Flip command (and anything below it, apparently) since F, L, I, P are all taken by other commands. This might be one of the cases where we need manual definition (for example, mapping "AutoFormat" to "m"; or improve the algorithm).

For reference, I'm attaching a 3.4.1 vs 400m1 comparison. This is a regression and has accessibility implications.
Comment 1 Ariel Constenla-Haile 2013-05-14 22:51:11 UTC
There are different problems:

a) Missing mnemonics:
New writer document. Select menu "File". 
"Print" and "Printer settings" don't mnemonic.
The same happens in a Calc document

b) Different mnemonics for generic commands:
New writer document. Select menu "Format", submenu "Arrange" has the mnemonic "Arra~nge".
New Calc document. Select menu "Format", submenu "Arrange" has the mnemonic "Arrang~e"
Comment 2 Andrea Pescetti 2013-05-15 06:58:23 UTC
The problem is mainly a): it seems that the algorithm (or bad manual assignments) make all allowed mnemonics unavailable for "Print" in Writer and for "Flip" in Calc, so that mnemonics stop working at that item. And this is an accessibility issue.

As for b) (inconsistent mnemonics across applications), it may be "nice to have" but I don't see it as a requirement or an accessibility problem. Menus are different across applications, so it's understandable that the same item has different mnemonics in Writer and Calc.
Comment 3 Ariel Constenla-Haile 2013-05-15 07:08:29 UTC
(In reply to comment #2)
> The problem is mainly a): it seems that the algorithm (or bad manual
> assignments)

there are no manual mnemonics in trunk right now, they are all generated by the vcl algorithm.

> make all allowed mnemonics unavailable for "Print" in Writer
> and for "Flip" in Calc, so that mnemonics stop working at that item

the algorithms stops assigning mnemonics once all available characters have been used.

> As for b) (inconsistent mnemonics across applications), it may be "nice to
> have" but I don't see it as a requirement or an accessibility problem

all commands that are used in more than one module (and have the same label), belong to GenericCommands.xcu, then all will have the same mnemonics.
This happens already at the top level of the menubar, and was the status up to 3.4.1 for all the commands that were in the right place (unfortunately that was not the case).
Comment 4 SVN Robot 2013-05-22 16:33:53 UTC
"arielch" committed SVN revision 1485271 into trunk:
i122288 - Bring back mnemonics
Comment 5 Andre 2014-02-28 14:02:55 UTC
Setting status to fixed (which was probably forgotten).  All cases that are described above have proper mnemonics.