Issue 124021 - Data range dialog is broken
Summary: Data range dialog is broken
Status: CLOSED FIXED
Alias: None
Product: Calc
Classification: Application
Component: editing (show other issues)
Version: 4.1.0-dev
Hardware: PC All
: P3 Major (vote)
Target Milestone: 4.1.0
Assignee: Steve Yin
QA Contact:
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2014-01-13 21:52 UTC by Regina Henschel
Modified: 2017-05-20 10:35 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: 4.1.0-dev
Developer Difficulty: ---

Attachments
Collection of commented screenshots showing the errors. (197.47 KB, application/vnd.oasis.opendocument.graphics)
2014-01-13 21:52 UTC, Regina Henschel 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Regina Henschel 2014-01-13 21:52:45 UTC 
Created attachment 82272 [details]
Collection of commented screenshots showing the errors.

To reproduce the bug, start a new calc document, add values as shown in the screenshots, mark the range A1:C6, and generate an XY-chart.
 
If you try to make an XY-chart including labels, a lot of errors occur. I'll add a collection of commented screenshots, which show the errors. In short: x-values are not detected, caption of range field is wrong, range field is empty instead of showing the current value, double roles after editing.

This was OK in AOO 4.0 and therefore it is a regression.
Comment 1 Regina Henschel 2014-01-13 23:06:18 UTC 
It is OK in r1537973 and broken in r1546977.
Comment 2 Edwin Sharp 2014-01-14 07:18:50 UTC 
Confirmed with
AOO410m1(Build:9750)  -  Rev. 1555399
2014-01-06_04:13:46 - Rev. 1555657
Debian
Comment 3 Regina Henschel 2014-01-14 17:17:20 UTC 
Hi Steve, when I revert the changes in tp_DataSource.cxx made by r1541847 the mess in the field labels are fixed. But because I do not know, why you have made the changes, please have a look.

The fact, that the wizard does not notice the labels in its first attempt, seems to have another reason. But with the reverted changes, manually correcting the initial settings works as before.
Comment 4 Regina Henschel 2014-01-15 13:46:29 UTC 
Other chart types are affected by the bug too. It makes it impossible to edit the data range. When you enter a new range, the old values are not exchanged, but new entries are added. When you then close and reopen the chart, the new entries are lost and only the old ones remain.
Comment 5 Steve Yin 2014-01-28 10:48:52 UTC 
I will take care of it. Thanks.
Comment 6 SVN Robot 2014-01-29 07:19:57 UTC 
"steve_y" committed SVN revision 1562371 into trunk:
Bug 124021 - Data range dialog is broken
Comment 7 Steve Yin 2014-02-10 07:04:33 UTC 
Reverted. For related accessible issue, QA will cover it.
Comment 8 fanyuzhen 2014-02-27 10:16:52 UTC 
Reopen because code change reverted, per comment 7
Comment 9 Steve Yin 2014-03-03 05:58:11 UTC 
This issue was caused by the changes from IA2 feature. I just rolled back some changes for IA2 feature in revision 1562371. Please verify it.