Issue 124474 - Input fields do not show content in header/footer
Summary: Input fields do not show content in header/footer
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: open-import (show other issues)
Version: 4.1.0-beta
Hardware: All All
: P3 Normal (vote)
Target Milestone: 4.1.0
Assignee: Oliver-Rainer Wittmann
QA Contact:
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2014-03-20 19:21 UTC by szurketestver
Modified: 2017-05-20 10:35 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---
jsc: 4.1.0_release_blocker+

Attachments
document with input fields in header / footer (8.95 KB, application/vnd.oasis.opendocument.text)
2014-03-20 19:21 UTC, szurketestver 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description szurketestver 2014-03-20 19:21:34 UTC 
Created attachment 82929 [details]
document with input fields in header / footer

Fix of bug 33737 caused a regression: when I open the attached demo.odt, the contents on input fields are not shown. I have to press F9, then the text becomes available.
Comment 1 Oliver-Rainer Wittmann 2014-03-21 08:01:19 UTC 
I can confirm this defect. As already stated it is a regression - AOO 4.0.1 works fine.

Taking over to work on a solution
Comment 2 Oliver-Rainer Wittmann 2014-03-21 11:46:39 UTC 
Root cause:
The input fields in the given sample document are of type 'User Variable Input Field' - their content reflects the value of a user variable ('User Field' called in the UI). (Via these input fields the value of the user variable can be changed.)
Since the in-place editing of Input Fields enhancement the content of these input fields are evaluated when the input field is inserted into the document model. For input fields in page header/footer this is done before the user variable is imported. Thus, the input fields in page header/footer are empty.
In AOO 4.0.1 (and in earlier versions) - before the in-place editing of Input Fields enhancement - the content for these input fields were evaluated when the input field is rendered into the document's view. At this time the complete document is already imported and thus, user variable's content is available.

The content of an user variable is set via the corresponding UNO-API during the ODF import. No update of the corresponding input fields is triggered. Thus, a similar defect already exists in previous version when a user variable's content gets set/changed via the UNO-API.

Triggering an update of the related input fields when a user variable is set/changed via the UNO-API - as it is done when the user variable's content is changed in the UI - will solve this defect.


Requesting show-stopper-status as a fix will be available soon and it is a regression introduced in AOO 4.1.0 code line.
Comment 3 SVN Robot 2014-03-21 12:32:10 UTC 
"orw" committed SVN revision 1579934 into trunk:
124474: on change of User Field via UNO-API trigger update to get dependent I...
Comment 4 Oliver-Rainer Wittmann 2014-03-21 12:34:11 UTC 
fixed on trunk
Comment 5 jsc 2014-03-24 07:25:28 UTC 
grant showstopper flag because it is a regression introduced in 4.1
Comment 6 SVN Robot 2014-03-24 09:15:01 UTC 
"orw" committed SVN revision 1580788 into branches/AOO410:
124474: on change of User Field via UNO-API trigger update to get dependent I...
Comment 7 Oliver-Rainer Wittmann 2014-03-24 09:16:50 UTC 
fixed on branch AOO410 for the next release
Comment 8 fanyuzhen 2014-04-04 08:49:34 UTC 
It's verified fixed in branch
AOO410m15(Build:9761)  -  Rev. 1583666
2014-04-01 13:53:14 (Di, 01 Apr 2014)