Created attachment 83949 [details]
Impress - inserted picture is not shown

Duplicate of issue 125387

Maybee it's the same root cause but not a duplicate.

The main topic of my issue is the non visability of the inserted picture in slide preview and slide show in addition to the always activated input template - not the "mosaic effect".

Issue 125387 describes only part of the observed anomalies.
I think all the side-effects have to be investigated together, the current situation is user-unfriendly.

Description of the effects, seen on Windows 7, Apache OpenOffice 4.1.1

Create a new Impress file, with one slide.
For the slide, choose in the sidebar one of the Layouts, except "Blank Slide".

- Either select a rectangle where you see "Click to add text", then menu Insert > file.
- Or if you have chosen a layout with a Content, click on the grey mask "insert Picture"
- choose an image with small dimensions

Consequences:
- you have to wait 2-3 seconds before the image appears, wondering what's going on...
- then the small image appears many times as tiles to cover the surface of the rectangle
- but the image does not appear in the Slide Pane
- run slideshow : the image does not appear
- return to edit mode; add some text in the rectangle. Then the tiled images appear in the Slide Pane, and in the slideshow.

In LibreOffice 4.2.4 the same manipulations have a normal behaviour : 
- the image appears instantly after being chosen
- the image appears correctly, both in design mode and slideshow
- once the image is inserted in the Content, the ". Click to add text" disappears, the rectangle has been replaced by the image.

And if you switch to another layout, the picture is gone.

Adding Armin to the CC because he's been working on the Impress graphics engine. Do you have any idea why the slideshow is broken in 4.1?

This may not be display issue. Impress slides created in LO and AOO <=4.0 show the pictures fine in AOO 4.1+. Slides created in AOO 4.1+ are corrupted showing blank images in the slideshow when viewed in all version of AOO and LO.

Oliver, any thoughts?

Read issue 124784, issue 123922 and issue 125387 too. The problem is, that version 4.1+ put the image into the background of a text frame, if some is present. The frame need not be activated, being present is sufficient. Effected are presentation objects "Outline text" and "Subtitle" and graphic object "Text frame" as well.

The fact, that the picture is not shown, is a side effect. The presentation object is not shown in presentation mode, because it has only the placeholder info but no real content. If you add some words, the presentation object and its background is shown in presentation mode too.

Workaround for version 4.1: Insert a slide with a blank layout. Insert the picture into that slide and from there copy and paste it to the target place.

*** Issue 125883 has been marked as a duplicate of this issue. ***

Perhaps introduced with fix for issue 123922 (cs 1565510)?

The fix for issue 123922 has introduced a new behavior in sd/Source/ui/view/sdview4.cxx in method View::InsertGraphic.

When you click on the "insert picture" button in the middle of an empty presentation object type 'text', then the presentation object becomes selected automatically. With the new behavior you get in line #27:
pPickObj is true
!bIsGraphic is true since bIsGraphic is false
pPickObj->IsClosedObj is true
Therefore the case is cought and the selected presentation object is filled with the picture as background.

Clicking on the button should not select the empty presentation object, then pPickObj would not exist.

This is not the only error. Filling an empty presentation object, when nothing is selected, is a different error. But I don't know the reason yet.

Further investigations show, that pPickObj exists, when any empty outline text is on the slide, whether it is selected or not. So in my previous comment "then pPickObj would not exist" is not right.

Why?

The method InsertGraphic is called by FuInsertGraphic::DoExecute in sd/source/ui/fuinsert.cxx

It gets the pPickObj from the call GetEmptyPresentationObject(PRESOBJ_GRAPHIC) and in case that fails, from a single marked object if any.

View::GetEmptyPresentationObject resides in sd/source/ui/view/sdview5.cxx

GetEmptyPresentationObject first looks, whether a single object is marked and IsEmptyPresObj() and whether it belongs to those PresObjKind listed in implIsMultiPresObj. It does not test the kind given in the parameter (in our case a PRESOBJ_GRAPHIC), but returns any marked object in that list, which IsEmptyPresObj(). So it will return any marked empty outline text. For me this looks erroneous, I expect that a marked object is only returned if it has the in the parameter given kind.

In case no object is marked, GetEmptyPresentationObject iterates through all objects of given kind (here PRESOBJ_GRAPHIC) and returns the first with IsEmptyPresObj(). 

At last step GetEmptyPresentationObject iterates through all from GetPresentationShapeList and returns the first one with meets IsEmptyPresObj() && implIsMultiPresObj(). Here too the kind given in the parameter is not tested, but all kind listed in implIsMultiPresObj will meet. The first one listed is the kind PRESOBJ_OUTLINE. This behavior looks erroneous too for me.

Do objects of kinds listed in implIsMultiPresObj() other than PRESOBJ_OUTLINE can be an IsEmptyPresObj()? What it the purpose of method GetEmptyPresentationObject?

The error has other manifestations too:
Take a slide with an empty outline text. Do not mark the outline text. Insert a formula. The formula replaces the outline text.
Take a slide with an empty outline text and a formula. (To get the formula insert it from clipboard.) Mark the formula. Insert picture from file. The background of the formula should be filled, but the outline text is filled instead.

Filling the background of the placeholder outline can be fixed by adding the condition
 &&!(pPickObj->IsEmptyPresObj() )
to the "if" in line #112 in View::InsertGraphic in sdview4.cxx

But following problem remains:
When a placeholder outline is present, then inserting not via overlay but directly, or inserting a formula, this will replace the placeholder outline object. This happens even in the case another object (e.g. graphic or picture) is selected.

"regina" committed SVN revision 1650314 into trunk:
#i125613# Insert Picture from file do not work

(In reply to SVN Robot from comment #14)
> "regina" committed SVN revision 1650314 into trunk:
> #i125613# Insert Picture from file do not work

My team and I are aiming to fix bugs and thought that this would be a good one to try. Even with the revision, does the bug need to be fixed? We would like to fix this issue.

"Commited into trunk" means, that the fix is integrated in the source. The daily builds on http://ci.apache.org/projects/openoffice/install/ should work well. If you find, that a daily build still shows this error, please write a note here.

So no, this is not a "good one to try", because it is already fixed. Please write a mail to dev@openoffice.apache.org. We can help you finding an interesting task.

Tested with AOO 4.2.0 r1658822 de
Works fine.

So the issue should be closed as "fixed"?

Changed to resolved fixed per reporter jmpoo in Comment 17

*** Issue 126265 has been marked as a duplicate of this issue. ***

*** Issue 126493 has been marked as a duplicate of this issue. ***

@regina: since this was a bugfix you took care of and it is a regression, do you want to see it ported to OpenOffice 4.1.2?

Yes, a port to AOO 4.1.2 would be useful. The bug is really annoying and I do not read complains that the fix does not work.

As per discussion in the issue: approved for 4.1.2. Regina: feel free to merge it yourself or ask me/anyone to do it.

"pescetti" committed SVN revision 1705514 into branches/AOO410:
#i125613# Fix "Insert Picture from file does not work".

Confirmed fixed with

AOO412m1(Build:9780)  -  Rev. 1705625
2015-09-28 12:45:04 (Mo, 28 Sep 2015)

under Windows XP Pro x86 SP3

*** Issue 124784 has been marked as a duplicate of this issue. ***

HELP!!!

I installed OO 4.1.2, but I still encountered the problem twice. Symptoms: I use a slide lay-out with only a title box. Choose insert picture from file. The picture I am inserting is a TIFF file. I place it in the middle of the slide. So far so good.

After doing some more updates to the presentation the picture was gone again. I have no clue yet what the exact conditions were how the picture disappeared, but it could be when switching between slide sorter and normal display.

If I see it happening again, I will save the file and upload it.

(In reply to erikt from comment #27)
> HELP!!!
> 
> I installed OO 4.1.2, but I still encountered the problem twice. Symptoms: I
> use a slide lay-out with only a title box. Choose insert picture from file.
> The picture I am inserting is a TIFF file. I place it in the middle of the
> slide. So far so good.
> 
> After doing some more updates to the presentation the picture was gone
> again. I have no clue yet what the exact conditions were how the picture
> disappeared, but it could be when switching between slide sorter and normal
> display.
> 
> If I see it happening again, I will save the file and upload it.

Hi erikt

That is not the same problem as the one reported in the bug. If you are able to replicate your problem, please open a new bug report and attach the sample file. Thank you for contributing to the improvement of OpenOffice!

I have Verified that the reported bug is Fixed in AOO420m1(Build:9800) - Rev. 1757080 under Windows 7 Pro x64 SP1

Closing based on verification.

*** Issue 127654 has been marked as a duplicate of this issue. ***