Issue 42725 - Font size for default fonts needs to be configurable for each font
Summary: Font size for default fonts needs to be configurable for each font
Status: CLOSED FIXED
Alias: None
Product: Internationalization
Classification: Code
Component: code (show other issues)
Version: 680m74
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: stefan.baltzer
QA Contact: issues@l10n
URL: http://specs.openoffice.org/g11n/font...
Keywords: oooqa
Depends on:
Blocks: 41707
  Show dependency tree
 
Reported: 2005-02-14 12:44 UTC by samphan
Modified: 2013-08-07 15:03 UTC (History)
6 users (show)

See Also:
Issue Type: FEATURE
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
Example of patch that changes the hard-coded font size (10.07 KB, patch)
2005-02-14 12:45 UTC, samphan
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description samphan 2005-02-14 12:44:00 UTC
OOo hard-codes a default font size of 10 points or 12 points in a number of
places (see the attached patch). For most Thai fonts, 10 points or 12 points is
unreadably small.  Thai characters have four vertical levels (base, one
diacritic below and two diacritics above).  When Thai characters are mixed with
Latin characters, the relative sizes of Thai and Latin characters are usually
chosen so that the bottom of below diacritics is lower than the bottom of Latin
descenders, and the top of the second level Thai diacritics is higher than the
top of Latin ascenders. 

The (not unreasonable) normal convention for Thai fonts is that in an N point
font the distance from the bottom of the below-diacritic to the top of the
second above-diacritic is N points.  Thai typesetting would typically use a 16
point default font size.  Thai fonts typically contain Latin characters as well:
the Latin characters in a 16 point Thai font would be about the same size as the
characters in a normal 12-point Western font.  

Some newer fonts don't follow this convention.  Instead, the size of a font is
based on the size of the Latin characters.  In this case, the default font size
could be 12 points.

For example, on Windows, WordPad defaults to Arial 10pt in a Western locale
(e.g. Control Panel|Regional and Language Options|Regional Options set to
English US), but Cordia 14pt in a Thai locale. In a Western locale, if I change
the keyboard layout to Thai, the font changes to Cordia 14pt

OfficeTLE (a Thai localized OOo) solution to this is just to hard-code 16 points
instead of 12 points as the default font size. See the attached patch (for OOo
1.1.3). 

I'm not exactly sure what the right solution is. I think part of it is probably
to allow officecfg/registry/data/org/openoffice/VCL.xcu to optionally specify a
font size for each default font, e.g.

<value>Norasi:16;Bistream Vera Sans:12;Tahoma:12</value>
Comment 1 samphan 2005-02-14 12:45:34 UTC
Created attachment 22584 [details]
Example of patch that changes the hard-coded font size
Comment 2 lists 2005-02-21 07:02:19 UTC
Without giving any solution, here are a couple of ideas on this issue

A similar issue used to happen in Khmer. Legacy fonts -when using size 10/12-
are too small to be read. We have found these fonts not to be suitable for
localisation of user interfaces, for the cases in which both English and Khmer
need to be mixed together in the same message.

An example of this would be when specifying code-pages, the name will be in
Khmer, but the code in English. If non-proportional fonts are used, then the
English is far too large. We have ended developing hinted fonts that are
completelly proportional, so that the 10 size is exactly as readable as the
English size 10. 

Again, if non-proportional fonts are used for typing, it would be important that
the change in size is automatic... but please note that different people write
in English in different sizes (between 10 and 12), and that the size in Thai
would depend on the size in English.
Comment 3 arthit 2005-04-02 00:03:37 UTC
confirmed.
Comment 4 Martin Hollmichel 2005-05-11 16:36:47 UTC
set target to 2.0.1
Comment 5 falko.tesch 2005-09-27 13:16:39 UTC
FT: Spec has been published at
http://specs.openoffice.org/g11n/font_sizes/42775_42725_Individual_configurable_font_size_for_default_fonts.odt
Please start implementation. Thanks.
Comment 6 falko.tesch 2005-09-27 13:18:44 UTC
.
Comment 7 Oliver Specht 2005-10-13 14:51:18 UTC
Fixed in cws thaiissues in
sw/source/ui/config/fontcfg.cxx
sw/source/ui/config/optdlg.hrc
sw/source/ui/config/optdlg.src
sw/source/ui/config/optpage.cxx
sw/source/ui/inc/fontcfg.hxx
sw/source/ui/inc/optpage.hxx
sw/source/ui/shells/basesh.cxx
officecfg/registry/schema/org/openoffice/Office/Writer.xcs
Comment 8 Oliver Specht 2005-10-31 11:35:22 UTC
Reassigned for verification

re-open issue and reassign to sba@openoffice.org
Comment 9 Oliver Specht 2005-10-31 11:35:31 UTC
reassign to sba@openoffice.org
Comment 10 Oliver Specht 2005-10-31 11:35:38 UTC
reset resolution to FIXED
Comment 11 stefan.baltzer 2005-11-07 10:48:24 UTC
SBA->HI: Please proceed.

re-open issue and reassign to hi@openoffice.org
Comment 12 stefan.baltzer 2005-11-07 11:01:12 UTC
reassign to hi@openoffice.org
Comment 13 stefan.baltzer 2005-11-07 11:10:40 UTC
reset resolution to FIXED
Comment 14 h.ilter 2005-11-08 10:37:47 UTC
Verified with cws tahiissues = The UI for basic fonts will not keep the font
size. Reproduce with WinXP. Linux and Sparc.
- Click on default button - Restart Office - Go to Basic Fonts UI -> Values changed.
Note: In WinXP, I got not valid entries after office restart.
Comment 15 h.ilter 2005-11-08 10:39:24 UTC
Back to OS.
Comment 16 Oliver Specht 2005-11-09 07:08:38 UTC
Fixed in 
sw/source/ui/app/docshini.cxx
sw/source/ui/inc/fontcfg.hxx
sw/source/ui/config/fontcfg.cxx
sw/source/ui/config/optpage.cxx
sw/source/ui/shells/basesh.cxx
Comment 17 stefan.baltzer 2005-11-11 16:54:37 UTC
SBA: Reassigned to HI.

re-open issue and reassign to hi@openoffice.org
Comment 18 stefan.baltzer 2005-11-11 16:54:46 UTC
reassign to hi@openoffice.org
Comment 19 stefan.baltzer 2005-11-11 16:54:54 UTC
reset resolution to FIXED
Comment 20 stefan.baltzer 2005-11-11 16:56:17 UTC
reassign to hi@openoffice.org
Comment 21 stefan.baltzer 2005-11-11 16:56:29 UTC
reset resolution to FIXED
Comment 22 stefan.baltzer 2005-11-14 09:40:51 UTC
SBA: Reopened.
Comment 23 stefan.baltzer 2005-11-14 09:51:29 UTC
SBA->OS: Back to you. As discussed, the settings of the Font size for "List"
gets mistakenly taken from "Heading" when both were changed and Office is
restarted. 
Comment 24 Oliver Specht 2005-11-14 09:57:51 UTC
Again fixed, in sw/source/ui/config/optpage.cxx
Comment 25 Oliver Specht 2005-11-14 09:58:06 UTC
.
Comment 26 stefan.baltzer 2005-11-14 17:47:10 UTC
SBA: Verified in CWS thaiissues.
Comment 27 jack.warchold 2006-03-08 14:53:41 UTC
looks good in OOo SRC680_m158
closing