Issue 45118 - Export DEFAULT_TO_ENGLISH_FOR_PACKING="yes" into env.
Summary: Export DEFAULT_TO_ENGLISH_FOR_PACKING="yes" into env.
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: configure (show other issues)
Version: 680m86
Hardware: All All
: P4 Trivial (vote)
Target Milestone: OOo 2.0
Assignee: pavel
QA Contact: issues@tools
URL:
Keywords:
: 46564 (view as issue list)
Depends on:
Blocks:
 
Reported: 2005-03-15 19:51 UTC by pavel
Modified: 2006-03-14 21:02 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
oneliner (613 bytes, patch)
2005-05-14 07:40 UTC, pavel
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description pavel 2005-03-15 19:51:25 UTC
Hi,

the variable DEFAULT_TO_ENGLISH_FOR_PACKING is used by native installer
(solenv/bin/modules/installer/scriptitems.pm) to turn on the fallback for
missing language-dependent files. If it is set in the environment (I propose to
set it to "yes"), resp. en-US files are used and the warning is printed:

    WARNING: Using tplpresntimpr_en-US.zip instead of tplpresntimpr_nso.zip

This allows people building OOo in new languages to build without the need to
hack inside extras, helpcontent2 etc.
Comment 1 pavel 2005-03-20 11:28:52 UTC
Change target to 2.0.
Comment 2 rene 2005-03-21 10:36:05 UTC
this environment variable is a hack and should not be needed. AFIAIS it 
duplicates those english stuff in every langpack. no. don't do this. Add the 
localized stuff to the langpack and let the eghlish stuff where it belongs (in 
the english one / in the main package). I won't add that to configure. 
Comment 3 pavel 2005-03-21 11:03:03 UTC
no. You understand it wrong. It doesn't duplicate it in every language pack.

It is using English variants of localizable files if there is none for your
language available, thus it allows you to:

- create e.g. Xhosa installation set (not language pack!) with English help,
because Xhosa doesn't have Help translated yet. You can s/Xhosa/whatever
language still doesn't have help/.

- create e.g. Xhosa installation set (not language pack!) with English extras,
because Xhosa doesn't have extras localized yet. You can s/Xhosa/whatever
language still doesn't have extras/.

It doesn't affect installation sets nor language packs that have all files
available/translated/localized. It can only help. It doesn't hurt anyone.

You're statement about "main package" is nonsense, because you can have e.g.
Afrikaans main package and Xhosa language pack. Both languages do not have help
and both languages do not have extras. So what is your solution for such languages?
Comment 4 rene 2005-03-21 14:39:36 UTC
Hi, 
 
> - create e.g. Xhosa installation set (not language pack!) with English help, 
> because Xhosa doesn't have Help translated yet. You can s/Xhosa/whatever 
> language still doesn't have help/. 
 
that's duplicating the help. 
 
> - create e.g. Xhosa installation set (not language pack!) with English 
extras, 
> because Xhosa doesn't have extras localized yet. You can s/Xhosa/whatever 
> language still doesn't have extras/. 
 
see above, just with extras. 
 
> It doesn't affect installation sets nor language packs that have all files 
> available/translated/localized. It can only help. It doesn't hurt anyone. 
 
and what about language packs which do *not* have all stuff available? will 
they get the english help/english extras there, too? That would be broken and 
that's what I think is bad. 
 
> You're statement about "main package" is nonsense, because you can have e.g. 
> Afrikaans main package and Xhosa language pack. Both languages do not have 
> help and both languages do not have extras. So what is your solution for 
> such languages? 
 
don't pack the help and extras into them if there isn't any. if they need the 
english ones, too, they should just install the english language pack or 
whatever too and OOo should fallback to it (what it IIRC does already for the 
help) 
 
Regards, 
 
Rene 
Comment 5 pavel 2005-03-21 17:11:13 UTC
> > - create e.g. Xhosa installation set (not language pack!) with English help, 
> > because Xhosa doesn't have Help translated yet. You can s/Xhosa/whatever 
> > language still doesn't have help/. 
> that's duplicating the help.

No, it is not. In Xhosa only installation set, there is no help to duplicate.
There is only one instance of help, the English one that is integrated because
of the proposed setting. You can't duplicate something you do not have yet...

The same applies to extras. You do not have any extras to duplicate in Xhosa
installation set.

The other question is when you talk about language packs. But current system
that is not going to be changed for 2.0 doesn't allow language pack without
extras or help.
Comment 6 eric.bachard 2005-04-19 17:46:57 UTC
*** Issue 46564 has been marked as a duplicate of this issue. ***
Comment 7 pavel 2005-05-13 19:53:31 UTC
Taking over.
Comment 8 pavel 2005-05-13 19:56:00 UTC
started.
Comment 9 pavel 2005-05-14 07:40:44 UTC
Created attachment 26132 [details]
oneliner
Comment 10 pavel 2005-05-17 17:19:26 UTC
Fixed in pj28.
Comment 11 pavel 2005-05-18 12:26:07 UTC
verified.
Comment 12 Martin Hollmichel 2005-05-23 07:26:06 UTC
close issue.