Issue 48703 - Accessibility: slide sorter must be made accessible
Summary: Accessibility: slide sorter must be made accessible
Status: CLOSED FIXED
Alias: None
Product: Impress
Classification: Application
Component: ui (show other issues)
Version: 680m97
Hardware: All Linux, all
: P3 Trivial (vote)
Target Milestone: OOo 2.0
Assignee: wolframgarten
QA Contact: issues@graphics
URL:
Keywords: accessibility
Depends on:
Blocks:
 
Reported: 2005-05-04 13:41 UTC by wolframgarten
Modified: 2005-07-18 09:40 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description wolframgarten 2005-05-04 13:41:51 UTC 
Open a new impress and switch to slide sorter view. It is not accessible using
the keyboard and gnoerpnicus does not discover it.
Comment 1 wolframgarten 2005-05-04 13:42:39 UTC 
Keyword added.
Comment 2 groucho266 2005-05-09 09:16:05 UTC 
Accepted.
Comment 3 groucho266 2005-05-20 12:08:12 UTC 
Fixed.

Affected files:

New:
sd/source/ui/inc/AccessibleSlideSorterObject.hxx                1.1.2.1
sd/source/ui/inc/AccessibleSlideSorterView.hxx                  1.1.2.2
sd/source/ui/accessibility/AccessibleSlideSorterObject.cx       1.1.2.1
sd/source/ui/accessibility/AccessibleSlideSorterView.cxx        1.1.2.3


Modified:
/sd/source/ui/accessibility/makefile.mk                         1.13.498.1
/sd/source/ui/inc/SlideSorterViewShell.hxx                      1.5.90.1
/sd/source/ui/slidesorter/cache/SlsQueueProcessor.hxx           1.6.88.1
/sd/source/ui/slidesorter/controller/SlsFocusManager.cxx        1.6.90.1
/sd/source/ui/slidesorter/controller/SlideSorterController.cxx  1.18.18.2
/sd/source/ui/slidesorter/inc/controller/SlsFocusManager.hxx    1.4.120.1
/sd/source/ui/slidesorter/inc/view/SlideSorterView.hxx          1.4.256.2
/sd/source/ui/slidesorter/view/SlideSorterView.cxx              1.10.18.2
/sd/source/ui/slidesorter/shell/SlideSorterViewShell.cxx        1.12.40.3
Comment 4 wolframgarten 2005-05-27 08:32:39 UTC 
Retargeting.
Comment 5 groucho266 2005-06-23 10:35:15 UTC 
Back to QA for verification.

re-open issue and reassign to cgu@openoffice.org
Comment 6 groucho266 2005-06-23 10:35:43 UTC 
reassign to cgu@openoffice.org
Comment 7 groucho266 2005-06-23 10:36:07 UTC 
reset resolution to FIXED
Comment 8 christian.guenther 2005-07-07 09:59:42 UTC 
The reporter of this issue is wg therefore I reassign it to wg.

re-open issue and reassign to wg@openoffice.org
Comment 9 christian.guenther 2005-07-07 09:59:48 UTC 
reassign to wg@openoffice.org
Comment 10 christian.guenther 2005-07-07 09:59:57 UTC 
reset resolution to FIXED
Comment 11 groucho266 2005-07-11 16:57:38 UTC 
There was crash on Linux on one JDS computer: Inserting slides via the tool bar
into a fresh Impress document lead to a crash when gnopernicus was running in
the background.  This involved the JVM crashing as well.

The reason for this seems to be (net absolutely sure yet) was the
AccessibleSlideSorterView::Implementation::GetAccessibleChild() method which had
an assertion against invalid child indices but nothing to actually prevent it
from using them.

Added such a guard to sd/source/ui/accessibility/AccessibleSlideSorterView.cxx 
 rev. 1.1.2.4
Comment 12 wolframgarten 2005-07-12 08:48:00 UTC 
Verified in CWS. Crash is fixed now.
Comment 13 wolframgarten 2005-07-14 10:56:56 UTC 
Target changed.
Comment 14 wolframgarten 2005-07-18 09:40:30 UTC 
Tested in master m118. Closed.