Issue 52055 - Restricted sequence checking for Thai disallows some valid sequences
Summary: Restricted sequence checking for Thai disallows some valid sequences
Status: CLOSED FIXED
Alias: None
Product: Internationalization
Classification: Code
Component: code (show other issues)
Version: OOo 2.0 Beta
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: stefan.baltzer
QA Contact: issues@l10n
URL:
Keywords:
Depends on:
Blocks: 41707
  Show dependency tree
 
Reported: 2005-07-16 07:53 UTC by markpeak
Modified: 2013-08-07 15:03 UTC (History)
6 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
The patch that change two entries (S->A) in _TAC_celltype_inputcheck to fixed this issue (1.18 KB, patch)
2005-08-22 07:23 UTC, samphan 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description markpeak 2005-07-16 07:53:04 UTC 
Step to reproduce
1. Enable CTL in OOo Option > Languages and select dropdown CTL list to Thai
2. In Language Settings > Complex Text Layout, enable "sequence checking" and
"restricted" mode
3. try to type some "ordinary following vowels" (ะาำ) and follow by "leading
vowels" (เ แ โ ไ ใ) e.g. "กระแทก", "และเพื่อ"
4. OOo2 won't allow this input sequence

These input sequences is ordinary Thai spelling, then Thai people can't create
document if they enable "restricted" mode.
Comment 1 markpeak 2005-07-16 08:03:01 UTC 
Thai input sequence uses WTT 2.0 specification for reference.
OOo2 implement WTT 2.0 sequence table in
i18npool/source/inputchecker/inputsequencechecker_th.cxx

It seems to use this copy [1] of WTT 2.0 as reference. However some value in the
sequence map (Page 23) of row 4 [FV1] (or row /* 40 */ in code) is incorrect. We
should use this WTT 2.0 reference [2] instead.

Samphan will provide patch.

[1] http://www.inet.co.th/cyberclub/trin/thairef/wtt2/char-class.pdf
[2] http://linux.thai.net/~thep/th-xim/#IMOM
Comment 2 arthit 2005-07-16 14:57:38 UTC 
reproducible in 1.9m113 Windows.

confirmed.
Comment 3 arthit 2005-07-16 14:59:02 UTC 
note: if this sequence checking is considered as "Basic functionality", the
Priority should be P2.
Comment 4 falko.tesch 2005-08-11 08:34:32 UTC 
FT->KH: This is in fact a very limiting defect for Thai users (I know because I
can write and read Thai).
Please have a look into this issue and check the patch provided.
I put this issue on target PP2. Please decide if this applicable or not. Thx a lot.
Comment 5 samphan 2005-08-22 07:23:27 UTC 
Created attachment 28958 [details]
The patch that change two entries (S->A) in _TAC_celltype_inputcheck to fixed this issue
Comment 6 samphan 2005-08-22 07:26:28 UTC 
Sorry for submit the patch late. The patch fix the bug. I've tested it on m95 on
Windows.
Comment 7 karl.hong 2005-08-27 01:01:31 UTC 
apply patch in cws thaiissues.
Comment 8 karl.hong 2005-11-01 16:51:09 UTC 
ready for QA.

re-open issue and reassign to sba@openoffice.org
Comment 9 karl.hong 2005-11-02 00:42:00 UTC 
read for QA
Comment 10 stefan.baltzer 2005-11-03 16:41:47 UTC 
SBA: Correcting status to "fixed".
Comment 11 stefan.baltzer 2005-11-03 17:02:22 UTC 
SBA->James: I'd appreciate very much if some native speaker could have a look at
the CWS to see if this works as expected. 
Please comment.
Set MH on c/c.
Comment 12 samphan 2005-11-07 03:16:09 UTC 
I've downloaded
http://oootranslation.services.openoffice.org/pub/OpenOffice.org/cws/upload/thaiissues/
and tested this issue.
It works correctly.
Comment 13 stefan.baltzer 2005-11-09 17:19:02 UTC 
SBA->samphan: Thanks a lot.
Set to verified.
Comment 14 stefan.baltzer 2006-04-07 16:34:29 UTC 
SBA: The verification in Master should be undergone by a native speaker.
If all works fine, please comment and lose this one. 
Thank you.
Comment 15 stefan.baltzer 2006-04-07 16:44:37 UTC 
SBA: Correction...
should read "... and CLOSE this one" :-)
Comment 16 stefan.baltzer 2006-06-12 16:04:01 UTC 
SBA: Closed.