Issue 54913 - Input sequence checking and correction needs to work in EditEngine (Calc, Draw, Impress)
Summary: Input sequence checking and correction needs to work in EditEngine (Calc, Dra...
Status: CLOSED FIXED
Alias: None
Product: Draw
Classification: Application
Component: editing (show other issues)
Version: OOO 2.0 Beta2
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 2.0.3
Assignee: stefan.baltzer
QA Contact: issues@graphics
URL:
Keywords:
Depends on:
Blocks: 41707
  Show dependency tree
 
Reported: 2005-09-21 15:17 UTC by jjc
Modified: 2006-07-04 11:17 UTC (History)
6 users (show)

See Also:
Issue Type: ENHANCEMENT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description jjc 2005-09-21 15:17:32 UTC 
Input sequence checking and correction doesn't work anywhere except in Writer.

For example, in Impress if you type an illegal input sequence in Thai (such as
[gor gai][mai ek][mai tho]) it will not be detected.  This is particularly bad
since the display engine often cannot display such sequences in a reasonable way.

Input sequence checking is a "must-have" feature for Thai.
Comment 1 wolframgarten 2005-09-22 08:04:50 UTC 
Reassigned.
Comment 2 jjc 2005-09-22 12:19:37 UTC 
.
Comment 3 falko.tesch 2005-10-20 16:56:47 UTC 
.
Comment 4 falko.tesch 2005-10-20 20:48:16 UTC 
FT: Please take over.
Comment 5 samphan 2006-01-26 10:32:07 UTC 
Strangely, sequence checking works in Calc, but not in Impress/Draw/Base and
dialog boxes. Sequence correction is only avaiable in Writer.
For users, automatic sequence correction is prefered to only sequence checking
and should be avaiable in all program including the dialog boxes.
Comment 6 Martin Hollmichel 2006-01-26 17:01:09 UTC 
reassign for implentation in EditEngine also.
Comment 7 jjc 2006-01-27 05:19:24 UTC 
Will implementing it in EditEngine also make it work in dialogs?
Comment 8 thomas.lange 2006-01-30 09:57:43 UTC 
Since AFAIK many dialogs use the MultiLineEdit (which is unrelated to the
EditEngine) I think most probably not. 

But I was told there are also some dialogs that make use of the EditEngine.
Thus for some it will work and for others not. :-/
Comment 9 thomas.lange 2006-01-30 09:58:43 UTC 
Adding HDU to cc list.
Comment 10 jjc 2006-01-30 10:52:35 UTC 
Should we then have a separate issue for input sequence checking in dialogs?
Input sequence correction would be nice in dialogs, but isn't essential; input
sequence checking is. (There's already issue 55937 for making cursor movement
work by clusters in dialogs.)
Comment 11 thomas.lange 2006-01-30 11:05:08 UTC 
According to MT to have it available in all dialogs the classes TextEngine and
Edit need to be modified as well.
Comment 12 thomas.lange 2006-01-30 11:06:39 UTC 
A separate issue sounds fine to me.
Comment 13 jjc 2006-01-31 03:20:13 UTC 
I created issue 61397.
Comment 14 thomas.lange 2006-02-03 08:44:11 UTC 
TL->James: A question that just poped up that nobody could answer for sure:
Should input sequence checking only be applied to text inserted via the UI e.g.
after key-events? And how about pasted text? 
Or should it be applied to text inserted via API as well?
Comment 15 jjc 2006-02-04 13:13:54 UTC 
This is an input feature: I would say it should apply just to text that the user
types on the keyboard, not pasted text nor text inserted via the UI.
Comment 16 thomas.lange 2006-02-13 10:56:26 UTC 
.
Comment 17 thomas.lange 2006-02-13 10:57:39 UTC 
Fixed in CWS tl19.

Files changed:
- svx/source/editeng/editdoc.cxx
- svx/source/editeng/editdoc.hxx
- source/editeng/editeng.cxx
- svx/source/editeng/impedit.hxx
- svx/source/editeng/impedit2.cxx
- svx/source/editeng/impedit3.cxx
Comment 18 thomas.lange 2006-02-13 13:01:31 UTC 
TL: changed summary to what exactly got solved by this issue.
Comment 19 thomas.lange 2006-03-01 10:26:25 UTC 
.

re-open issue and reassign to sba@openoffice.org
Comment 20 thomas.lange 2006-03-01 10:26:34 UTC 
reassign to sba@openoffice.org
Comment 21 thomas.lange 2006-03-01 10:26:38 UTC 
reset resolution to FIXED
Comment 22 stefan.baltzer 2006-03-13 11:29:46 UTC 
SBA: Verified in CWS tl19.
Comment 23 stefan.baltzer 2006-07-04 11:17:55 UTC 
SBA: Closed.