Issue 6058 - OOO_STABLE_1/X11+Aqua: extensions needs patch to build
Summary: OOO_STABLE_1/X11+Aqua: extensions needs patch to build
Status: CLOSED FIXED
Alias: None
Product: porting
Classification: Code
Component: code (show other issues)
Version: OOo 1.0.0
Hardware: Mac Mac OS X, all
: P3 Trivial (vote)
Target Milestone: OOo 1.0.4
Assignee: ed
QA Contact: issues@porting
URL:
Keywords: merge_pending
Depends on:
Blocks: 2588
  Show dependency tree
 
Reported: 2002-06-22 21:17 UTC by ed
Modified: 2004-05-19 16:55 UTC (History)
2 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
cd $SRCROOT/extensions; patch -p0 < extensions.062202.patch (8.50 KB, patch)
2002-06-22 21:17 UTC, ed
no flags Details | Diff
cd to SRC_ROOT/extensions, patch -p0 < /path/to/patchfile ---SUPERCEDES--- previous patch, requires clean checkout of extensions (9.26 KB, patch)
2002-09-01 21:37 UTC, fa
no flags Details | Diff
Fixes static data member problem in source/dbpilots directory. Supercedes all previous patches. (10.82 KB, patch)
2002-09-18 18:02 UTC, pluby
no flags Details | Diff
Fixes static data member problem in extensions/source/preload directory (11.79 KB, patch)
2002-09-24 00:06 UTC, pluby
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description ed 2002-06-22 21:17:01 UTC
The extensions module needs a patch to build successfully.  Note that this
patch fixes the plugin portion of extensions to build properly for X11 and
Aqua, linking errors, and also *skips* dbpilots and scanner as they are
using templates in a way that is incompatible with our init-static-template-data
fix.

Before applying the patch, you *must* add the extra aqua files from 
Issue 5356, the extensions.052802.files.tar.gz file.  For reference, download
that file and then:

cd $SRCROOT/extensions
tar xvfz extensions.052802.files.tar.gz
Comment 1 ed 2002-06-22 21:17:44 UTC
Created attachment 2046 [details]
cd $SRCROOT/extensions; patch -p0 < extensions.062202.patch
Comment 2 fa 2002-08-05 19:37:59 UTC
Printing patches for X11 printing bring in readdir_r() so we should 
rework this patch for that before committing.

Dan
Comment 3 khendricks 2002-08-07 20:15:22 UTC
Hi, 
 
A couple of things: 
 
1. Dan is right this patch uses readdir when readdir_r is now (or 
soon will be) available for MacOSX 
 
2. makefile.rc files are old and no longer used and really should 
not be there anymore 
 
3. Please don't bother to patch cvs header lines 
 
4. I still think we should somehow have a define to turn on and off 
all of the static initializer code so that when gcc3 comes out, 
everything can easily be compiled (who will remember what was 
skipped here due to problems).  Either thot or a huge blatant FIXME 
should be incorporated. 
 
I frankly thing MacOSX development should move to gcc3 completely 
and drop all gcc 2.95.X support to simplify and streamline 
development.  PPC Linux now only supports gcc3 for building but the 
binaries can easily be run on gcc 2.95.3 systems since we include 
libstdc++.so and libgcc_s.so in our program directory. 
 
 
I would be happy to re-examine this patch when readdir_r and 
whatever else has been updated. 
 
Kevin 
 
  
Comment 4 fa 2002-08-07 20:21:49 UTC
Kevin,

I'm trying to figure out if gcc3 will still be compatible with 
10.1.x.  We can't be sure of this until we actually get Jaguar on 
8/24 and implement gcc3 support to try it out.  I'm asking around to 
see if we can simply move to gcc3 (which I think we'd all like to do) 
while still being able to run the resulting binaries on MacOS X 
10.1.  I have to state that 10.1 compatibility is a MUST and if we 
can't guaruntee it then we are stuck with two compilers.

In any case, we'll be running both Apple gcc2.95.2 and Apple gcc3 
compiles until we figure this out.  I'd estimate that Apple gcc2 and 
Apple gcc3 will need to co-exist in the port for at least 6 months.

Dan
Comment 5 fa 2002-09-01 21:37:09 UTC
Created attachment 2673 [details]
cd to SRC_ROOT/extensions, patch -p0 < /path/to/patchfile  ---SUPERCEDES--- previous patch, requires clean checkout of extensions
Comment 6 fa 2002-09-01 21:42:32 UTC
Hi,

Request approval for 090102 patchfile.  It is a respin of the previous patchfile, but changes the following things:

1) Removes unnecessary patching of CVS header info
2) Removes the readdir_r()->readdir() hack for MacOS X instead leaving using the normal readdir_r(), now that we have it
3) Adds MacOS X specific Netscape Plug-in directories to the plug-in search path so MacOS X plugins get recognized (they can't be run yet however (?))

Should be applied to clean checkout of extensions, and then you MUST grab the extensions.052802.files.tar.gz file from Issue 5356 and then:
 
cd $SRCROOT/extensions
tar xvfz extensions.052802.files.tar.gz

Dan

PS - If we're not using the makefile.rc anymore, why are they still around?  Does dmake automatically iterate through directories now?
Comment 7 pluby 2002-09-18 18:02:51 UTC
Created attachment 2900 [details]
Fixes static data member problem in source/dbpilots directory. Supercedes all previous patches.
Comment 8 pluby 2002-09-18 18:06:14 UTC
The extensions.OOO_STABLE_1.091802.patch file is an update to Dan
Williams' patch. This patch implements a workaround for the
init-static-data-members script limitations so that the
source/dbpilots directory can now be compiled on Mac OS X 10.1.

The patch needs to be applied to a clean checkout of the extensions
project. Please use the instructions in Dan Williams' patch to apply
this patch.
Comment 9 pluby 2002-09-24 00:06:31 UTC
Created attachment 2949 [details]
Fixes static data member problem in extensions/source/preload directory
Comment 10 pluby 2002-09-24 00:08:08 UTC
Latest patch - extensions.OOO_STABLE_1_PORTS.0923-02.patch -
supercedes all earlier patches. It should be applied against a clean
checkout using the following commands:

  cd $SRCROOT/extensions ; patch -p0 < /path/to/patch/file
Comment 11 khendricks 2002-11-21 14:24:15 UTC
 Hi, 
 
completely MacOSX specific - approved 
 
Kevin 
Comment 12 fa 2002-11-21 22:15:45 UTC
092302 patch committed to _PORTS.

Dan
Comment 13 fa 2002-11-21 23:11:18 UTC
Changed to merge_pending.

Merge:
1) extensions.OOO_STABLE_1_PORTS.092302.patch
2) Also add files from extensions/source/plugin/aqua

dan
Comment 14 fa 2004-05-19 16:54:57 UTC
static data member stuff is no longer a problem.  obsolete, closing.
Comment 15 fa 2004-05-19 16:55:07 UTC
.