Apache OpenOffice (AOO) Bugzilla – Issue 6058
OOO_STABLE_1/X11+Aqua: extensions needs patch to build
Last modified: 2004-05-19 16:55:07 UTC
The extensions module needs a patch to build successfully. Note that this patch fixes the plugin portion of extensions to build properly for X11 and Aqua, linking errors, and also *skips* dbpilots and scanner as they are using templates in a way that is incompatible with our init-static-template-data fix. Before applying the patch, you *must* add the extra aqua files from Issue 5356, the extensions.052802.files.tar.gz file. For reference, download that file and then: cd $SRCROOT/extensions tar xvfz extensions.052802.files.tar.gz
Created attachment 2046 [details] cd $SRCROOT/extensions; patch -p0 < extensions.062202.patch
Printing patches for X11 printing bring in readdir_r() so we should rework this patch for that before committing. Dan
Hi, A couple of things: 1. Dan is right this patch uses readdir when readdir_r is now (or soon will be) available for MacOSX 2. makefile.rc files are old and no longer used and really should not be there anymore 3. Please don't bother to patch cvs header lines 4. I still think we should somehow have a define to turn on and off all of the static initializer code so that when gcc3 comes out, everything can easily be compiled (who will remember what was skipped here due to problems). Either thot or a huge blatant FIXME should be incorporated. I frankly thing MacOSX development should move to gcc3 completely and drop all gcc 2.95.X support to simplify and streamline development. PPC Linux now only supports gcc3 for building but the binaries can easily be run on gcc 2.95.3 systems since we include libstdc++.so and libgcc_s.so in our program directory. I would be happy to re-examine this patch when readdir_r and whatever else has been updated. Kevin
Kevin, I'm trying to figure out if gcc3 will still be compatible with 10.1.x. We can't be sure of this until we actually get Jaguar on 8/24 and implement gcc3 support to try it out. I'm asking around to see if we can simply move to gcc3 (which I think we'd all like to do) while still being able to run the resulting binaries on MacOS X 10.1. I have to state that 10.1 compatibility is a MUST and if we can't guaruntee it then we are stuck with two compilers. In any case, we'll be running both Apple gcc2.95.2 and Apple gcc3 compiles until we figure this out. I'd estimate that Apple gcc2 and Apple gcc3 will need to co-exist in the port for at least 6 months. Dan
Created attachment 2673 [details] cd to SRC_ROOT/extensions, patch -p0 < /path/to/patchfile ---SUPERCEDES--- previous patch, requires clean checkout of extensions
Hi, Request approval for 090102 patchfile. It is a respin of the previous patchfile, but changes the following things: 1) Removes unnecessary patching of CVS header info 2) Removes the readdir_r()->readdir() hack for MacOS X instead leaving using the normal readdir_r(), now that we have it 3) Adds MacOS X specific Netscape Plug-in directories to the plug-in search path so MacOS X plugins get recognized (they can't be run yet however (?)) Should be applied to clean checkout of extensions, and then you MUST grab the extensions.052802.files.tar.gz file from Issue 5356 and then: cd $SRCROOT/extensions tar xvfz extensions.052802.files.tar.gz Dan PS - If we're not using the makefile.rc anymore, why are they still around? Does dmake automatically iterate through directories now?
Created attachment 2900 [details] Fixes static data member problem in source/dbpilots directory. Supercedes all previous patches.
The extensions.OOO_STABLE_1.091802.patch file is an update to Dan Williams' patch. This patch implements a workaround for the init-static-data-members script limitations so that the source/dbpilots directory can now be compiled on Mac OS X 10.1. The patch needs to be applied to a clean checkout of the extensions project. Please use the instructions in Dan Williams' patch to apply this patch.
Created attachment 2949 [details] Fixes static data member problem in extensions/source/preload directory
Latest patch - extensions.OOO_STABLE_1_PORTS.0923-02.patch - supercedes all earlier patches. It should be applied against a clean checkout using the following commands: cd $SRCROOT/extensions ; patch -p0 < /path/to/patch/file
Hi, completely MacOSX specific - approved Kevin
092302 patch committed to _PORTS. Dan
Changed to merge_pending. Merge: 1) extensions.OOO_STABLE_1_PORTS.092302.patch 2) Also add files from extensions/source/plugin/aqua dan
static data member stuff is no longer a problem. obsolete, closing.
.