Issue 62723 - Open Dialog "read-only" checkbox has incorrect accessibility information.
Summary: Open Dialog "read-only" checkbox has incorrect accessibility information.
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: ui (show other issues)
Version: OOo 1.0.3
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 2.0.3
Assignee: eric.savary
QA Contact: issues@framework
URL:
Keywords: accessibility
: 63980 63981 63984 63985 (view as issue list)
Depends on:
Blocks:
 
Reported: 2006-03-02 18:13 UTC by richburridge
Modified: 2006-07-18 12:27 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description richburridge 2006-03-02 18:13:39 UTC
Start up Writer. Bring up the Open dialog. Look at it
with at-poke. In particular, look at the "Read-Only"
checkbox at the bottom of the dialog. This has a
"LABELLED_BY" relationship to the File Type: combo box
which is incorrect. If that wasn't present, screen readers
such as Orca would be able to correctly use the "Read-Only"
text for the checkbox to speak/braille it's true meaning.
Comment 1 richburridge 2006-03-02 18:15:50 UTC
I really want to add a keyword of "accessibility" to this bug, but I
don't see how to do that from the web page I'm given at
http://www.openoffice.org/issues/show_bug.cgi?id=62723
Comment 2 michael.ruess 2006-03-03 07:49:39 UTC
FileOpen dialog is Framework component.
Comment 3 thorsten.martens 2006-03-30 09:23:10 UTC
TM->FS: Please have a look, thanks !
Comment 4 Frank Schönheit 2006-03-30 12:34:13 UTC
fs->pl: The Z-Order in the dialog is
- "File type" (fixed text)
- filter list (list box)
- "Read-only" (check box)

Nonetheless, the check box'es GetLabeledBy returns the fixed text. It should
return NULL, shouldn't it?
Comment 5 philipp.lohmann 2006-03-30 12:56:09 UTC
s/Z-Order/Taborder/, yes ? If so, that is not broken; a label is considered the
last FixedText, FixedLine or GroupBox in taborder before the control itself.
Whether that is a good algorithm may be debatable, but that works as designed.
This algorithm basically was decided by MT, so maybe we should discuss this with
him.
Comment 6 Frank Schönheit 2006-03-30 13:20:20 UTC
The only places which use this function are the A11Y implementations. For those
cases, the current semantics is nonsense, as it contradicts the sematics of the
A11Y LABELED_BY relationship.
So, we can either
- have the current GetLabeledBy method function in VCL, and translate its
  results in A11Y-conformant results in all A11Y implementations
OR
- fix the VCL-version of GetLabeledBy to be A11Y-conformant.

To me, the latter sounds like the better solution.
Comment 7 philipp.lohmann 2006-03-30 13:38:07 UTC
That is beside the point, what is your proposed new algorithm ? Do checkboxes
label themselves ? Do checkboxes not have labels ? What other controls should be
changed ? Remember I'm not the customer of GetLabeledBy; i can probably do a lot
as long as you come up with some requirements.
Comment 8 Frank Schönheit 2006-03-31 07:13:08 UTC
fs->mt,pl: The text in Window::GetLabeledBy currently reads:
  // search for a control that labels this window
  // a label is considered the last fixed text, fixed line or group box
  // that comes before this control; with the exception of push buttons
  // which are labeled only if the fixed text, fixed line or group box
  // is directly before the control

I could imagine the following solutions:
- what is done for buttons here should also be done for check boxes. This would
  fix this particular bug here, but does not scale to similar problems.
- A fixed text, fixed line, or group box is *only* considered a label of a
control if it
  immediately precedes the control. The idea is: if the order is "fixed text",
  "control A", "control B", then either the fixed text labels control A (but then
  most probably *not* control B, at the same time), or control A is a label control
  itself, then it labels control B.
- All places which use GetLabeledBy for A11Y relationships are modified so that
  they check that "GetLabeledBy( control )->GetLabelFor() == control" holds true.
- We explicitly implement A11Y's LABELED_BY / LABEL_FOR relationships for
  all controls in all our dialogs. Okay, just kidding.

What do you think?
Comment 9 Frank Schönheit 2006-03-31 10:22:06 UTC
fs->pl: as talked about, please discuss a better algorithm with MT. After my
vacation, I'm willing to join the discussion, if necessary :)
Comment 10 philipp.lohmann 2006-04-07 12:11:38 UTC
As per mt's decree check boxes and radio buttons do not have accessibility
labels anymore.

pl->es: please have a preliminary look at this issue; i didn't find any
problems, however i'm not an accessibility guru like you. I built linux and
windows install sets for CWS vcl57, so you can check whether this causes any
accessibility related problems.
Comment 11 philipp.lohmann 2006-04-07 12:12:22 UTC
fixed in CWS vcl57
Comment 12 malte_timmermann 2006-04-07 12:24:05 UTC
Just for clarification: My "decree" was to check how standard gnome dialogs
behave here.

So I assume that PL figured out that they don't have lables (because they are
'self labled').
Comment 13 philipp.lohmann 2006-04-13 11:58:11 UTC
please verify in CWS vcl57
Comment 14 eric.savary 2006-05-04 15:25:24 UTC
Verified in CWS vcl57
Comment 15 eric.savary 2006-05-11 10:52:31 UTC
Ok in src680m168
Comment 16 nospam4obr 2006-07-18 11:45:20 UTC
*** Issue 63984 has been marked as a duplicate of this issue. ***
Comment 17 nospam4obr 2006-07-18 12:02:18 UTC
*** Issue 63985 has been marked as a duplicate of this issue. ***
Comment 18 nospam4obr 2006-07-18 12:04:58 UTC
*** Issue 63981 has been marked as a duplicate of this issue. ***
Comment 19 nospam4obr 2006-07-18 12:27:34 UTC
*** Issue 63980 has been marked as a duplicate of this issue. ***