Issue 70388 - set a standard gtk prg name
Summary: set a standard gtk prg name
Status: CLOSED FIXED
Alias: None
Product: gsl
Classification: Code
Component: code (show other issues)
Version: OOo 2.0.4
Hardware: PC Linux, all
: P3 Trivial (vote)
Target Milestone: OOo 2.3
Assignee: eric.savary
QA Contact: issues@gsl
URL:
Keywords:
Depends on:
Blocks: 75190
  Show dependency tree
 
Reported: 2006-10-13 10:04 UTC by caolanm
Modified: 2007-07-06 18:02 UTC (History)
4 users (show)

See Also:
Issue Type: TASK
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
patch to implement (576 bytes, patch)
2006-10-13 10:04 UTC, caolanm
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description caolanm 2006-10-13 10:04:40 UTC
gtk uses g_set_prgname to set the wmname of the app, we already use
g_set_application_name to set our wmclass, similarly I'd like to use
g_set_prgname to set our wmname, otherwise the default is to use the binary name
used to launch OOo for this value.

Using g_set_prgname will make the vclplug more consistent with the traditional
one and give the same names for each plug.

I have an ulterior motive of course, this prg name is the name reported to atk
browsers as the root of the atk hierarchy, and we have a launch-time optimation
in action which creates custom swriter.bin scalc.bin binaries as well as
soffice.bin. So depending on whether OOo was originally launched as writer or
calc the name of the atk hierarchy is different for us, and I'd like to keep my
launch optimizaion but also have the same name here regardless of the binary
name used to launch OOo.
Comment 1 caolanm 2006-10-13 10:04:58 UTC
Created attachment 39723 [details]
patch to implement
Comment 2 philipp.lohmann 2006-10-13 13:30:07 UTC
committed in CWS vcl68
Comment 3 philipp.lohmann 2006-10-13 13:31:54 UTC
target
Comment 4 philipp.lohmann 2006-10-18 17:29:05 UTC
please verify in CWS vcl68
Comment 5 caolanm 2006-10-18 17:36:45 UTC
verified
Comment 6 caolanm 2006-11-24 11:32:14 UTC
seen in m194
Comment 7 nospam4obr 2006-12-01 10:10:55 UTC
The patch has been revoked from OOo 2.1 (branch OOE680) due to issue 72116.
Comment 8 nospam4obr 2007-01-22 08:48:54 UTC
Changes reverted due to issue 72116.
Comment 9 nospam4obr 2007-01-22 08:50:04 UTC
Need to investigate further how to deal with this. Sorry.
Comment 10 nospam4obr 2007-01-22 08:50:40 UTC
.
Comment 11 nospam4obr 2007-01-29 08:53:39 UTC
2.2.1 target needs approval.
Comment 12 nospam4obr 2007-03-16 12:05:55 UTC
Fixed this by mapping g_get_prgname to Application::GetAppName (after moving the
initialization of the later before SVMain() get actually called).

As a result, the application name reported to atk browsers will be "soffice" as
soon as CWS atkbridge6 gets integrated (probably OOo 2.3).

If consistency to the generic plugin is important, I propose to change the
string there, as AppName seems to fit nicely to how glib prgname is specified.
Comment 13 nospam4obr 2007-05-15 08:37:22 UTC
@es: please verify in CWS atkbridge6.
Comment 14 eric.savary 2007-05-18 14:34:35 UTC
Verified in CWS atkbridge
Comment 15 eric.savary 2007-07-06 18:02:17 UTC
Ok in m219