Issue 7197 - OOO_STABLE_1/X11: printer setup dialog does not show
Summary: OOO_STABLE_1/X11: printer setup dialog does not show
Status: CLOSED FIXED
Alias: None
Product: porting
Classification: Code
Component: code (show other issues)
Version: OOo 1.0.1
Hardware: Mac Mac OS X, all
: P3 Trivial (vote)
Target Milestone: ---
Assignee: ed
QA Contact: issues@porting
URL:
Keywords: merge_pending
Depends on: 5880
Blocks:
  Show dependency tree
 
Reported: 2002-08-23 01:27 UTC by fa
Modified: 2004-03-25 07:38 UTC (History)
3 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
cd SRC_ROOT/vcl, patch -p0 < /path/to/patchfile then recompile and deliver vcl (6.43 KB, patch)
2002-08-23 01:29 UTC, fa 		no flags Details | Diff
cd SRC_ROOT/vcl, patch -p0 < /path/to/patchfile then recompile and deliver vcl (5.74 KB, patch)
2002-08-23 16:25 UTC, fa 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description fa 2002-08-23 01:27:57 UTC 
Because of the schedule of getting printing code in, getting the printer setup dialog to 
come up when choosing File->Print->Properties was punted.

This patch changes the dlopen() calls to oslLoadModule() calls in vcl/unx/source/gdi/
salprn.cxx and vcl/unx/source/gdi/salprnpsp.cxx and allows the libspa641mxp.dylib 
library to be loaded and display the printer setup dialog box.

Dan
Comment 1 fa 2002-08-23 01:29:15 UTC 
Created attachment 2579 [details]
cd SRC_ROOT/vcl, patch -p0 < /path/to/patchfile  then recompile and deliver vcl
Comment 2 fa 2002-08-23 01:32:01 UTC 
Please disregard the CVS header line patch in the source, I had to diff 
OOO_STABLE_1 against OOO_STABLE_1_PORTS and clear out the CVS 
crap.

Approval requested.

Thanks,
Dan
Comment 3 fa 2002-08-23 01:33:11 UTC 
I believe this patch depends on Issue 5880 and while it does not directly 
depend on _code_ from Issue 5880, you will get fuzz if you haven't applied 
5880 first.

dan
Comment 4 jens-heiner.rechtien 2002-08-23 10:29:29 UTC 
Approved.

removed keyword: apporval_pending
Comment 5 fa 2002-08-23 16:25:20 UTC 
Created attachment 2584 [details]
cd SRC_ROOT/vcl, patch -p0 < /path/to/patchfile   then recompile and deliver vcl
Comment 6 fa 2002-08-23 16:29:56 UTC 
Hi,

082302 patchfile is a diff against OOO_STABLE_1_PORTS and is free of 
CVS junk in the patch.  Rediff courtesy of asxless.  I tested on a 
checkout of OOO_STABLE_1_PORTS and patch applies cleanly (extra CRs 
on lines however, beause of Win32).

I don't think a reapproval is necessary.  This 082302 patch file 
REPLACES the 082202 patchfile.

Dan
Comment 7 ed 2002-09-01 21:09:30 UTC 
committed to OOO_STABLE_1_PORTS, added keyword 
merge_pending
Comment 8 Martin Hollmichel 2004-03-25 07:38:04 UTC 
close issue.