Apache OpenOffice (AOO) Bugzilla – Issue 73426
new chart: wrong help context after switching from help window back to chart wizard
Last modified: 2008-05-16 03:34:14 UTC
-Use the new chart in current status from CWS chart2mst3. -Start the Office with environment variable HELP_DEBUG set to true thus you can see the help context and help ids -Open a calc document -Insert some data -Choose Insert chart from toolbar -In the chart wizard click Shift - F1 on any ui element -> the yellow flyer shows the help context 'schart' as it should be. -Open the Help with F1 -switch back to the chart wizard with Alt - Tab -press Shift - F1 while having the mouse on any other! ui element in the wizard (don't use the same control as before as the values seem to be cached somewhere) --> The indicated context for the help now is scalc - what is wrong The error occurs because the formerly active child frame (chart) of the calc is set to null when switching back from help window to calc document window: framework/source/services/frame.cxx v 1.99 method Frame::setActiveFrame line 598 Adding the condition xFrame.is() to the if statement in line 595 does solve the problem. But I am not sure whther this has negative side effects as the comment in the line above explicitely allows xFrame==NULL. Could you please check? Thanks a lot.
Created attachment 42126 [details] proposed patch
No, unfortunately that would introduce an even more severe bug. The code is right here: setActiveFrame(NULL) should deactivate the currently active child frame. The real culprit is that calling setActiveFrame(NULL) is wrong here. I assume that this is a duplicate of issue 71484. As this issue will be fixed in OOo2.2 we can verify my assumption when the new Chart will be available on the master or when chart2mst3 has been resynced.
AS->IHA: Can you please check if changes made by MBA on cws fwk58 (not integrated into the master yet) fix your problems ? Here the diff .... If it doesnt fix your problems ... please send this task back to me so we can find another solution. Regards Andreas =================================================================== RCS file: /cvs/framework/sfx2/source/view/sfxbasecontroller.cxx,v retrieving revision 1.69 retrieving revision 1.69.44.1 diff -r1.69 -r1.69.44.1 7c7 < * $Revision: 1.69 $ --- > * $Revision: 1.69.44.1 $ 9c9 < * last change: $Author: vg $ $Date: 2006/11/01 18:29:14 $ --- > * last change: $Author: mba $ $Date: 2006/12/06 15:36:14 $ 582c582,583 < m_pController->GetViewShell_Impl()->GetViewFrame()->MakeActive_Impl( FALSE ); --- > if ( !m_pController->GetViewShell_Impl()->GetUIActiveIPClient_Impl() ) > m_pController->GetViewShell_Impl()->GetViewFrame()->MakeActive_Impl( FALSE );
IHA->AS: Thanks for the fast response :-). Unfortunately the above changes do not solve my problem but I tried a third solution be removing that wrong call setActiveFrame(NULL) indicated by MBAs comment.That solves my problem. Could you check again whther this does not break something else. I'll attach a new diff. Thanks a lot.
Created attachment 42164 [details] revised patch proposal
IHA->AS: Thanks for your hint on the phone. The problem is in the chart code (indeed the dialog parent was not set correctly). So no need to touch framework code. I take this one back then.
fixed
changed target to 2.3
Fixed in CWS chart2mst3 Milestone 10_3. Please verify.
verified
This Issue is 'Verified' and not updated in 1yr+, so Closing. A Closed Issue is a Happy Issue (TM). Regards, Andrew Cleaning-up and Closing old Issues as part of: ~ The Grand Bug Squash, pre v3 ~