Issue 73576 - [a11y] Save As Encoded Text throws up a dialog that is not properly spoken
Summary: [a11y] Save As Encoded Text throws up a dialog that is not properly spoken
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: ui (show other issues)
Version: OOo 2.1
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: eric.savary
QA Contact: issues@sw
URL:
Keywords: accessibility
Depends on:
Blocks: 90510
  Show dependency tree
 
Reported: 2007-01-17 18:35 UTC by richburridge
Modified: 2013-08-07 14:43 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description richburridge 2007-01-17 18:35:18 UTC
See also Orca bug #397680, which is blocked by this problem.
http://bugzilla.gnome.org/show_bug.cgi?id=397680

As reported by Krister on the Orca mailing list:

"I was trying to save a file in formated text format and wanted to edit
my ascii filter settings to make sure I could edit the file from
Windows, so I checked the "edit filter settings" check box in the "save
as" dialog in OpenOffice and pressed "OK". The edit filter settings came
up and I tried to choose the correct character set, namely Windows and
was surpriced when i couldn't see any character set at all. Pressing the
down arrow didn't produce neither speech nor braille. This has worked
before."

The problem is that there is another OOo dialog
coming up before the ASCII Filter Options dialog.

It's something like:

  This document may contain formatting or content that cannot be
  saved in the Text Encoded file format. Do you wish to save the
  document in this format anyway?

There are Yes and No buttons and a "Do not show this warning
again" checkbox.

Unfortunately the text for this dialog is not being spoken.
When it first comes up it just tells you the focus is on the
No button.

We investigated this problem. What we saw was that there is
single label on that dialog which has a LABEL_FOR relationship
with the "Yes" button. Neither the "Yes" button or the "No"
button have a LABELLED_BY relationship with that label.

In Orca, in speechgenerator.py, the _getSpeechForDialog() method calls
_getSpeechForAlert(), which in turn calls util.findUnrelatedLabels().
Because that label has a LABEL_FOR relationship, it's ignored.

Two possible solutions:

1/ Just remove the LABEL_FOR relationship from that label.
2/ Add LABELLED_BY relationships for the "Yes" and "No" buttons
   to that label.
Comment 1 eric.savary 2007-01-18 10:58:49 UTC
ES->OBR: quite a general proble of fixed texts message boxes.
Comment 2 nospam4obr 2007-01-18 15:09:45 UTC
not a bridging issue.
Comment 3 Oliver Specht 2007-01-19 14:33:49 UTC
Reassigned to PB
Comment 4 pb 2007-02-05 08:43:19 UTC
pb: accepted.
Comment 5 Mathias_Bauer 2007-12-04 13:30:33 UTC
target 3.0
Comment 6 pb 2008-04-14 14:16:47 UTC
pb: fixed in cws fwk86. I removed the LABEL_FOR relationship from the FixedText.
Files changed:
/sfx2/source/dialog/alienwarn.cxx 1.10.20.1
Comment 7 pb 2008-04-21 06:15:34 UTC
pb -> es: please verify. Thx.
Comment 8 eric.savary 2008-05-07 13:11:45 UTC
Fixed but failed.

The Warning is still not read. Only the buttons and the check box.

On the other hand, at-poke only sees the dialog as:

> OpenOffice.org 3.0 Beta | Dialog | <no_description>
         > <no_name> | icon | <no_description>

No reference to the text, buttons and check box...
Comment 9 pb 2008-05-08 11:42:59 UTC
pb: back to me.
Comment 10 pb 2008-06-24 06:12:11 UTC
pb: now fixed in cws pba11y01.
Files changed:
/sfx2/source/inc/alienwarn.hxx 1.7.70.1
/sfx2/source/dialog/alienwarn.cxx 1.12.36.1
Comment 11 pb 2008-07-16 13:14:17 UTC
pb -> es: please verify. Thx.
Comment 12 eric.savary 2008-07-16 16:11:06 UTC
Verified in CWS pba11y01
Comment 13 sgautier.ooo 2009-01-02 13:44:39 UTC
Verified in OOo 3.0 and Orca, the first dialog about formatting is read
correctly and gives all the informations about buttons and check box. Closing -
Sophie