Issue 7453 - OOO_STABLE_1_PORTS/X11: vcl print code incorrectly deallocates driver data
Summary: OOO_STABLE_1_PORTS/X11: vcl print code incorrectly deallocates driver data
Status: CLOSED DUPLICATE of issue 8012
Alias: None
Product: porting
Classification: Code
Component: code (show other issues)
Version: OOo 1.0.1
Hardware: All All
: P2 Trivial (vote)
Target Milestone: OOo 1.0.4
Assignee: ed
QA Contact: issues@porting
URL:
Keywords: merge_pending
Depends on:
Blocks: 8607
  Show dependency tree
 
Reported: 2002-09-02 22:15 UTC by fa
Modified: 2004-03-25 07:39 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
cd to SRC_ROOT/vcl, patch -p0 < /path/to/patchfile, rebuild vcl (597 bytes, patch)
2002-09-02 22:16 UTC, fa 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description fa 2002-09-02 22:15:25 UTC 
Patch should explain it all.  The data is rtl_freeMemory()d and in creation the member variable is always new'ed, so it should be delete'd instead.

This caused a repeatable SEGFAULT on MacOS X printing.

Dan
Comment 1 fa 2002-09-02 22:16:06 UTC 
Created attachment 2689 [details]
cd to SRC_ROOT/vcl, patch -p0 < /path/to/patchfile, rebuild vcl
Comment 2 fa 2002-09-02 22:16:40 UTC 
Requesting approval for the 083102 patch.

Dan
Comment 3 fa 2002-09-03 15:39:37 UTC 
Approved by Sander...  Ed, commit to OOO_STABLE_1_PORTS?

---------------------------------------
Date: Tue, 3 Sep 2002 14:18:46 +0100 
(BST)                                      
From: Sander Vesik 
<Sander.Vesik@Sun.COM>                                       
Reply-To: 
dev@porting.openoffice.org                                           
 
To: 
dev@porting.openoffice.org                                           
       
Subject: Re: [porting-dev] Approval request for 
7453                            
           
On Mon, 2 Sep 2002, Dan Williams 
wrote:                                         
> Approval request for issue 
7453.                                              
>                                                                    
> http://www.openoffice.org/issues/show_bug.cgi?
id=7453                         
>                                                                    
> free() versus delete 
problem.                                                 
           
approved                                                             

> 
Dan
Comment 4 ed 2002-10-12 14:25:12 UTC 
Committed to PORTS.  Added keyword merge_pending
Comment 5 khendricks 2003-04-17 01:18:45 UTC 
Hi Dan, 
 
I think this should be an array delete and not a non-array delete  
(at least on OOo 1.0.3 it is an array delete). 
 
Kevin
Comment 6 fa 2003-04-17 02:22:44 UTC 
Kevin,

Correct, it should be.  This issue (and the patch) were superceded by Issue 8012, 
which includes the correct delete[] code.

http://www.openoffice.org/project/www/issues/show_bug.cgi?id=8012

I'm going to mark this issue as Resolved Fixed.

Dan
Comment 7 fa 2003-04-17 02:23:20 UTC 
Superceded by Issue 8012.

*** This issue has been marked as a duplicate of 8012 ***
Comment 8 Martin Hollmichel 2004-03-25 07:39:18 UTC 
close issue.