Issue 75058 - New Chart: crash changing the data range manually
Summary: New Chart: crash changing the data range manually
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: editing (show other issues)
Version: 680m202
Hardware: All All
: P2 Trivial (vote)
Target Milestone: ---
Assignee: michael.ruess
QA Contact: issues@sw
URL:
Keywords: new_implementation
Depends on:
Blocks:
 
Reported: 2007-03-02 12:06 UTC by michael.ruess
Modified: 2013-08-07 14:42 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
document to reproduce (13.39 KB, application/vnd.oasis.opendocument.text)
2007-03-02 12:41 UTC, michael.ruess 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description michael.ruess 2007-03-02 12:08:14 UTC 
take attached sample, activate the Chart, in Format.Data Ranges.Data Series
change the range for Col1 in Categories field from e.g. Table1.A2:A5 to
Table1.A2:A6 via keyboard input -> crash
Comment 1 bjoern.milcke 2007-03-02 12:38:44 UTC 
The crash happens, whenever you enter an invalid range in a text field.

What happens is that the validity of the range is checked via the
sheet::XCellRangeAccess interface. If this interface is not available (as in
Writer) it is assumed that the range is correct.

1. in chart we need to change the check so that it finds out reliably if a range
is correct in Writer.
2. in SwChartDataProvider::createDataSequenceByRangeRepresentation() show always
throw an IllegalArgumentException when an invalid range is entered, and no
RuntimeException.
Comment 2 michael.ruess 2007-03-02 12:41:54 UTC 
Created attachment 43484 [details]
document to reproduce
Comment 3 bjoern.milcke 2007-03-02 12:45:13 UTC 
Accepting.
Comment 4 bjoern.milcke 2007-03-02 12:46:33 UTC 
Type changed, keyword added.
Comment 5 bjoern.milcke 2007-03-02 14:01:41 UTC 
Fixed in sw, sc and chart2.
Comment 6 bjoern.milcke 2007-03-07 10:55:47 UTC 
->MRU: Please verify in CWS chart2mst3.

Note, that unless Issue 75179 is fixed, an invalid text in the edit field has
white text on white background on Linux, i.e. you don't see the text in that case.

(You get invalid text when you delete the "5" in your example to replace it by a
"6"., that's what causes the crash)
Comment 7 michael.ruess 2007-03-09 15:17:33 UTC 
Verified in latest build.
Comment 8 michael.ruess 2007-03-27 09:36:44 UTC 
Reopening issue. Crash re-occurs in build mst12.
Comment 9 michael.ruess 2007-03-27 09:40:31 UTC 
MRU->BM: in latest build (installed March 27th), crash occurs again. When having
e.g. a table with size A1:E6, and then changing the data range in the according
chart to A1:E7 e.g. OOo will crash.
Comment 10 bjoern.milcke 2007-03-27 09:54:39 UTC 
In XDataProvider::createDataSource of the Writer data provider an array was
accessed unchecked. Fixed by throwing an IllegalArgumentException when the range
entered was too large for the table.
Comment 11 bjoern.milcke 2007-03-27 15:30:26 UTC 
The crash is fixed. Note, however, that an invalid range is not shown with a red
box. An invalid input is ignored and the last valid one is used as data.

The fix for the latter problem seems too risky at the moment.

Please verify in CWS chart2mst3.
Comment 12 bjoern.milcke 2007-03-27 15:38:20 UTC 
As this task came back from testing with an error it is now a defect
Comment 13 michael.ruess 2007-03-28 14:50:55 UTC 
Verified in CWS chart2mst3.
Comment 14 michael.ruess 2007-07-26 13:08:35 UTC 
Checked in 680m222.