Issue 75228 - aquavcl01: WaE for vcl/aqua/source/app/saltimer.cxx
Summary: aquavcl01: WaE for vcl/aqua/source/app/saltimer.cxx
Status: CLOSED FIXED
Alias: None
Product: porting
Classification: Code
Component: MacOSX (show other issues)
Version: 680m205
Hardware: All Mac OS X, all
: P3 Trivial (vote)
Target Milestone: OOo 2.3
Assignee: pavel
QA Contact: issues@porting
URL:
Keywords: aqua
: 77570 (view as issue list)
Depends on:
Blocks:
 
Reported: 2007-03-08 11:50 UTC by pavel
Modified: 2007-07-09 22:41 UTC (History)
6 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Rewrite SalTimer (7.37 KB, patch)
2007-03-08 19:44 UTC, pavel 		no flags Details | Diff
new patch ( the previous one does not apply anymore) (7.47 KB, patch)
2007-05-08 15:29 UTC, eric.bachard 		no flags Details | Diff
thrid patch (6.77 KB, patch)
2007-06-14 03:14 UTC, philipp.lohmann 		no flags Details | Diff
the same a unified diff (7.75 KB, patch)
2007-06-14 14:11 UTC, philipp.lohmann 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description pavel 2007-03-08 11:50:57 UTC 
The current aquavcl01's file vcl/aqua/source/app/saltimer.cxx is using deprecated API:

/Users/pavel/BUILD/AQUA/BuildDir/ooo_SRC680_m202_src/vcl/aqua/source/app/saltimer.cxx: In 
destructor 'virtual AquaSalTimer::~AquaSalTimer()':
/Users/pavel/BUILD/AQUA/BuildDir/ooo_SRC680_m202_src/vcl/aqua/source/app/saltimer.cxx:104: 
warning: 'RemoveTimeTask' is deprecated (declared at /System/Library/Frameworks/
CoreServices.framework/Frameworks/CarbonCore.framework/Headers/Timer.h:392)
/Users/pavel/BUILD/AQUA/BuildDir/ooo_SRC680_m202_src/vcl/aqua/source/app/saltimer.cxx:104: 
warning: 'RemoveTimeTask' is deprecated (declared at /System/Library/Frameworks/
CoreServices.framework/Frameworks/CarbonCore.framework/Headers/Timer.h:392)
/Users/pavel/BUILD/AQUA/BuildDir/ooo_SRC680_m202_src/vcl/aqua/source/app/saltimer.cxx: In 
member function 'virtual void AquaSalTimer::Start(ULONG)':
/Users/pavel/BUILD/AQUA/BuildDir/ooo_SRC680_m202_src/vcl/aqua/source/app/saltimer.cxx:114: 
warning: 'RemoveTimeTask' is deprecated (declared at /System/Library/Frameworks/
CoreServices.framework/Frameworks/CarbonCore.framework/Headers/Timer.h:392)
/Users/pavel/BUILD/AQUA/BuildDir/ooo_SRC680_m202_src/vcl/aqua/source/app/saltimer.cxx:114: 
warning: 'RemoveTimeTask' is deprecated (declared at /System/Library/Frameworks/
CoreServices.framework/Frameworks/CarbonCore.framework/Headers/Timer.h:392)
/Users/pavel/BUILD/AQUA/BuildDir/ooo_SRC680_m202_src/vcl/aqua/source/app/saltimer.cxx:124: 
warning: 'PrimeTimeTask' is deprecated (declared at /System/Library/Frameworks/
CoreServices.framework/Frameworks/CarbonCore.framework/Headers/Timer.h:344)
/Users/pavel/BUILD/AQUA/BuildDir/ooo_SRC680_m202_src/vcl/aqua/source/app/saltimer.cxx:124: 
warning: 'PrimeTimeTask' is deprecated (declared at /System/Library/Frameworks/
CoreServices.framework/Frameworks/CarbonCore.framework/Headers/Timer.h:344)
/Users/pavel/BUILD/AQUA/BuildDir/ooo_SRC680_m202_src/vcl/aqua/source/app/saltimer.cxx: In 
member function 'void AquaSalTimer::ReStart(ULONG)':
/Users/pavel/BUILD/AQUA/BuildDir/ooo_SRC680_m202_src/vcl/aqua/source/app/saltimer.cxx:131: 
warning: 'PrimeTimeTask' is deprecated (declared at /System/Library/Frameworks/
CoreServices.framework/Frameworks/CarbonCore.framework/Headers/Timer.h:344)
/Users/pavel/BUILD/AQUA/BuildDir/ooo_SRC680_m202_src/vcl/aqua/source/app/saltimer.cxx:131: 
warning: 'PrimeTimeTask' is deprecated (declared at /System/Library/Frameworks/
CoreServices.framework/Frameworks/CarbonCore.framework/Headers/Timer.h:344)
/Users/pavel/BUILD/AQUA/BuildDir/ooo_SRC680_m202_src/vcl/aqua/source/app/saltimer.cxx: In 
member function 'virtual void AquaSalTimer::Stop()':
/Users/pavel/BUILD/AQUA/BuildDir/ooo_SRC680_m202_src/vcl/aqua/source/app/saltimer.cxx:138: 
warning: 'RemoveTimeTask' is deprecated (declared at /System/Library/Frameworks/
CoreServices.framework/Frameworks/CarbonCore.framework/Headers/Timer.h:392)
/Users/pavel/BUILD/AQUA/BuildDir/ooo_SRC680_m202_src/vcl/aqua/source/app/saltimer.cxx:138: 
warning: 'RemoveTimeTask' is deprecated (declared at /System/Library/Frameworks/
CoreServices.framework/Frameworks/CarbonCore.framework/Headers/Timer.h:392)
/Users/pavel/BUILD/AQUA/BuildDir/ooo_SRC680_m202_src/vcl/aqua/source/app/saltimer.cxx: In 
member function 'BOOL AquaSalTimer::InstallTask()':
/Users/pavel/BUILD/AQUA/BuildDir/ooo_SRC680_m202_src/vcl/aqua/source/app/saltimer.cxx:148: 
warning: 'InstallTimeTask' is deprecated (declared at /System/Library/Frameworks/
CoreServices.framework/Frameworks/CarbonCore.framework/Headers/Timer.h:229)
/Users/pavel/BUILD/AQUA/BuildDir/ooo_SRC680_m202_src/vcl/aqua/source/app/saltimer.cxx:148: 
warning: 'InstallTimeTask' is deprecated (declared at /System/Library/Frameworks/
CoreServices.framework/Frameworks/CarbonCore.framework/Headers/Timer.h:229)
dmake:  Error code 1, while making '../../../unxmacxi/slo/saltimer.obj'

Port it to newer API.
Comment 1 pavel 2007-03-08 19:43:40 UTC 
The attached patch migrates the AquaSalTimer into Carbon Event loop timer events.

I'd be glad if you can review it.
Comment 2 pavel 2007-03-08 19:44:29 UTC 
Created attachment 43603 [details]
Rewrite SalTimer
Comment 3 pavel 2007-03-08 20:15:31 UTC 
Hmm, there is some problem there, because sometimes, it crashes when quiting in 
ImplSalYieldMutexAcquire
Comment 4 stx123 2007-03-26 13:01:26 UTC 
Hi Pavel, who do you expect to review the patch?
Comment 5 pavel 2007-03-26 13:05:11 UTC 
yes, we are working on it ;-)
Comment 6 eric.bachard 2007-05-08 15:29:29 UTC 
Created attachment 44939 [details]
new patch ( the previous one does not apply anymore)
Comment 7 eric.bachard 2007-05-19 08:38:49 UTC 
*** Issue 77570 has been marked as a duplicate of this issue. ***
Comment 8 philipp.lohmann 2007-06-14 03:14:16 UTC 
Created attachment 45890 [details]
thrid patch
Comment 9 philipp.lohmann 2007-06-14 03:14:48 UTC 
Seems to work nicely for me ? Attached a renewed patch
Comment 10 pavel 2007-06-14 09:38:37 UTC 
pl: -u please.
Comment 11 philipp.lohmann 2007-06-14 14:11:28 UTC 
Created attachment 45912 [details]
the same a unified diff
Comment 12 pavel 2007-06-15 18:27:37 UTC 
pl: works here OK.
Comment 13 philipp.lohmann 2007-06-15 18:35:27 UTC 
pjanik: question, what's the FIXME mean at the end ? What problem is there still ?
Comment 14 pavel 2007-06-15 18:40:21 UTC 
I think you can safely remove it. I do not remember why I put it there 8)
Comment 15 philipp.lohmann 2007-06-15 18:50:46 UTC 
committed
Comment 16 pavel 2007-06-20 13:20:00 UTC 
no warnings there now -> verified.

If there are small problems, new issues please :-)
Comment 17 pavel 2007-06-28 07:03:11 UTC 
Change target milestone to 2.3.
Comment 18 pavel 2007-07-09 22:09:43 UTC 
VCL is still WaE clean on SRC680_220.

Closing.
Comment 19 eric.bachard 2007-07-09 22:41:34 UTC 
Still ok in SRC680_m220 

Closing