Issue 76926 - [a11y] Check menu items should have a role of ROLE_CHECK_MENU_ITEM
Summary: [a11y] Check menu items should have a role of ROLE_CHECK_MENU_ITEM
Status: CLOSED WONT_FIX
Alias: None
Product: General
Classification: Code
Component: ui (show other issues)
Version: OOo 2.2 RC4
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 3.0
Assignee: richburridge
QA Contact: issues@framework
URL:
Keywords: accessibility
Depends on:
Blocks:
 
Reported: 2007-05-03 19:39 UTC by richburridge
Modified: 2008-10-27 14:10 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description richburridge 2007-05-03 19:39:42 UTC 
See also Orca bug #433398 which was affected by this.
http://bugzilla.gnome.org/show_bug.cgi?id=433398

There are various menu items in Calc (and probably other
OOo applications that can have either a checked or an
unchecked state. Calc->Window->Freeze is one such example.
Currently those menu items have a role of ROLE_MENU_ITEM.
Looking in the at-spi IDL Accessibility_Role.idl file,
they should really be of role ROLE_CHECK_MENU_ITEM.
Comment 1 eric.savary 2007-05-04 14:45:07 UTC 
@richburridge: does this mean in Orca that the Braille display should show, for
instance:

"Freeze < > chk"
Or
"Freeze <x> chk"

while it now only shows "Freeze", right?

Compare with gedit: View - Toolbar is shown "Toolbar <x> chk"

@OBR: this concerns all check menus in OOo.
Comment 2 eric.savary 2007-05-04 14:47:21 UTC 
Changed component.
Set A11y keyword.
Comment 3 richburridge 2007-05-04 15:12:12 UTC 
@es: correct. I added a "hack" into Orca yesterday that looks
to see if an object of role ROLE_MENU_ITEM has a CHECKED state
(see Orca bug http://bugzilla.gnome.org/show_bug.cgi?id=433398),
so the "<x>" is now appearing on the braille display, but even
with that change, I'm unable to set "< >" (i.e. unchecked) for
when it's not in a CHECKED state. Those checkable menu items
really need to have a role of ROLE_CHECK_MENU_ITEM. Thanks.
Comment 4 nospam4obr 2007-05-04 15:50:25 UTC 
re-assigned.
Comment 5 thomas.benisch 2007-07-06 15:36:30 UTC 
The vcl API offers only the methods

void Menu::CheckItem( USHORT nItemId, BOOL bCheck = TRUE )
BOOL Menu::IsItemChecked( USHORT nItemId ) const

The question is, how can we access the information that a menu item
is checkable, especially if this functionality is added by sfx.

TBE->MT: As discussed, please clarify.
Comment 6 Mathias_Bauer 2007-12-04 16:25:43 UTC 
target 3.0
Comment 7 malte_timmermann 2008-03-18 17:19:41 UTC 
mt->richburridge

Discussed this with Will at CSUN.

OOo/VCL doesn't have a role for "checkable", since any menu item can be checked,
just by calling SetChecked( BOOL ).

Having this role shouldn't be important, because Orca only has to figure out if
a menu item is checked, and then read this state.
A seeing user also doesn't see a difference between a checkable and a non
checkable item. He chooses the item, and the app checks it our not.

Orca already handles this correctly, no reason to change something in OOo
Comment 8 malte_timmermann 2008-03-18 17:20:17 UTC 
Back to richburridge
Comment 9 eric.savary 2008-10-27 14:10:13 UTC 
Closing