Issue 77592 - Use of the Mac OS X spell checker
Summary: Use of the Mac OS X spell checker
Status: CLOSED FIXED
Alias: None
Product: porting
Classification: Code
Component: MacOSX (show other issues)
Version: 680m226
Hardware: Mac Mac OS X, all
: P3 Trivial (vote)
Target Milestone: OOo 2.4
Assignee: jogi
QA Contact: issues@porting
URL: http://specs.openoffice.org/appwide/l...
Keywords: aqua
Depends on:
Blocks:
 
Reported: 2007-05-19 04:27 UTC by msicotte
Modified: 2007-10-09 06:16 UTC (History)
5 users (show)

See Also:
Issue Type: FEATURE
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
Update to macosx_spellchecker spec - Sep 7, 2007 (95.03 KB, text/plain)
2007-09-07 22:14 UTC, msicotte
no flags Details
Test document for spell checking (13.10 KB, application/vnd.oasis.opendocument.text)
2007-09-09 15:49 UTC, msicotte
no flags Details
log of IRC discussion TL-ericb re spellchecker review (13.73 KB, text/rtf)
2007-09-11 14:57 UTC, msicotte
no flags Details
not authoritative list of spelling locales found on one Mac OS X system (303 bytes, text/plain)
2007-09-11 15:28 UTC, msicotte
no flags Details
test case specification (4.82 KB, text/html)
2007-09-13 17:34 UTC, jogi
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description msicotte 2007-05-19 04:27:08 UTC
Use of the Mac OS X spell checker
Comment 1 msicotte 2007-05-19 04:27:31 UTC
keyword
Comment 2 shaunmcdonald131 2007-05-19 09:25:51 UTC
Personally I prefer the current behaviour of the OpenOffice.org spell checker to
the Mac OS X system wide spell checker. With the current implementation of the
Mac OS X sell checker, if you correct one word through a right click, suddenly
all the other red underlines in the text disappear. 
Comment 3 shaunmcdonald131 2007-05-19 09:28:27 UTC
Personally I prefer the current behaviour of the OpenOffice.org spell checker to
the Mac OS X system wide spell checker. With the current implementation of the
Mac OS X sell checker, if you correct one word through a right click, suddenly
all the other red underlines in the text disappear. 
Comment 4 pavel 2007-06-20 13:22:34 UTC
This is new feature request.

Any volunteers?
Comment 5 msicotte 2007-06-22 16:34:20 UTC
Using the Cocoa spell check functionality in a Carbon application is an example
Apple has used for Cocoa-Carbon integration.  See:
http://developer.apple.com/documentation/Cocoa/Conceptual/CarbonCocoaDoc/Articles/CocoaInCarbon.html#//apple_ref/doc/uid/20002402-TP1

First step - make sure there is an acceptable way to use Cocoa in OOo macport.
Comment 6 msicotte 2007-06-29 03:15:37 UTC
I contacted one of the original implementers of spell check on OOO and he
offered this advice:

If you look at the lingucomponent module that includes with Hunspell, you can
see how almost any spellchecker can be interfaced.  Simply copy the module and
use it as a model for interfacing to the MacOSX daemon.  The interface is what
you would expect.  It can register itself (so that users can enable or disable
that spellchecker), it gets called with a Unicode word and is asked to either 
spellcheck it or make a suggestion, etc.  There really isn't much to the
interface, all of the real work is done by the spellchecker itself.
Comment 7 msicotte 2007-06-29 03:16:50 UTC
.
Comment 8 msicotte 2007-08-28 06:41:00 UTC
CWS macosxspellchecker has been created with code to implement the spellchecker.
 I have tested en-US and fr, others are invited to test.

Please note:  If you do not do a full build you need to register the
libspell680mxi.dylib with regcomp for the MacSpellChecker class to be recognized.

Comment 9 eric.bachard 2007-08-28 13:59:09 UTC
Michael,

I have tested the fr version locally, and everything is ok. I have floowe your
progress with the code, and that's fine too ( a review is needed, anyway).
But as new feature, I fear they are "papers" to be created, with some ...
administrative stuff. 
The only wish I have is use the Mac OS X Dictionnary.

Last but not least: congratulations for your work :-)
 
P.S. : I now see why I did not receive the notification for the cws:
eric.bachard@free.fr is not the good email to be used. Can you please change for
ericb@openoffice.org ?  Thanks :-)



Comment 10 eric.bachard 2007-08-28 14:00:26 UTC
s/floowe/followed/ 

sorry
Comment 11 msicotte 2007-08-29 04:56:10 UTC
The cws has been updated, scp2 added, to deliver a separate dylib
"libmacosxspell680mxi.dylib", implementing the Mac OS X SpellChecker
functionality.  I am sure there are many things yet to correct, but its
basically working.
Comment 12 eric.bachard 2007-09-05 13:51:01 UTC
ericb->mikesic : can we consider the issue as fixed in macosxspellchecker cws ?
( urgent for integration )
Comment 13 jogi 2007-09-05 14:18:53 UTC
added spec draft link
Comment 14 msicotte 2007-09-05 21:27:10 UTC
No problems reported from version August 29, 2007 until today - Sep 5, 2007
Comment 15 eric.bachard 2007-09-06 09:19:09 UTC
ericb->msicotte

To avoid missing the deadline for Barcelone, I suggest you to set
macosxspellchecker as Ready for QA. 
Jogi told me the specs are on the way.
Comment 16 jogi 2007-09-06 09:43:17 UTC
I have added the reviewd specification to the CVS; I have added ericb as iTeam
lead, mmp as UX man and TL as development member (review). Please feel free to
add your comments. (Enable red lining, please that msicotte is able to accept or
reject the changes!)

msicotte, after we get the OK from the rest of the i-Team, you could add or
reject the changes to the document under Edit / Changes / 'Accept or reject'
Comment 17 jogi 2007-09-06 10:13:11 UTC
put the information on http://specs.openoffice.org/appwide/index.html
Comment 18 matthias.mueller-prove 2007-09-06 11:03:17 UTC
UX and string review done.
Spec updated
-> Please add a space to "SpellChecker". 
Comment 19 msicotte 2007-09-07 22:13:08 UTC
Spec updated to match startup behavior.  Attached - sorry but I don't yet know
how to update it on the web site.
A space added to make display name "Mac OS X Spell Checker". 
Comment 20 msicotte 2007-09-07 22:14:33 UTC
Created attachment 48059 [details]
Update to macosx_spellchecker spec - Sep 7, 2007
Comment 21 msicotte 2007-09-09 15:48:27 UTC
I found a test document (Samples_All_Languages.odt) on the OOo wiki with
mis-spellings in many languages.  I am attaching it here are an aid to testing.
Comment 22 msicotte 2007-09-09 15:49:37 UTC
Created attachment 48085 [details]
Test document for spell checking
Comment 23 msicotte 2007-09-11 14:57:44 UTC
Created attachment 48180 [details]
log of IRC discussion TL-ericb re spellchecker review
Comment 24 msicotte 2007-09-11 15:28:46 UTC
Created attachment 48182 [details]
not authoritative list of spelling locales found on one Mac OS X system
Comment 25 jogi 2007-09-13 10:20:29 UTC
please assign the issue to "jsi"
Comment 26 msicotte 2007-09-13 15:23:20 UTC
assigning to jsi
Comment 27 jogi 2007-09-13 17:34:13 UTC
Created attachment 48222 [details]
test case specification
Comment 28 jogi 2007-10-09 06:16:43 UTC
seen in m229