Apache OpenOffice (AOO) Bugzilla – Issue 79847
Customize toolbar dialog has no descriptions
Last modified: 2007-08-10 10:11:16 UTC
Click on the right triangle of a toolbar. Click on 'Customize toolbar'. Click on 'Add' button. Click on any command. Watch, that no command has a description. Is OK in stable build OOo2.2.1.
cd: Confirmed.
cd: Set priority to P2 as a whole feature is now completely broken. cd->ab: Please have a look. The retrieval of help content using the command URL doesn't work anymore. There must be something broken as m217 work without any problem.
ab->cmc: I've analyzed the problem and found that it indeed starts with m218. That's where helplinker01redux was integrated and if I understand your comments correctly that's - because of the Solaris problems solved in helplinker01redux - also the first minor where the new helplinker mechanism really was used. For testing I used a m217 (without the issue) and a m219. I found that the pro- blem is caused by a failing access to office_inst\help\en\swriter.ht file in xmlhelp\source\cxxhelp\provider\databases.cxx, Databases::setActiveText(). In m217 getting data for e.g. Id = ".uno%3AOpen" succeeds whereas in m219 using the same Id fails. Copying the swriter.ht file from m217 to m219 installation fixes the problem. But the text that should be found (e.g. "Opens or imports a file" for Open) isn't missing in the m219 ht file (it's even contained four times there compared to three times in m217), but it cannot be accessed. So obviously the swriter.ht file built with the new helplinker became incom- patible somehow. Please have a look.
I'll take a look
Converting a query for e.g. .uno%3ACharFontName to .uno:CharFontName makes it work, so this boils down to a url encoding thingy. Should be easy to fix. Either the helpcompiler needs to url-encode ":" when writing these ids on creating helpcontent, or the originator of them shouldn't encode, presumably as it used to work the standard is to url-encode the ids in the helpcontent itself.
easy peasy, namespace URLEncoder { static std::string encode(const std::string &rIn) { - const char *good = "!$&'()*+,-.:=@_"; + const char *good = "!$&'()*+,-.=@_"; static const char hex[17] = "0123456789ABCDEF"; the original jave urlencode clearly considers ":" to be an unsafe char that needs escaping, so just remove from the "good" list fixed in cmcfixes36
want to verify this in cmcfixes37, installsets at http://ooo.services.openoffice.org/pub/OpenOffice.org/cws/upload/cmcfixes37/ If you want alternatively extract the patch and run it through in a separate workspace then go ahead and I'll back it out of this workspace.
cd: Verified on CWS.
*** Issue 79589 has been marked as a duplicate of this issue. ***
may I ask you to have a look at issue 62326 ?
cd: Verified on master. Closed.