Apache OpenOffice (AOO) Bugzilla – Issue 81231
System file-picker can't be used
Last modified: 2009-04-30 11:13:06 UTC
Only the own file-picker is shown, no matter if the appropiate checkbox on tools/options/general is checked or not. Reproducible in a m226 or 227 build, but OK in OOG !
.
Issue confirmed in m226, m227 on Mac OS X Aqua, m225 is ok. Big regression: blocker for OpenOffice.org Aqua, because Mac users will kill us if we don't have a working native FilePicker Raising priority for P2
+ me on CC
as->ericb: .... yes it's a regression ... but not a show stopper .-) Because it does not affect the real OOo 2.3. code line (means OOG branch!) So currently only the next minor OOo 2.4 will be broken (which wont be released now. First 2.3. will come). BTW: The fix is very easy. There was a double registration for the generic file picker service. And UNO cant guarantee right handling if there exists ambigous registrations. So please have also a look into your own aqua file picker registration. If your picker will be registered for "com.sun.star.ui.dialogs.FilePicker" its wrong and will trigger the same type of issue.
ericb->as Ok. The problem we have is we have choosen to provide one milestone from 2.4 branch as alpha during OOocon for Aqua version (we were too late for 2.3 branch) For that, we have aquavclcarbonfixes cws to be tested on several platforms. Today or tomorrow, this cws will be set as ready for QA ( 95% of the code review is already done) And if you want we can add the fix inside. What do you think ? BTW: hdu told me Windows version is affected too.
ericb->as Reading fpicker/source/aqua/fps-aqua-ucd.txt the AquaFilePicker is registered as com.sun.star.ui.dialogs.AquaFilePicker , only once. Can you tell me more about the double registration issue, and the code who caused the issue ? I'd like to understand what happens for us. Thanks in advance :)
as->ericb: Double registration means ... registration for the same generic(!) file picker service name. Normaly every file picker implementation should be registered for ONE implementation name and ONE service. And normaly the real picker should be created at runtime by using it's implementation name - because such implementation name is unique by definition. But unfortunately the current implementation uses different uno service names to distinguish between those picker implementations. Thats imho wrong. Anyway ... Currently you have to make sure your implementation wont be registered for the mentioned service name - that's it. Might be we will refactor this next time. Currently there is a cws hosted by me (named "as6") where I've already made some file picker changes. May be I can do that on this cws also ... BTW: Please have a look on issue i78854. I will send you a child task next time for these .-) Another question ... I will attach a patch which fix this issue here. You said there is already a cws hosted by you. Would be nice if you can apply these patch there and bring the fix into the 2.4. code line :-)
Created attachment 47952 [details] patch
ericb->as Thank you very much. I'll start a build in 2 minutes, and I'll keep you informed if your patch helps. + I'll attach a new patch with DOS endlines and unix directories separator
Created attachment 47953 [details] new patch for unix file systems
ericb->as Thanks for all the explanations ! When as6 will be ready for QA, I'd like we test it too on Mac OS X. Just ask me, and I'll do a build Build in progress (m227)
ericb->as The fix works fine. Thank you very much :-) Do you see any objection if I commit the change in aquavclcarbonfixes ? (I'll create another issue ) + CC for Florian Heckl who wrote the main part of the Aqua File Picker
Reset issue to P3
as->ericb: Please dont file a new issue for these. Instead you can add THESE task here to your cws and check in the fix. Right ?
ericb->as Thank you I'll add the issue to aquavclcarbonfixes, and will QA it asap ( will probably be ready for QA today ) hdu proposed me to verify the fix works on Windows too.
Change commited, and issue fixed in aquavclcarbonfixes
as->ericb, hdu: Thanks :-)
Verified the fix in CWS aquavclcarbonfixes on windows and unix-gtk.
Also verified in CWS aquavclcarbonfixes on unxmac.
@AS: we integrated the fix in CWS aquavclcarbonfixes, which has a OOo 2.4 target. Since QA gave this issue an earlier target I suggest to get the tested fix into a CWS with a matching target too.
reset target to 2.4, but IMHO, the issue has to be backported into 2.3.1
Task will be also fixed on cws fwk75 with target 2.3.1.
as->tm: please verify these task on cws "fwk75" again. Because it's a OOo 2.3.1 task it has to be fixed not only inside cws aquavclcarbonfixes .-) THX.
closed