Apache OpenOffice (AOO) Bugzilla – Issue 81299
Copy Table from one database to another crashes
Last modified: 2007-09-17 21:04:42 UTC
Open two base documents Choose Tables in both documents copy a table from one database to the other. ("Kopieren -> Inhalte einfügen") Crash Thomas Krumbein found it under Windows Vista I can confirm it under Debian I send two crah reports today. It's r62ynn and rvdynn.
A simple Insert works "content insert2 crashes
i can repro that like described in a OOg680m3 (also m2) with 'paste special' insted of 'paste' (einfügen) - worked fine in a 8pp7
set keyword 'regression'
OO 2.2.1 works, OOG680_m3=RC1 crashed, SRC680_m226 crashed,
SRC680_m222 also crashed
Please let's be realistic about the priority. http://www.openoffice.org/scdocs/ddIssues_EnterModify.html#priority
That's a regression of the ResMgr change - seems there still are res ids without resource manager, somewhere in so3.
fs->pl: This probably came in with rev. 1.23 of so3/source/dialog/pastedlg.cxx. In line 570, *SOAPP->GetResMgr() is accessed, which is NULL, unfortunately. Any idea about this code, what SOAPP is, and why its res mgr is NULL at this place?
Great. SOAPP is defined as (*((SoDll**)GetAppData(SHL_SO2))) DoDll has a member pResMgr, which is returned by GetResMgr, but *never* set to anything other than NULL.
Phillip, since you did the res mgr change, you probably have the best idea which res mgr should be used instead of SOAPP->GetResMgr?
ResMgr * SoDll::GetResMgr() { // Resourcen sind im Default ResMgr ( OFA ) return NULL; } Hmm. How to access the OFA resources from within so? Also, why does SO3 build own resources (so680<locale>.res) if they're not used?
Looking through other code in so3 which does resource access (and thus would also crash), it seems this project is a collection of dead corpses. All resource-dependent classes I found so far are not used *anywhere*, according to LXR. Argh. Completely independent from this issue, I think I'm going to create a CWS which will clean up so3.
I already did some work in dbaccess in source/ui/app/AppController.cxx where I replaced the dialog from so3 by the same dialog from svx, yes it's duplicate code here, with only some more changes like ResMgr :-( I fixed it while fixing issue i78257. cvs diff -r1.42.14.3 -r1.42.14.4 AppController.cxx
Grabbing this issue.
submitted issue 81309 for cleaning up so3.
Fixed in cws dba23f
Please verify. Thanks.
verified on Linux, windows is still building
verified also on windows
set target to 2.3
according to discussion in #oooreleases today: 12:45 < _Nesshof_> I also tend not to include this in release, not that much users would are impacted and release would delay after OOoCon 12:46 < _Nesshof_> maybe we can offer dll/library separatly for those running in that issue 12:47 < paveljanik> _Nesshof_: IE. releasing m4 as final and upload the affected lib(s) from m5, right? 12:49 < _Nesshof_> yep [...] 14:32 < paveljanik> but as it asks, I think that we do not even need to provide libs... 14:32 < paveljanik> just fix it in 2.3.1.
just to mention, that the bug is more genereal. The crash seems to occure on any attempt to "Insert special" on Base table screen. E.g. copy a Table from any HTML Website, Insert - Special in Base -> crash
Change target as agreed on releases meeting.
verified in OOG680_m5 -> closed