Issue 81504 - EnableInput is called after modal dialog
Summary: EnableInput is called after modal dialog
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: code (show other issues)
Version: 680
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: philipp.lohmann
QA Contact: issues@sw
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-09-11 14:45 UTC by max.odendahl
Modified: 2013-08-07 14:42 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description max.odendahl 2007-09-11 14:45:10 UTC 
A MultiLineEdit is set with EnableInput(false), which works. But after opening
any modal dialog, this is changed back.

Probably a side effect of Dialog::Notify, which tinkers with EnableInput of its
parent and siblings
Comment 1 philipp.lohmann 2007-09-24 12:16:02 UTC 
.
Comment 2 philipp.lohmann 2007-10-09 15:37:45 UTC 
fixed in CWS vcl83
Comment 3 philipp.lohmann 2007-10-23 12:42:14 UTC 
please verify in CWS vcl83
Comment 4 hdu@apache.org 2007-10-23 12:52:33 UTC 
Verified by code review in CWS vcl83.
Comment 5 hdu@apache.org 2007-12-04 09:11:02 UTC 
Got into SRC680_m238 => closing
Comment 6 bjoern.milcke 2007-12-05 15:58:06 UTC 
/me wonders what this issue is really about and what has been done to fix it ...
Comment 7 bjoern.milcke 2007-12-12 12:38:01 UTC 
Ok, seems like EnableInput now uses a counter for enabling/disabling instead of
just a bool. And in fact, apart from introducing Issue 84265 it also fixes Issue
79435.
Comment 8 max.odendahl 2007-12-16 00:59:08 UTC 
Seems to work for modal dialogs now, but the same problem still exists for
message boxes
Comment 9 max.odendahl 2007-12-16 00:59:49 UTC 
reassigning
Comment 10 philipp.lohmann 2007-12-17 08:51:23 UTC 
Since message boxes are modal dialogs I have trouble undersatnding that. Do you
have an example ?
Comment 11 max.odendahl 2007-12-17 08:56:59 UTC 
mod->pl:

it works e.g. for Tools - Options, but does not work for e.g assertion message
box or "The document has been modified, do you want to save your settings"
Comment 12 philipp.lohmann 2007-12-17 09:12:18 UTC 
Is there a CWS where I can see this ?
Comment 13 philipp.lohmann 2007-12-17 12:20:22 UTC 
back to fixed and closed

The problem is that SfxViewFrame in this case enables input for the complete
frame hierarchy (using EnableInput( true, true ) for the top view frame). This I
cannot fix in vcl, you'll probably have to arrange something with framework.
Probably a correspoding EnableInput( FALSE ) is needed in case of some
notification, I suggest talking to cd or as about this.
Comment 14 philipp.lohmann 2007-12-17 12:22:45 UTC 
closing