Issue 8198 - configmgr/source/inc/treesegment.hxx - missing include?
Summary: configmgr/source/inc/treesegment.hxx - missing include?
Status: CLOSED FIXED
Alias: None
Product: porting
Classification: Code
Component: code (show other issues)
Version: 643
Hardware: SGI IRIX
: P3 Trivial (vote)
Target Milestone: OOo 1.1 Beta
Assignee: nickb
QA Contact: issues@porting
URL:
Keywords: merge_pending
Depends on:
Blocks:
 
Reported: 2002-10-10 02:20 UTC by nickb
Modified: 2004-02-15 07:20 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
configmgr/source/inc/treesegment.hxx - added #include "valuenode.hxx" (572 bytes, patch)
2002-10-10 02:21 UTC, nickb 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description nickb 2002-10-10 02:20:31 UTC 
It seems that there is an include file missing. INode is not declared. This is
possibly only a problem with gcc-2.95.
Comment 1 nickb 2002-10-10 02:21:05 UTC 
Created attachment 3107 [details]
configmgr/source/inc/treesegment.hxx - added #include "valuenode.hxx"
Comment 2 nickb 2002-10-31 00:23:29 UTC 
Confirming Issue.
Comment 3 Martin Hollmichel 2003-02-04 10:20:54 UTC 
mh->jb: please review !
Comment 4 joerg.barfurth 2003-02-04 10:45:10 UTC 
Yuck. I don't like that dependency. But if gcc-2.95 won't do without ...

Thus: Approved. 

Also changing target milestone, as this file does not yet exist on
OO_STABLE_1.
Comment 5 nickb 2003-02-05 05:17:46 UTC 
Hmmm, effectively this change has already been done, except that
instead of:
+#ifndef _CONFIGMGR_TREE_VALUENODE_HXX
+#include "valuenode.hxx"
+#endif

its just
+#include "valuenode.hxx"

Shouldn't this be wrapped in #ifndef's? Leaving open....
Comment 6 nickb 2003-02-05 05:34:45 UTC 
Ok, it was fixed in IZ 7584 (submitted by Ken Fosky, checked in by armin).

So, I will close this, as it should be ok...
Comment 7 Martin Hollmichel 2004-02-15 07:19:56 UTC 
mark as verified
Comment 8 Martin Hollmichel 2004-02-15 07:20:42 UTC 
close issue.