Apache OpenOffice (AOO) Bugzilla – Issue 84189
document-local UNO dialogs containing label controls cannot be loaded anymore
Last modified: 2008-03-12 08:48:28 UTC
- open the document AWT_TREE_sample_code.odt attached to issue 82954 (http://www.openoffice.org/nonav/issues/showattachment.cgi/49297/AWT_TREE_sample_code.odt) - press the contained button => the Basic IDE opens, pointing out an error in a call DialogLibraries.loadLibrary( "Standard" ) This document in fact should contain a dialog library named "Standard", and therein a dialog. In m237, both are present, in m238, they aren't.
Note: I was not able to reproduce this with a newly created document with an embedded dialog. Not sure what's special about the referenced bug doc. fs->mba: I strongly hope this isn't a regression of my changes with respect to the AdjustMacroMode thing, which came in into m238 :-\. Going to debug a little.
cd: Set on CC.
fs->tkr: This seems to be a regression of your "NoLabel" change. What happens is that when the dialog is to be loaded, ElementDescriptor::readFixedTextModel tries to translate an attribute "nolabel" to a property value of NoLabel. Which leads to ElementDescriptor::read asking for the NoLabel property, which simply does not exist at the FixedTextModel, thus an UnknownPropertyException is thrown, which cancels the loading of the complete dialog. Besides that I think the current behavior is *way too* intolerant (why is does *complete* loading fail when there is an error with a single property?), it seems the code silently assumes that there is a NoLabel property where there actually is none.
Created attachment 50061 [details] document to reproduce the bug case
The attached document is a stripped-down version: Just open it, and press the button - this should display a simple dialog containing a fixed text only. In m237 it works, in m238 it doesn't.
Raising the priority to P2: Trying a "Tools / Macros / Organize Dialogs", following by expanding the bug doc's node to display the contained dialogs, actually crashes. Seems the organizer dialog is not catching exceptions thrown by the core implementations (which is a bug of its own).
accepted
Fixed in tkr07. Was a merge conflict in toolkit.
TKR -> JSK: please verify
found fixed on cws tkr07
Both module and dialog are present in the AWT_TREE_sample.odt and the attached bugdoc works fine in ooh680m10. Closing