Issue 85044 - No warning to save existing file when using Windows native Save dialog
Summary: No warning to save existing file when using Windows native Save dialog
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: ui (show other issues)
Version: 680m242
Hardware: All Windows XP
: P3 Trivial (vote)
Target Milestone: OOo 2.4
Assignee: kla
QA Contact: issues@framework
URL:
Keywords: oooqa, regression
: 85623 (view as issue list)
Depends on:
Blocks: 84957
  Show dependency tree
 
Reported: 2008-01-07 09:57 UTC by oooforum (fr)
Modified: 2008-02-27 17:43 UTC (History)
5 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
Save dialog screenshot (33.25 KB, image/jpeg)
2008-01-16 17:07 UTC, oooforum (fr)
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description oooforum (fr) 2008-01-07 09:57:12 UTC
Not sure for version: I use SRC680_m241

If you saved with an existing filename, OOo don't display any warning and the
file is replaced.
Comment 1 Ariel Constenla-Haile 2008-01-14 13:11:20 UTC
arielch -> oooforum: Can you tell me if this is the behavior

* you are NOT using OOo dialog, but Windows dialog
* if you enter the file name without extension, the old file gets overwritten
* if you enter the file name AND the extension, you are asked if you wnat to
overwrite the document

To try with OOo dialogs, go to Tools-Options-OOo-General-Open/Save dialogs

I think it only happens with Windows dialog, tested in 680m242
Comment 2 Ariel Constenla-Haile 2008-01-14 13:45:20 UTC
Changed summary because it happens on Windows when using Windows' native Save
dialog.

In fact, on Linux there is no option to use the system's dialog (there is no 
Tools - Options - OOo - General - Open/Save ).
Comment 3 andreschnabel 2008-01-14 17:58:51 UTC
this works for me, using Src680m241, windows system dialogs.

What I did is:
- create a new writer file
- use "File - save as..."
- browse to a directory where a document "kill_this.odt" exists
- select "kill_this.odt", so that this becomes the file name to save the document
- click save
-> warning that file already exists appears

- removefile extension, so that the filename is "kill_this" (.odt would be added
by OOo)
- click save
-> warning appears that file already exists

oooforum / arielch : can you please give a step-by-step instruction how to
reproduce?
Comment 4 oooforum (fr) 2008-01-15 09:08:36 UTC
Now I use SRC680_m242

@  andreschnabel: Well I did like you except 2st step
1- create a new writer file and input some text
2- menu File > Save or Ctrl + S
3- browse to a directory where a document "kill_this.odt" exists

4-1 input "kill_this" and save -> no warning
4-2 input "kill_this.odt" and save -> NOW warning appears 

Comment 5 andreschnabel 2008-01-15 20:21:09 UTC
I still cannot reproduce using m241 or OOH680m2.

oooforum: 
in you initial post,you told you use m241 but you're not sure about this. Can
you confirm that the issue exists in m241?
This is important, as m242 is *not* going into OOo 2.4 (means, we have a little
more time if this does not occure in m241).

can you attach a screenshot of the file dialog with the selected path and
filename  ?

If we can reproducethisproblemin OOo 2.4 codeline, I would consider this as a
stopper - but as said, I cannot reproduce.
Comment 6 oooforum (fr) 2008-01-16 17:06:30 UTC
In my previous post, I confirm to use SRC680_m242.

That's happen only if:
- Saving a new document with "Save" menu or Ctrl + S
- Input  in "Filename" field with an existing file without extension

Maybe difference with you: my Windows system is in french 

Comment 7 oooforum (fr) 2008-01-16 17:07:53 UTC
Created attachment 50913 [details]
Save dialog screenshot
Comment 8 Regina Henschel 2008-01-16 17:38:39 UTC
I can confirm the behavior as described with the steps
1- create a new writer file and input some text
2- menu File > Save or Ctrl + S
3- browse to a directory where a document "kill_this.odt" exists
4-1 input "kill_this" and save -> no warning
4-2 input "kill_this.odt" and save -> NOW warning appears 

with Windows native save dialog; German SRC680m241 on German WinXP.
Comment 9 andreschnabel 2008-01-16 18:19:50 UTC
ok - I can confirm. 

The trick is,that you need to  type the filename (I clicking on an existing file
will give the warning). If you don't want to overwrite an existing file, it is
normal to type the filename - so there is a real risk to loose existing files.
Comment 10 thorsten.martens 2008-01-21 14:52:47 UTC
TM->AS: as talked about,...reassigned to you.
Comment 11 andreas.schluens 2008-01-23 12:18:37 UTC
as: We've rolled back changes regarding "removing check box for AutoExtension"
... but for the internal OOo and the native windows file picker only. So the
gnome file picker (where this feature was introduced first time) will stay alive
with the new feature.

as->kla: Please verify these task on cws "autoextension01". Note: you have to
check some special variants of the SavAs dialog too ... as e.g. "File->Export"
or "Export As PDF ...".
Comment 12 andreas.schluens 2008-01-23 12:19:44 UTC
.
Comment 13 kla 2008-01-24 13:25:29 UTC
Check box for AutoExtension are back (integrated) All possible variants of Save
as  Dialog, esp.  "File->Export"and "Export As PDF ...". checked by me and TM.
Overwrite warning dialog works also fine. Also the gnome file piker (checked by TM).
verified
Comment 14 oooforum (fr) 2008-01-24 15:15:13 UTC
@kla: that's mean it's fixed for the native windows file picker too?
Comment 15 Frank Schönheit 2008-01-28 08:19:57 UTC
*** Issue 85623 has been marked as a duplicate of this issue. ***
Comment 16 andreschnabel 2008-02-27 17:43:44 UTC
fixed im OOH680_m7 -> closed