Issue 85334 - When loading own files, warnings aren't shown
Summary: When loading own files, warnings aren't shown
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: OOH680m3
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 2.4
Assignee: mikhail.voytenko
QA Contact: issues@framework
URL:
Keywords:
Depends on:
Blocks: 84957
  Show dependency tree
 
Reported: 2008-01-17 15:50 UTC by niklas.nebel
Modified: 2008-02-28 09:30 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
File with many columns, which triggers the warning (9.42 KB, application/vnd.oasis.opendocument.spreadsheet)
2008-01-17 16:51 UTC, niklas.nebel 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description niklas.nebel 2008-01-17 15:50:35 UTC 
When an ODS file is loaded that has more columns or rows than supported, Calc
sets a warning-type error code at the SfxMedium. But this warning currently
isn't shown, because the error code is reset when document signatures are
checked, called from SfxObjectShell::FinishedLoading. It worked in 2.0 beta, but
was already broken in 2.0 final. This might become a big problem if we start
writing files with more columns in 3.0.
Comment 1 niklas.nebel 2008-01-17 16:51:12 UTC 
Created attachment 50944 [details]
File with many columns, which triggers the warning
Comment 2 mikhail.voytenko 2008-01-22 14:32:30 UTC 
The problem is that currently all the warnings that are set to SfxMedium during
the loading are ignored because of the bug ( the warnings that are set on
SfxObjectShell are not ignored ).

Fix is ready and looks to be quite easy and safe. Is it 2.4 issue?
Comment 3 mikhail.voytenko 2008-01-24 11:52:53 UTC 
The task has been accepted as showstopper, changing the target.
Comment 4 mikhail.voytenko 2008-01-24 12:03:06 UTC 
.
Comment 5 pb 2008-01-25 11:51:10 UTC 
pb: verified in cws.
Comment 6 mikhail.voytenko 2008-02-28 09:30:26 UTC 
Closing.