Issue 85429 - a11y Writer: no accessibility::AccessibleShape instance for sound/movie drawing objects -> causes crashes
Summary: a11y Writer: no accessibility::AccessibleShape instance for sound/movie drawi...
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: code (show other issues)
Version: 680m242
Hardware: All Linux, all
: P2 Trivial (vote)
Target Milestone: ---
Assignee: eric.savary
QA Contact: issues@sw
URL:
Keywords: accessibility
Depends on:
Blocks: 90510
  Show dependency tree
 
Reported: 2008-01-21 11:01 UTC by caolanm
Modified: 2013-08-07 14:43 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
patch to fix (589 bytes, patch)
2008-01-21 11:01 UTC, caolanm
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description caolanm 2008-01-21 11:01:20 UTC
patch attached. Drag a sound from the gallery into writer when a11y is enabled,
now delete the item from writer and crash with...

#0  SwAccessibleContext::DisposeShape (this=0x1546160, pObj=0x16e35d0,
pAccImpl=<value optimized out>)
    at /usr/src/redhat/BUILD/OOH680_m1/sw/source/core/access/acccontext.cxx:1066
#1  0x00002aaabb657e57 in SwAccessibleContext::DisposeChild (this=0x1546160,
rChildFrmOrObj=@0x7fff369edbc0, bRecursive=0 '\0')
    at /usr/src/redhat/BUILD/OOH680_m1/sw/source/core/access/acccontext.cxx:1170
#2  0x00002aaabb66c4b4 in SwAccessibleMap::Dispose (this=0x15460c0, pFrm=0x0,
pObj=0x7fff369edb80, bRecursive=0 '\0')
    at /usr/src/redhat/BUILD/OOH680_m1/sw/source/core/access/accmap.cxx:1628
#3  0x00002aaabb6e56d5 in SwViewImp::DisposeAccessible (this=<value optimized
out>, pFrm=0x0, pObj=0x16e35d0, bRecursive=0 '\0')
    at /usr/src/redhat/BUILD/OOH680_m1/sw/source/core/view/viewimp.cxx:445
#4  0x00002aaabb72cb18 in SwFrm::RemoveDrawObj (this=0x2aaabe7c2000,
_rToRemoveObj=@0x1693ea8) at ../inc/viewimp.hxx:414
#5  0x00002aaabb6f9a3d in SwDrawContact::DisconnectFromLayout (this=0x1693e70,
_bMoveMasterToInvisibleLayer=false)
    at /usr/src/redhat/BUILD/OOH680_m1/sw/source/core/draw/dcontact.cxx:1836
#6  0x00002aaabb6fd485 in SwDrawContact::_Changed (this=0x1693e70,
rObj=@0x16e35d0, eType=SDRUSERCALL_DELETE, 
    pOldBoundRect=0x16e3618) at
/usr/src/redhat/BUILD/OOH680_m1/sw/source/core/draw/dcontact.cxx:1429
#7  0x00002aaabb6fdb09 in SwDrawContact::Changed (this=0x1693e70,
rObj=@0x16e35d0, eType=SDRUSERCALL_DELETE, 
    rOldBoundRect=@0x16e3618) at
/usr/src/redhat/BUILD/OOH680_m1/sw/source/core/draw/dcontact.cxx:1310
#8  0x00002aaabb80af88 in SwDoc::DeleteSelection (this=0xf75510,
rDrawView=<value optimized out>)
    at /usr/src/redhat/BUILD/OOH680_m1/sw/source/core/doc/docdraw.cxx:607
#9  0x00002aaabb6f7cbb in SwDrawView::DeleteMarked (this=0xfc2340)
    at /usr/src/redhat/BUILD/OOH680_m1/sw/source/core/draw/dview.cxx:1040
#10 0x00002aaabba23de7 in SwFEShell::DelSelectedObj (this=0xfb0be0)
    at /usr/src/redhat/BUILD/OOH680_m1/sw/source/core/frmedt/feshview.cxx:2215
#11 0x00002aaabbd3a88d in SwMediaShell::ExecMedia (this=0x174eb50, rReq=<value
optimized out>)
    at /usr/src/redhat/BUILD/OOH680_m1/sw/source/ui/shells/mediash.cxx:203
#12 0x00002aaab93a0a57 in SfxDispatcher::Call_Impl (this=0xf9d820,
rShell=@0x174eb50, rSlot=@0x2aaabc225980, rReq=@0x7fff369ee350, 
    bRecord=1 '\001') at ../../inc/sfx2/shell.hxx:226
#13 0x00002aaab93949d4 in SfxBindings::Execute_Impl (this=0xf9c080,
aReq=@0x7fff369ee350, pSlot=0x2aaabc225980, pShell=0x174eb50)
    at /usr/src/redhat/BUILD/OOH680_m1/sfx2/source/control/bindings.cxx:1732
#14 0x00002aaab93bf497 in SfxDispatchController_Impl::dispatch (this=0x17988a0,
aURL=@0x7fff369ee3a0, aArgs=<value optimized out>, 
    rListener=@0x7fff369ee4c0) at
/usr/src/redhat/BUILD/OOH680_m1/sfx2/source/control/unoctitm.cxx:831
#15 0x00002aaab93bfdd9 in SfxOfficeDispatch::dispatch (this=0x1798b80,
aURL=@0x17a6770, aArgs=@0x7fff369ee510)
    at /usr/src/redhat/BUILD/OOH680_m1/sfx2/source/control/unoctitm.cxx:454
#16 0x00002aaaab6df318 in svt::AsyncAccelExec::impl_ts_asyncCallback
(this=0x17a6750)
    at
/usr/src/redhat/BUILD/OOH680_m1/svtools/source/misc/acceleratorexecute.cxx:471
Comment 1 caolanm 2008-01-21 11:01:51 UTC
Created attachment 51048 [details]
patch to fix
Comment 2 andreas.martens 2008-01-21 13:45:31 UTC
Please have a look...
Comment 3 Oliver-Rainer Wittmann 2008-01-24 10:57:04 UTC
Currently, I have problems with the insertion of a sound from the gallery in a
one the current versions - I'm getting the message that the file format is not
supported. Thus, I can not reproduce this crash at the moment.
Waiting for further investigation from QA.
Comment 4 caolanm 2008-01-24 11:09:25 UTC
Do you get that on windows or just linux ? Probably need JMF installed under
linux to have a chance to see it with the default avmedia solution there.
Comment 5 Oliver-Rainer Wittmann 2008-01-24 12:00:35 UTC
OD->CMC: Thx for the hint. I'm trying to insert a sound from the gallery under
Windows, Linux and Solaris and I had no success.
Comment 6 Oliver-Rainer Wittmann 2008-02-20 11:07:25 UTC
Now, I reproduced the crash.
The provided patch would avoid the described crash.
But, the root cause of the crash is that no accessible::AccesibleShape instance
could be created in the Writer accessibility API implementation for sound
respectively movie drawing objects. This defect will cause further
defects/crashes, when accessing such a drawing object via the accessibility API.
Thus, I decided to change this issue to a more general one to fix the root cause.

Note: It seems that the defect (missing accessible::AccessibleShape instance for
sound/movie drawing objects) already exist since OOo 2.0, when these drawing
objects are introduced.
Comment 7 Oliver-Rainer Wittmann 2008-02-27 13:39:07 UTC
Deeper investigation with AF reveals that accessibility implementation for media
shapes is missing.

Proposed solution: Same as for custom shapes - see issue 37790
Comment 8 Oliver-Rainer Wittmann 2008-05-19 11:34:50 UTC
fixed in cws sw30a11y01 - changed files:
/svx/inc/svx/SvxShapeTypes.hxx, 1.4.64.1
/svx/source/accessibility/SvxShapeTypes.cxx, 1.16.64.1
Comment 9 Oliver-Rainer Wittmann 2008-06-05 08:05:55 UTC
OD->ES: Checked in internal installation set of cws sw30a11y01 - please verify.
Comment 10 eric.savary 2008-06-18 23:06:45 UTC
Verified in CWS sw30a11y01.
Comment 11 thorsten.ziehm 2009-07-20 15:58:21 UTC
This issue is closed automatically and wasn't rechecked in a current version of
OOo. The fixed issue should be integrated in OOo since more than half a year. If
you think this issue isn't fixed in a current version (OOo 3.1), please reopen
it and change the field 'Target Milestone' accordingly.

If you want to download a current version of OOo =>
http://download.openoffice.org/index.html
If you want to know more about the handling of fixed/verified issues =>
http://wiki.services.openoffice.org/wiki/Handle_fixed_verified_issues