Issue 93180 - a form control whose context is deleted while change tracking is enabled does not disappear
Summary: a form control whose context is deleted while change tracking is enabled does...
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: viewing (show other issues)
Version: DEV300m30
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: wolframgarten
QA Contact: issues@sw
URL:
Keywords: regression
: 93175 (view as issue list)
Depends on:
Blocks:
 
Reported: 2008-08-27 12:37 UTC by Frank Schönheit
Modified: 2013-08-07 14:43 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
document to reproduce the bug case (7.84 KB, application/vnd.oasis.opendocument.text)
2008-08-27 12:38 UTC, Frank Schönheit 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Frank Schönheit 2008-08-27 12:37:38 UTC 
- open the attached text document. It has change tracking enabled, but changes
  are not shown (Edit/Changes/Record is checked, but Edit/Changes/Show isn't)
- select some text including the third paragraph (the one which contains the
  form control)
- delete this text
=> the button is still there, though it should vanish, since it's part of the
   deleted paragraph
Comment 1 Frank Schönheit 2008-08-27 12:38:23 UTC 
Created attachment 56048 [details]
document to reproduce the bug case
Comment 2 Frank Schönheit 2008-08-27 12:39:20 UTC 
regression between m29 and m30 => keyword, target
Comment 3 Armin Le Grand 2008-10-17 13:37:14 UTC 
AW: There is code in ViewObjectContactOfUnoControl to correct the LayerChange at
the object when control is in live mode (see
ViewObjectContactOfUnoControl_Impl::modeChanged), but it's no longer triggered.
I do not know how it was triggered in the past (probably in paints, found no
concrete hints), but the best way now is to check visibility on ActionChanged()
at the VOC which itself is triggered on model change, and so also from LayerID
change.
Changed ViewObjectContactOfUnoControl to be derived from
ViewObjectContactOfSdrObj to derive the correct isPrimitiveVisible
implementation from there. Als gives access to SdrObject and is conform with the
VC also being derived from it's SdrObject incarnation (it's a SdrObject anyways).
Added ViewObjectContactOfUnoControl::ActionChanged() which will correct the
XControl's visibility when in live mode.
Works as expected, doing some more tests...
Comment 4 Armin Le Grand 2008-10-17 13:45:13 UTC 
*** Issue 93175 has been marked as a duplicate of this issue. ***
Comment 5 Armin Le Grand 2008-10-17 17:30:02 UTC 
AW: Works well, checked in. Done.
Comment 6 Armin Le Grand 2008-11-06 11:20:24 UTC 
AW->WG: Please review as described in the task. Maybe FS wants to check, too.
Comment 7 Frank Schönheit 2008-11-13 08:41:07 UTC 
looks good in CWS aw058, thanks.
Comment 8 wolframgarten 2009-01-19 09:58:46 UTC 
Tested in m38. Closed.