Issue 93828 - Aqua: crash in SalAquaFilePicker::updateSaveFileNameExtension()
Summary: Aqua: crash in SalAquaFilePicker::updateSaveFileNameExtension()
Status: CLOSED FIXED
Alias: None
Product: porting
Classification: Code
Component: code (show other issues)
Version: OOO300m5
Hardware: Mac Mac OS X, all
: P3 Trivial (vote)
Target Milestone: OOo 3.0.1
Assignee: philipp.lohmann
QA Contact: issues@porting
URL:
Keywords: aqua, crash, release_blocker
: 89137 93508 93827 95777 96871 (view as issue list)
Depends on:
Blocks:
 
Reported: 2008-09-12 14:49 UTC by hdu@apache.org
Modified: 2008-12-15 10:26 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description hdu@apache.org 2008-09-12 14:49:36 UTC 
There is a scenario that results in a crash in SalAquaFilePicker::updateSaveFileNameExtension(). It happens 
when FilterHelper::getCurrentFilterSuffixList() returns an empty list. As of now it was only observed for 
PDF-export and the scenario is not yet fully understood.

@fheckl: do you have any idea, why the the filtersuffix list might be empty especially in the PDF-export 
scenarios?
Comment 1 hdu@apache.org 2008-09-12 14:53:43 UTC 
the fix is simple enough: just test the list for emptyness
Comment 2 hdu@apache.org 2008-09-12 15:10:47 UTC 
Since the crash should cause a restart I put the hotfix in the most appropriate CWS macrestart2
Comment 3 hdu@apache.org 2008-09-12 15:11:32 UTC 
@pl: please verify in CWS macrestart2
Comment 4 hdu@apache.org 2008-09-12 15:13:37 UTC 
*** Issue 93827 has been marked as a duplicate of this issue. ***
Comment 5 florian 2008-09-13 09:35:07 UTC 
Though it is surely the best to test the list for emptyness before accessing it, it would be good to find out 
why the list is empty in the mentioned scenario. If we are not able to set a required file type due to an 
empty suffix list the user can set the filename suffix to anything she likes which is no big deal but also not 
ideal since a different app might then want to open this file...
Comment 6 philipp.lohmann 2008-09-15 10:51:36 UTC 
verify empty check. Certainly it would still be good to know, why this happened
at all.
Comment 7 hdu@apache.org 2008-09-15 12:58:47 UTC 
@pl/@fheckl: when I could still reproduce the problem it looked as if
- the OUStringList wasn't empty before FilterHelper::getCurrentFilterSuffixList() returned
- the aStringList in SalAquaFilePicker::updateSaveFileNameExtension() was empty!!!
So I suspect something went wrong when the OUStringList got copied around... scary stuff.
Comment 8 philipp.lohmann 2008-09-19 12:15:43 UTC 
*** Issue 93508 has been marked as a duplicate of this issue. ***
Comment 9 philipp.lohmann 2008-09-24 13:02:24 UTC 
target
Comment 10 hdu@apache.org 2008-10-23 09:28:24 UTC 
By the way: until the fix is integrated the easiest workaround is to disable native dialogs by enabling
  Tools->Options->Office->General->OpenSaveDialogs->UseOwnDialog
Comment 11 ab 2008-11-05 13:10:59 UTC 
*** Issue 95777 has been marked as a duplicate of this issue. ***
Comment 12 hdu@apache.org 2008-11-18 09:12:34 UTC 
*** Issue 89137 has been marked as a duplicate of this issue. ***
Comment 13 hdu@apache.org 2008-12-05 09:30:07 UTC 
*** Issue 96871 has been marked as a duplicate of this issue. ***
Comment 14 philipp.lohmann 2008-12-15 10:26:07 UTC 
integrated, closing