Issue 98318 - Office Crash after setting the reference to an existing file
Summary: Office Crash after setting the reference to an existing file
Status: CLOSED FIXED
Alias: None
Product: Calc
Classification: Application
Component: editing (show other issues)
Version: DEV300 m39
Hardware: All All
: P2 Trivial (vote)
Target Milestone: ---
Assignee: oc
QA Contact: issues@sc
URL:
Keywords: crash, regression
: 98570 (view as issue list)
Depends on:
Blocks:
 
Reported: 2009-01-21 13:37 UTC by kla
Modified: 2013-08-07 15:14 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Patch (4.65 KB, patch)
2009-01-22 10:02 UTC, ocke.janssen 		no flags Details | Diff
The resulting patch. (6.33 KB, patch)
2009-01-23 01:09 UTC, ooo 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description kla 2009-01-21 13:37:19 UTC 
Steps to reproduce:
- Open a existing file
- Open a New File
- Use Function Button in the new file
- Switch to the existing file into a cell that contains content
- Press Return -> Office crash
Comment 1 kla 2009-01-21 13:39:14 UTC 
Sorry Eike, kohei should be the owner.
Comment 2 kyoshida 2009-01-21 13:56:01 UTC 
@kla: does this happen in m38, or is this specific in m39?
Comment 3 kla 2009-01-21 14:13:34 UTC 
@Kohei: work fine in m38.
Comment 4 ooo 2009-01-21 16:58:22 UTC 
This isn't related to the integration of CWS mooxlsc then, which introduced a
new handling of external references. I could bet it is because of CWS frmdlg ;-)

@oj: Since you probably have already the needed modules with debug in one of
your CWSs (my only CWS is currently rebasing to m39): could you please do us the
favor and take a look where it crashes and if it's related to frmdlg changes fix it?

Thanks
  Eike
Comment 5 ocke.janssen 2009-01-22 09:54:43 UTC 
Problem found. Grabbing.
Comment 6 ocke.janssen 2009-01-22 10:02:37 UTC 
Created attachment 59583 [details]
Patch
Comment 7 ooo 2009-01-22 11:41:21 UTC 
Call me blind, but what exactly caused the crash and was fixed with this patch?
Comment 8 ocke.janssen 2009-01-22 12:23:12 UTC 
-    pArray->Fill(_aTokenList);
+    pArray->Fill(_aTokenList,pDoc->GetExternalRefManager());
Comment 9 ooo 2009-01-22 13:40:27 UTC 
Argh.. I overlooked "use function button" in the original description.. thx.
Comment 10 ooo 2009-01-23 01:04:34 UTC 
Grabbing issue.
Comment 11 ooo 2009-01-23 01:08:24 UTC 
Funny.. we actually have two different crashes, one the attached patch fixes
when constructing external references via the Function Wizard (!), and the one
reported here with the Function (!) button that in fact is a duplicate of issue
98338. I applied both patches in CWS calcperf03. Note that I changed the C-style
casts of this patch here to static_casts, one of them also fixes WaE issue 97555.

revision 266762
sc/inc/token.hxx
sc/source/core/data/global.cxx
sc/source/core/tool/token.cxx
sc/source/ui/app/inputhdl.cxx
sc/source/ui/docshell/externalrefmgr.cxx
sc/source/ui/formdlg/formula.cxx
Comment 12 ooo 2009-01-23 01:09:17 UTC 
Created attachment 59605 [details]
The resulting patch.
Comment 13 ooo 2009-01-25 21:17:46 UTC 
Reassigning to QA for verification.
Comment 14 Joost Andrae 2009-01-28 14:02:21 UTC 
*** Issue 98570 has been marked as a duplicate of this issue. ***
Comment 15 oc 2009-02-02 14:04:25 UTC 
verified in internal build cws_calcperf03
Comment 16 amy2008 2009-03-27 08:05:32 UTC 
Verified in DEV310m7.
Closing

Li Meiying