Issue 98467 - Impossible to remove event assigned action
Summary: Impossible to remove event assigned action
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: ui (show other issues)
Version: DEV300m39
Hardware: PC Windows XP
: P3 Trivial (vote)
Target Milestone: OOo 3.1
Assignee: joerg.skottke
QA Contact: issues@framework
URL:
Keywords: regression
Depends on:
Blocks: 95768
  Show dependency tree
 
Reported: 2009-01-26 09:37 UTC by bmarcelly
Modified: 2009-02-25 08:32 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
This document has a Hello macro attached to event Open Document (10.25 KB, application/vnd.oasis.opendocument.spreadsheet)
2009-01-26 09:39 UTC, bmarcelly 		no flags Details
suggested patch (4.40 KB, patch)
2009-02-03 09:07 UTC, Frank Schönheit 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description bmarcelly 2009-01-26 09:37:45 UTC 
Regression found on DEV300m39

From a document, open Tools > Customize > Event tab.
Assign a macro to event Open Document of the document.
Check that it works, save the document.

Reopen Tools > Customize > Event tab
Remove the assigned action from event Open Document.
Close the dialog window.
Reopen Tools > Customize > Event tab : Assigned Action is still there !

Next attachment is an example. You can't remove the event action with DEV300m39.
But you can remove it with OOo 3.0.0.
Comment 1 bmarcelly 2009-01-26 09:39:10 UTC 
Created attachment 59663 [details]
This document has a Hello macro attached to event Open Document
Comment 2 bmarcelly 2009-01-28 08:43:06 UTC 
Problem still exists on DEV300m40.
Comment 3 bmarcelly 2009-02-03 07:17:06 UTC 
Proposing this issue as 3.1 release stopper.
Comment 4 Frank Schönheit 2009-02-03 08:57:58 UTC 
Confirming.
It has not been officially accepted as show stopper, but I take the liberty to
set the target already ...
Comment 5 Frank Schönheit 2009-02-03 09:07:52 UTC 
Created attachment 59847 [details]
suggested patch
Comment 6 Frank Schönheit 2009-02-03 09:11:04 UTC 
fs->mba: Would you please review the attached patch?

I suppose it's me who introduced the bug: I refactored the Tools/Customize
dialog a while ago, namely the macro assignment page, so that resetting a macro
is not done by passing a one-element sequence with an empty script type, but by
passing an empty sequence. I would have sworn that I also adjusted
SfxEvents_Impl::replaceByName to recognize this, but alas ...

Anyway, the attached patch fixes the problem, but just to be sure this time :),
I would be grateful if you could have a look at it. Thanks.
Comment 7 Frank Schönheit 2009-02-06 08:31:55 UTC 
fs->mba: Ping. This is a 3.1 issue, and the "dead line for exceptional code
fixes" is less than a week away. I *really* want to get this issue fixed. Please
review the attached patch, or name somebody else who you think could do the
review. Thanks.
Comment 8 Frank Schönheit 2009-02-09 09:11:49 UTC 
patch committed to CWS dba31i. fs->mba: Will correct if you veto it, for the
moment I assume the patch is okay. Sorry, but the deadline is too near for
further waiting ...
Comment 9 Frank Schönheit 2009-02-11 07:35:54 UTC 
fs->jsk: please verify in CWS dba31i
Comment 10 joerg.skottke 2009-02-12 12:58:13 UTC 
Verified in CWS dab31i/m41.
Comment 11 Mathias_Bauer 2009-02-12 15:21:29 UTC 
The patch looks fine.
Comment 12 Frank Schönheit 2009-02-12 16:22:47 UTC 
thanks for the review
Comment 13 marc.neumann 2009-02-25 08:32:53 UTC 
Hi,

this is fixed in master OOO310_m2.

I close this issue now.

Bye Marc